mirror of
				git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
				synced 2025-09-18 22:14:16 +00:00 
			
		
		
		
	 8f3ab6e4be
			
		
	
	
		8f3ab6e4be
		
			
		
	
	
	
	
		
			
			Common code doesn't test the error flag, so we don't need to set it in nfs. We can use folio_end_read() to combine the setting (or not) of the uptodate flag and clearing the lock flag. Cc: Trond Myklebust <trond.myklebust@hammerspace.com> Cc: Anna Schumaker <anna@kernel.org> Cc: linux-nfs@vger.kernel.org Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Link: https://lore.kernel.org/r/20240530202110.2653630-10-willy@infradead.org Signed-off-by: Christian Brauner <brauner@kernel.org>
		
			
				
	
	
		
			77 lines
		
	
	
	
		
			1.7 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			77 lines
		
	
	
	
		
			1.7 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| // SPDX-License-Identifier: GPL-2.0
 | |
| /*
 | |
|  *  linux/fs/nfs/symlink.c
 | |
|  *
 | |
|  *  Copyright (C) 1992  Rick Sladkey
 | |
|  *
 | |
|  *  Optimization changes Copyright (C) 1994 Florian La Roche
 | |
|  *
 | |
|  *  Jun 7 1999, cache symlink lookups in the page cache.  -DaveM
 | |
|  *
 | |
|  *  nfs symlink handling code
 | |
|  */
 | |
| 
 | |
| #include <linux/time.h>
 | |
| #include <linux/errno.h>
 | |
| #include <linux/sunrpc/clnt.h>
 | |
| #include <linux/nfs.h>
 | |
| #include <linux/nfs2.h>
 | |
| #include <linux/nfs_fs.h>
 | |
| #include <linux/pagemap.h>
 | |
| #include <linux/stat.h>
 | |
| #include <linux/mm.h>
 | |
| #include <linux/string.h>
 | |
| 
 | |
| /* Symlink caching in the page cache is even more simplistic
 | |
|  * and straight-forward than readdir caching.
 | |
|  */
 | |
| 
 | |
| static int nfs_symlink_filler(struct file *file, struct folio *folio)
 | |
| {
 | |
| 	struct inode *inode = folio->mapping->host;
 | |
| 	int error;
 | |
| 
 | |
| 	error = NFS_PROTO(inode)->readlink(inode, &folio->page, 0, PAGE_SIZE);
 | |
| 	folio_end_read(folio, error == 0);
 | |
| 	return error;
 | |
| }
 | |
| 
 | |
| static const char *nfs_get_link(struct dentry *dentry,
 | |
| 				struct inode *inode,
 | |
| 				struct delayed_call *done)
 | |
| {
 | |
| 	struct page *page;
 | |
| 	void *err;
 | |
| 
 | |
| 	if (!dentry) {
 | |
| 		err = ERR_PTR(nfs_revalidate_mapping_rcu(inode));
 | |
| 		if (err)
 | |
| 			return err;
 | |
| 		page = find_get_page(inode->i_mapping, 0);
 | |
| 		if (!page)
 | |
| 			return ERR_PTR(-ECHILD);
 | |
| 		if (!PageUptodate(page)) {
 | |
| 			put_page(page);
 | |
| 			return ERR_PTR(-ECHILD);
 | |
| 		}
 | |
| 	} else {
 | |
| 		err = ERR_PTR(nfs_revalidate_mapping(inode, inode->i_mapping));
 | |
| 		if (err)
 | |
| 			return err;
 | |
| 		page = read_cache_page(&inode->i_data, 0, nfs_symlink_filler,
 | |
| 				NULL);
 | |
| 		if (IS_ERR(page))
 | |
| 			return ERR_CAST(page);
 | |
| 	}
 | |
| 	set_delayed_call(done, page_put_link, page);
 | |
| 	return page_address(page);
 | |
| }
 | |
| 
 | |
| /*
 | |
|  * symlinks can't do much...
 | |
|  */
 | |
| const struct inode_operations nfs_symlink_inode_operations = {
 | |
| 	.get_link	= nfs_get_link,
 | |
| 	.getattr	= nfs_getattr,
 | |
| 	.setattr	= nfs_setattr,
 | |
| };
 |