public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
linux/drivers/net/wireless/ath
History
Sven Eckelmann 5da7acfec5 ath11k: Reset ath11k_skb_cb before setting new flags 
It was observed that the codepath for the ATH11K_SKB_HW_80211_ENCAP was
used even when the IEEE80211_TX_CTRL_HW_80211_ENCAP was not enabled for a
an skbuff. This became even more prominent when the QCAs wlan-open patchset
for ath11k [1] was applied and a sane looking fix just caused crashes when
injecting frames via a monitor interface (for example with ratechecker):

  [   86.963152] Unable to handle kernel NULL pointer dereference at virtual address 00000338
  [   86.963192] pgd = ffffffc0008f0000
  [   86.971034] [00000338] *pgd=0000000051706003, *pud=0000000051706003, *pmd=0000000051707003, *pte=00e800000b000707
  [   86.984292] Internal error: Oops: 96000006 [#1] PREEMPT SMP
  [...]
  [   87.713339] [<ffffffbffc802480>] ieee80211_tx_status_8023+0xf8/0x220 [mac80211]
  [   87.715654] [<ffffffbffc98bad4>] ath11k_dp_tx_completion_handler+0x42c/0xa10 [ath11k]
  [   87.722924] [<ffffffbffc989190>] ath11k_dp_service_srng+0x70/0x3c8 [ath11k]
  [   87.730831] [<ffffffbffca03460>] 0xffffffbffca03460
  [   87.737599] [<ffffffc00046ef58>] net_rx_action+0xf8/0x288
  [   87.742462] [<ffffffc000097554>] __do_softirq+0xfc/0x220
  [   87.748014] [<ffffffc000097900>] irq_exit+0x98/0xe8
  [   87.753396] [<ffffffc0000cf188>] __handle_domain_irq+0x90/0xb8
  [   87.757999] [<ffffffc000081ca4>] gic_handle_irq+0x6c/0xc8
  [   87.763899] Exception stack(0xffffffc00081bdc0 to 0xffffffc00081bef0)

Problem is that the state of ath11k_skb_cb->flags must be considered
unknown and could contain anything when it is not manually initialized. So
it could also contain ATH11K_SKB_HW_80211_ENCAP. And this can result in the
code to assume that the ath11k_skb_cb->vif is set - even when this is not
always the case for non ATH11K_SKB_HW_80211_ENCAP transmissions.

Tested-on: IPQ8074 hw2.0 WLAN.HK.2.4.0.1.r1-00026-QCAHKSWPL_SILICONZ-2

[1] https://source.codeaurora.org/quic/qsdk/oss/system/feeds/wlan-open/tree/mac80211/patches?h=NHSS.QSDK.11.4.r3
    (162 patches at the moment which are often not upstreamed but essential
     to get ath11k working)

Fixes: e7f33e0c52 ("ath11k: add tx hw 802.11 encapsulation offloading support")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201119154235.263250-2-sven@narfation.org
2020-12-02 20:19:03 +02:00
..
ar5523
ath5k ath5k: convert to use DEFINE_SEQ_ATTRIBUTE macro 2020-09-22 10:46:21 +03:00
ath6kl ath6kl: fix enum-conversion warning 2020-11-07 10:08:33 +02:00
ath9k ath9k: work around false-positive gcc warning 2020-11-10 20:12:42 +02:00
ath10k ath10k: add target IRAM recovery feature support 2020-11-23 20:07:20 +02:00
ath11k ath11k: Reset ath11k_skb_cb before setting new flags 2020-12-02 20:19:03 +02:00
carl9170 carl9170: Convert 'ar9170_qmap' to inline function 2020-08-31 18:19:26 +03:00
wcn36xx wcn36xx: Enable firmware offloaded keepalive 2020-11-07 10:09:21 +02:00
wil6210 wil6210: wmi: Correct misnamed function parameter 'ptr_' 2020-11-07 10:09:56 +02:00
ath.h
debug.c
dfs_pattern_detector.c ath: dfs_pattern_detector: Fix some function kernel-doc headers 2020-11-07 10:06:46 +02:00
dfs_pattern_detector.h
dfs_pri_detector.c ath: dfs_pri_detector: Demote zero/half completed kernel-doc headers 2020-11-07 10:06:49 +02:00
dfs_pri_detector.h
hw.c
Kconfig
key.c
main.c
Makefile
reg.h
regd.c ath: regd: Provide description for ath_reg_apply_ir_flags's 'reg' param 2020-11-07 10:06:43 +02:00
regd.h
regd_common.h
spectral_common.h
trace.c
trace.h