mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
4bb0e6d725
The device node iterators perform an of_node_get on each iteration, so a jump out of the loop requires an of_node_put. Remote and port also have augmented reference counts, so drop them on each iteration and at the end of the function, respectively. Remote is only used for the address it contains, not for the contents of that address, so the reference count can be dropped immediately. The semantic patch that fixes the first part of this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ expression root,e; local idexpression child; iterator name for_each_child_of_node; @@ for_each_available_child_of_node(root, child) { ... when != of_node_put(child) when != e = child + of_node_put(child); ? break; ... } ... when != child // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> Link: https://patchwork.freedesktop.org/patch/msgid/1547369264-24831-5-git-send-email-Julia.Lawall@lip6.fr |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| sun4i_backend.c | ||
| sun4i_backend.h | ||
| sun4i_crtc.c | ||
| sun4i_crtc.h | ||
| sun4i_dotclock.c | ||
| sun4i_dotclock.h | ||
| sun4i_drv.c | ||
| sun4i_drv.h | ||
| sun4i_framebuffer.c | ||
| sun4i_framebuffer.h | ||
| sun4i_frontend.c | ||
| sun4i_frontend.h | ||
| sun4i_hdmi.h | ||
| sun4i_hdmi_ddc_clk.c | ||
| sun4i_hdmi_enc.c | ||
| sun4i_hdmi_i2c.c | ||
| sun4i_hdmi_tmds_clk.c | ||
| sun4i_layer.c | ||
| sun4i_layer.h | ||
| sun4i_lvds.c | ||
| sun4i_lvds.h | ||
| sun4i_rgb.c | ||
| sun4i_rgb.h | ||
| sun4i_tcon.c | ||
| sun4i_tcon.h | ||
| sun4i_tv.c | ||
| sun6i_drc.c | ||
| sun6i_mipi_dphy.c | ||
| sun6i_mipi_dsi.c | ||
| sun6i_mipi_dsi.h | ||
| sun8i_csc.c | ||
| sun8i_csc.h | ||
| sun8i_dw_hdmi.c | ||
| sun8i_dw_hdmi.h | ||
| sun8i_hdmi_phy.c | ||
| sun8i_hdmi_phy_clk.c | ||
| sun8i_mixer.c | ||
| sun8i_mixer.h | ||
| sun8i_tcon_top.c | ||
| sun8i_tcon_top.h | ||
| sun8i_ui_layer.c | ||
| sun8i_ui_layer.h | ||
| sun8i_ui_scaler.c | ||
| sun8i_ui_scaler.h | ||
| sun8i_vi_layer.c | ||
| sun8i_vi_layer.h | ||
| sun8i_vi_scaler.c | ||
| sun8i_vi_scaler.h | ||
| sunxi_engine.h | ||