linux/scripts/package
Masahiro Yamada 4b970e4365 kbuild: deb-pkg: use Debian compliant shebang for debian/rules
Debian Policy "4.9. Main building script: debian/rules" requires
"debian/rules must start with the line #!/usr/bin/make -f". [1]

Currently, Kbuild does not follow this policy.

When Kbuild generates debian/rules, "#!$(command -v $MAKE) -f" is
expanded by shell. The resuling string may not be "#!/usr/bin/make -f".

There was a reason to opt out the Debian policy.

If you run '/path/to/my/custom/make deb-pkg', debian/rules must also be
invoked by the same Make program. If #!/usr/bin/make were hard-coded in
debian/rules, the sub-make would be executed by a possibly different
Make version.

This is problematic due to the MAKEFLAGS incompatibility, especially the
job server flag. Old Make versions used --jobserver-fds to propagate job
server file descriptors, but Make >= 4.2 uses --jobserver-auth. The flag
disagreement between the parent/child Makes would result in a process
fork explosion.

However, having a non-standard path in the shebang causes another issue;
the generated source package is not portable as such a path does not
exist in other build environments.

This commit solves those conflicting demands.

Hard-code '#!/usr/bin/make -f' in debian/rules to create a portable and
Debian-compliant source package.

Pass '--rules-file=$(MAKE) -f debian/rules' when dpkg-buildpackage is
invoked from Makefile so that debian/rules is executed by the same Make
program as used to start Kbuild.

[1] https://www.debian.org/doc/debian-policy/ch-source.html#main-building-script-debian-rules

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
2023-08-08 01:08:54 +09:00
..
builddeb kbuild: refactor kernel-devel RPM package and linux-headers Deb package 2023-07-25 00:59:32 +09:00
buildtar kbuild: tar-pkg: use tar rules in scripts/Makefile.package 2023-02-26 15:23:30 +09:00
deb-build-option kbuild: deb-pkg: set CROSS_COMPILE only when undefined 2023-03-15 15:15:07 +09:00
gen-diff-patch kbuild: give up untracked files for source package builds 2023-04-11 08:58:45 +09:00
install-extmod-build kbuild: refactor kernel-devel RPM package and linux-headers Deb package 2023-07-25 00:59:32 +09:00
kernel.spec kbuild: rpm-pkg: split out the body of spec file 2023-07-25 00:59:33 +09:00
mkdebian kbuild: deb-pkg: use Debian compliant shebang for debian/rules 2023-08-08 01:08:54 +09:00
mkspec kbuild: rpm-pkg: refactor *rpm-pkg targets 2023-07-25 00:59:33 +09:00
snapcraft.template scripts/package: snap-pkg target 2017-12-13 00:00:18 +09:00