Linus Torvalds 4356e9f841 work around gcc bugs with 'asm goto' with outputs ... We've had issues with gcc and 'asm goto' before, and we created a 'asm_volatile_goto()' macro for that in the past: see commits 3f0116c323 ("compiler/gcc4: Add quirk for 'asm goto' miscompilation bug") and a9f180345f ("compiler/gcc4: Make quirk for asm_volatile_goto() unconditional"). Then, much later, we ended up removing the workaround in commit 43c249ea0b ("compiler-gcc.h: remove ancient workaround for gcc PR 58670") because we no longer supported building the kernel with the affected gcc versions, but we left the macro uses around. Now, Sean Christopherson reports a new version of a very similar problem, which is fixed by re-applying that ancient workaround. But the problem in question is limited to only the 'asm goto with outputs' cases, so instead of re-introducing the old workaround as-is, let's rename and limit the workaround to just that much less common case. It looks like there are at least two separate issues that all hit in this area: (a) some versions of gcc don't mark the asm goto as 'volatile' when it has outputs: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98619 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110420 which is easy to work around by just adding the 'volatile' by hand. (b) Internal compiler errors: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110422 which are worked around by adding the extra empty 'asm' as a barrier, as in the original workaround. but the problem Sean sees may be a third thing since it involves bad code generation (not an ICE) even with the manually added 'volatile'. but the same old workaround works for this case, even if this feels a bit like voodoo programming and may only be hiding the issue. Reported-and-tested-by: Sean Christopherson <seanjc@google.com> Link: https://lore.kernel.org/all/20240208220604.140859-1-seanjc@google.com/ Cc: Nick Desaulniers <ndesaulniers@google.com> Cc: Uros Bizjak <ubizjak@gmail.com> Cc: Jakub Jelinek <jakub@redhat.com> Cc: Andrew Pinski <quic_apinski@quicinc.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2024-02-09 15:57:48 -08:00
..
adi.h
adi_64.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 482	2019-06-19 17:09:52 +02:00
apb.h
asm-offsets.h
asm-prototypes.h
asm.h
asmmacro.h
atomic.h
atomic_32.h	locking/atomic: sparc: add preprocessor symbols	2023-06-05 09:57:17 +02:00
atomic_64.h	locking/atomic: sparc: add preprocessor symbols	2023-06-05 09:57:17 +02:00
auxio.h
auxio_32.h
auxio_64.h
backoff.h	SPARC: backoff.h: delete a duplicated word	2020-07-21 18:22:02 -07:00
barrier.h
barrier_32.h
barrier_64.h
bbc.h
bitext.h
bitops.h
bitops_32.h	bitops: wrap non-atomic bitops with a transparent macro	2022-06-30 19:52:41 -07:00
bitops_64.h	include: move find.h from asm_generic to linux	2022-01-15 08:47:31 -08:00
btext.h
bug.h
cache.h	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
cacheflush.h
cacheflush_32.h	mm: Introduce flush_cache_vmap_early()	2023-12-14 00:23:17 -08:00
cacheflush_64.h	mm: Introduce flush_cache_vmap_early()	2023-12-14 00:23:17 -08:00
cachetlb_32.h
chafsr.h
checksum.h	sparc64: propagate the calling convention changes down to __csum_partial_copy_...()	2020-08-20 15:45:21 -04:00
checksum_32.h	sparc64: propagate the calling convention changes down to __csum_partial_copy_...()	2020-08-20 15:45:21 -04:00
checksum_64.h	sparc64: propagate the calling convention changes down to __csum_partial_copy_...()	2020-08-20 15:45:21 -04:00
chmctrl.h
clock.h
clocksource.h
cmpxchg.h
cmpxchg_32.h	sparc: mark __arch_xchg() as __always_inline	2023-07-13 09:54:32 -07:00
cmpxchg_64.h	sparc: mark __arch_xchg() as __always_inline	2023-07-13 09:54:32 -07:00
compat.h	asm-generic: compat: Cleanup duplicate definitions	2022-04-26 13:35:54 -07:00
compat_signal.h
contregs.h
cpu_type.h
cpudata.h
cpudata_32.h
cpudata_64.h	sparc64: Make proc_id signed.	2018-10-14 20:19:31 -07:00
current.h
dcr.h
dcu.h
delay.h
delay_32.h
delay_64.h
device.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428	2019-06-05 17:37:16 +02:00
dma-mapping.h	dma-mapping: no need to pass a bus_type into get_arch_dma_ops()	2023-02-15 12:35:20 +01:00
dma.h	PCI: Move isa_dma_bridge_buggy out of asm/dma.h	2022-07-22 17:24:47 -05:00
ebus_dma.h
ecc.h
eeprom.h
elf.h
elf_32.h
elf_64.h	sparc32: switch to generic extables	2021-01-03 20:05:18 -05:00
estate.h
extable.h	sparc32: switch to generic extables	2021-01-03 20:05:18 -05:00
fb.h	fbdev: Replace fb_pgprotect() with pgprot_framebuffer()	2023-10-12 09:20:46 +02:00
fbio.h
fhc.h
floppy.h
floppy_32.h	sparc: Explicitly include correct DT includes	2023-08-28 13:30:57 -05:00
floppy_64.h	sparc: Explicitly include correct DT includes	2023-08-28 13:30:57 -05:00
fpumacro.h
ftrace.h	tracing: Fix various typos in comments	2021-03-23 14:08:18 -04:00
futex.h
futex_32.h
futex_64.h	[parisc, s390, sparc64] no need for access_ok() in futex handling	2020-03-27 23:58:52 -04:00
hardirq.h
hardirq_32.h
hardirq_64.h
head.h
head_32.h
head_64.h
hibernate.h
highmem.h	sparc/mm/highmem: flush cache and TLB	2021-01-24 10:34:52 -08:00
hugetlb.h	mm: hugetlb: add huge page size param to set_huge_pte_at()	2023-09-29 17:20:47 -07:00
hvtramp.h
hw_irq.h
hypervisor.h
idprom.h
intr_queue.h
io-unit.h	mm: reorder includes after introduction of linux/pgtable.h	2020-06-09 09:39:13 -07:00
io.h	sparc: Fix the generic IO helpers	2022-09-08 16:49:14 +02:00
io_32.h	sparc32: Move ioremap/iounmap declaration before asm-generic/io.h include	2020-10-05 09:44:41 +01:00
io_64.h	asm/io: remove unnecessary xlate_dev_mem_ptr() and unxlate_dev_mem_ptr()	2023-11-23 10:37:40 +01:00
ioctls.h
iommu-common.h
iommu.h
iommu_32.h
iommu_64.h
irq.h
irq_32.h	init: consolidate prototypes in linux/init.h	2023-06-09 17:44:16 -07:00
irq_64.h	nmi_backtrace: allow excluding an arbitrary CPU	2023-08-18 10:19:00 -07:00
irqflags.h
irqflags_32.h
irqflags_64.h
jump_label.h	work around gcc bugs with 'asm goto' with outputs	2024-02-09 15:57:48 -08:00
Kbuild	sparc: remove <asm/export.h>	2023-08-22 18:12:46 +09:00
kdebug.h
kdebug_32.h
kdebug_64.h
kgdb.h
kprobes.h	kprobes: unify kprobes_exceptions_nofify() prototypes	2023-11-10 19:59:05 +09:00
ldc.h
leon.h	DMA mapping updates for Linux 4.21	2018-12-28 14:12:21 -08:00
leon_amba.h
leon_pci.h
lsu.h
machines.h
mbus.h
mc146818rtc.h
mc146818rtc_32.h
mc146818rtc_64.h
mdesc.h
memctrl.h
mman.h	sparc/mm: enable ARCH_HAS_VM_GET_PAGE_PROT	2022-04-28 23:16:13 -07:00
mmu.h
mmu_32.h
mmu_64.h
mmu_context.h
mmu_context_32.h	sparc: use asm-generic/mmu_context.h for no-op implementations	2020-10-27 16:02:38 +01:00
mmu_context_64.h	mm: Expose untagging mask in /proc/$PID/status	2023-03-16 13:08:40 -07:00
mmzone.h	mm: replace CONFIG_NEED_MULTIPLE_NODES with CONFIG_NUMA	2021-06-29 10:53:55 -07:00
mxcc.h
nmi.h	watchdog/hardlockup: declare arch_touch_nmi_watchdog() only in linux/nmi.h	2023-06-19 16:25:29 -07:00
ns87303.h
obio.h
openprom.h
oplib.h
oplib_32.h
oplib_64.h
page.h
page_32.h	mm, arch: add generic implementation of pfn_valid() for FLATMEM	2023-02-09 16:51:41 -08:00
page_64.h	mm/vma: define a default value for VM_DATA_DEFAULT_FLAGS	2020-04-10 15:36:21 -07:00
parport.h	sparc: Explicitly include correct DT includes	2023-08-28 13:30:57 -05:00
pbm.h
pci.h	Merge branch 'pci/header-cleanup-immutable'	2022-08-04 11:46:53 -05:00
pcic.h
pcr.h
percpu.h
percpu_32.h
percpu_64.h	sparc64: Fix asm/percpu.h build error	2020-07-10 12:00:01 +02:00
perf_event.h
pgalloc.h
pgalloc_32.h	mm/thp: define default pmd_pgtable()	2021-07-01 11:06:03 -07:00
pgalloc_64.h	sparc: add pte_free_defer() for pte_t *pgtable_t	2023-08-18 10:12:24 -07:00
pgtable.h
pgtable_32.h	Add x86 shadow stack support	2023-08-31 12:20:12 -07:00
pgtable_64.h	mm/mglru: add dummy pmd_dirty()	2024-01-05 10:17:44 -08:00
pgtsrmmu.h	sparc/mm: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE on 32bit	2023-02-02 22:33:10 -08:00
pil.h
processor.h
processor_32.h	kernel: exit: cleanup release_thread()	2022-09-11 21:55:07 -07:00
processor_64.h	locking: remove spin_lock_prefetch	2023-08-12 09:18:47 -07:00
prom.h	of: Make devtree_lock declaration private	2023-04-10 18:32:31 -05:00
psr.h
ptrace.h	ptrace: Remove the unnecessary arguments from arch_ptrace_stop	2021-10-06 11:27:41 -05:00
qrwlock.h
qspinlock.h
ross.h
sbi.h
scratchpad.h
seccomp.h
sections.h
setup.h
sfafsr.h
sfp-machine.h
sfp-machine_32.h
sfp-machine_64.h
shmparam.h
shmparam_32.h
shmparam_64.h
sigcontext.h
signal.h	sparc: remove SA_STATIC_ALLOC macro definition	2020-09-14 17:04:49 -07:00
smp.h
smp_32.h	sparc: Unbreak the build	2022-09-29 19:21:10 -07:00
smp_64.h	sparc/cpu: Mark cpu_play_dead() __noreturn	2023-03-08 08:44:25 -08:00
sparsemem.h	sparc: drop unused MAX_PHYSADDR_BITS	2020-08-12 10:57:57 -07:00
spinlock.h
spinlock_32.h
spinlock_64.h	locking/arch: Move qrwlock.h include after qspinlock.h	2021-02-11 07:59:54 -05:00
spinlock_types.h
spitfire.h
stacktrace.h
starfire.h
string.h	sparc: revive __HAVE_ARCH_STRLEN for 32bit sparc	2020-03-25 10:19:43 +09:00
string_32.h
string_64.h	sparc: revive __HAVE_ARCH_STRLEN for 32bit sparc	2020-03-25 10:19:43 +09:00
sunbpp.h
swift.h
switch_to.h
switch_to_32.h
switch_to_64.h	sparc64: remove CONFIG_SET_FS support	2022-02-25 09:36:06 +01:00
syscall.h	arch: remove unused function syscall_set_arguments()	2021-09-14 16:06:20 +02:00
syscalls.h	sparc64: enable HAVE_COPY_THREAD_TLS	2020-06-23 10:49:54 +02:00
termbits.h
thread_info.h
thread_info_32.h	sparc: add support for TIF_NOTIFY_SIGNAL	2020-12-12 09:17:38 -07:00
thread_info_64.h	sparc64: remove CONFIG_SET_FS support	2022-02-25 09:36:06 +01:00
timer.h
timer_32.h
timer_64.h	init: consolidate prototypes in linux/init.h	2023-06-09 17:44:16 -07:00
timex.h
timex_32.h	sparc: use fallback for random_get_entropy() instead of zero	2022-05-13 23:59:23 +02:00
timex_64.h
tlb.h
tlb_32.h	arch/tlb: Clean up simple architectures	2019-04-03 10:32:54 +02:00
tlb_64.h	mmu_gather: Remove per arch tlb_{start,end}_vma()	2022-07-21 10:50:13 -07:00
tlbflush.h
tlbflush_32.h
tlbflush_64.h
topology.h
topology_32.h
topology_64.h
trap_block.h	sparc64: Fix asm/percpu.h build error	2020-07-10 12:00:01 +02:00
traps.h
tsb.h
tsunami.h
ttable.h
turbosparc.h
uaccess.h	uaccess: generalize access_ok()	2022-02-25 09:36:05 +01:00
uaccess_32.h	uaccess: remove CONFIG_SET_FS	2022-02-25 09:36:06 +01:00
uaccess_64.h	mm: Introduce untagged_addr_remote()	2023-03-16 13:08:39 -07:00
unistd.h	fs: stat: compat: Add __ARCH_WANT_COMPAT_STAT	2022-04-26 13:35:45 -07:00
upa.h
uprobes.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
user.h
vaddrs.h	sparc/mm/highmem: Switch to generic kmap atomic	2020-11-06 23:14:57 +01:00
vdso.h	sparc: Fix VDSO build with older binutils.	2018-10-25 10:36:19 -07:00
vga.h
viking.h	sparc32: mm: Restructure sparc32 MMU page-table layout	2020-05-13 15:32:00 -07:00
vio.h	tty: vcc: convert counts to size_t	2023-08-11 21:12:47 +02:00
visasm.h
vmalloc.h	mm/vmalloc: Add empty <asm/vmalloc.h> headers and use them from <linux/vmalloc.h>	2019-12-10 10:12:55 +01:00
vvar.h	locking/seqlock, headers: Untangle the spaghetti monster	2020-08-06 16:13:13 +02:00
winmacro.h
xor.h
xor_32.h	lib/xor: make xor prototypes more friendly to compiler vectorization	2022-02-11 20:39:39 +11:00
xor_64.h	lib/xor: make xor prototypes more friendly to compiler vectorization	2022-02-11 20:39:39 +11:00