Kan Liang ed6c166cc7 perf diff: Do not overwrite valid build id ... Fixes a perf diff regression issue which was introduced by commit 5baecbcd9c ("perf symbols: we can now read separate debug-info files based on a build ID") The binary name could be same when perf diff different binaries. Build id is used to distinguish between them. However, the previous patch assumes the same binary name has same build id. So it overwrites the build id according to the binary name, regardless of whether the build id is set or not. Check the has_build_id in dso__load. If the build id is already set, use it. Before the fix: $ perf diff 1.perf.data 2.perf.data # Event 'cycles' # # Baseline Delta Shared Object Symbol # ........ ....... ................ ............................. # 99.83% -99.80% tchain_edit [.] f2 0.12% +99.81% tchain_edit [.] f3 0.02% -0.01% [ixgbe] [k] ixgbe_read_reg After the fix: $ perf diff 1.perf.data 2.perf.data # Event 'cycles' # # Baseline Delta Shared Object Symbol # ........ ....... ................ ............................. # 99.83% +0.10% tchain_edit [.] f3 0.12% -0.08% tchain_edit [.] f2 Signed-off-by: Kan Liang <kan.liang@intel.com> Cc: Andi Kleen <andi@firstfloor.org> CC: Dima Kogan <dima@secretsauce.net> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Fixes: 5baecbcd9c ("perf symbols: we can now read separate debug-info files based on a build ID") Link: http://lkml.kernel.org/r/1481642984-13593-1-git-send-email-kan.liang@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>		2016-12-20 12:00:38 -03:00
..
accounting
arch	Merge branch 'core/urgent' into x86/fpu, to merge fixes	2016-11-01 07:47:40 +01:00
build	perf build: Check LLVM version in feature check	2016-12-06 13:21:55 -03:00
cgroup
firewire
gpio
hv	tools: hv: Enable network manager for bonding scripts on RHEL	2016-12-06 10:13:55 -05:00
iio
include	tools lib bpf: Sync {tools,}/include/uapi/linux/bpf.h	2016-12-15 16:25:46 -03:00
kvm/kvm_stat
laptop
lguest
lib	tools lib bpf: Add flags to bpf_create_map()	2016-12-15 16:25:47 -03:00
net
nfsd
objtool	objtool: Fix bytes check of lea's rex_prefix	2016-12-06 09:20:59 +01:00
pcmcia
perf	perf diff: Do not overwrite valid build id	2016-12-20 12:00:38 -03:00
power	tools/power/acpi: Remove direct kernel source include reference	2016-11-16 22:31:26 +01:00
scripts
spi
testing	These are the documentation changes for 4.10.	2016-12-12 21:58:13 -08:00
thermal/tmon
time
usb
virtio	ringtest: poll for new buffers once before updating event index	2016-10-31 00:21:43 +02:00
vm
Makefile