mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-05-24 10:39:52 +00:00
ea1b3bc6d5
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. In doing this, make brcmf_debugfs_add_entry() return void as no one was even paying attention to the return value. Cc: Arend van Spriel <arend.vanspriel@broadcom.com> Cc: Franky Lin <franky.lin@broadcom.com> Cc: Hante Meuleman <hante.meuleman@broadcom.com> Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com> Cc: Wright Feng <wright.feng@cypress.com> Cc: Kalle Valo <kvalo@codeaurora.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "Rafał Miłecki" <rafal@milecki.pl> Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/20200429101526.GA2094124@kroah.com
140 lines
4.1 KiB
C
140 lines
4.1 KiB
C
// SPDX-License-Identifier: ISC
|
|
/*
|
|
* Copyright (c) 2010 Broadcom Corporation
|
|
*/
|
|
|
|
#ifndef BRCMFMAC_DEBUG_H
|
|
#define BRCMFMAC_DEBUG_H
|
|
|
|
#include <linux/net.h> /* net_ratelimit() */
|
|
|
|
/* message levels */
|
|
#define BRCMF_TRACE_VAL 0x00000002
|
|
#define BRCMF_INFO_VAL 0x00000004
|
|
#define BRCMF_DATA_VAL 0x00000008
|
|
#define BRCMF_CTL_VAL 0x00000010
|
|
#define BRCMF_TIMER_VAL 0x00000020
|
|
#define BRCMF_HDRS_VAL 0x00000040
|
|
#define BRCMF_BYTES_VAL 0x00000080
|
|
#define BRCMF_INTR_VAL 0x00000100
|
|
#define BRCMF_GLOM_VAL 0x00000200
|
|
#define BRCMF_EVENT_VAL 0x00000400
|
|
#define BRCMF_BTA_VAL 0x00000800
|
|
#define BRCMF_FIL_VAL 0x00001000
|
|
#define BRCMF_USB_VAL 0x00002000
|
|
#define BRCMF_SCAN_VAL 0x00004000
|
|
#define BRCMF_CONN_VAL 0x00008000
|
|
#define BRCMF_BCDC_VAL 0x00010000
|
|
#define BRCMF_SDIO_VAL 0x00020000
|
|
#define BRCMF_MSGBUF_VAL 0x00040000
|
|
#define BRCMF_PCIE_VAL 0x00080000
|
|
#define BRCMF_FWCON_VAL 0x00100000
|
|
|
|
/* set default print format */
|
|
#undef pr_fmt
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
struct brcmf_bus;
|
|
|
|
__printf(3, 4)
|
|
void __brcmf_err(struct brcmf_bus *bus, const char *func, const char *fmt, ...);
|
|
/* Macro for error messages. When debugging / tracing the driver all error
|
|
* messages are important to us.
|
|
*/
|
|
#ifndef brcmf_err
|
|
#define brcmf_err(fmt, ...) \
|
|
do { \
|
|
if (IS_ENABLED(CONFIG_BRCMDBG) || \
|
|
IS_ENABLED(CONFIG_BRCM_TRACING) || \
|
|
net_ratelimit()) \
|
|
__brcmf_err(NULL, __func__, fmt, ##__VA_ARGS__);\
|
|
} while (0)
|
|
#endif
|
|
|
|
#define bphy_err(drvr, fmt, ...) \
|
|
do { \
|
|
if (IS_ENABLED(CONFIG_BRCMDBG) || \
|
|
IS_ENABLED(CONFIG_BRCM_TRACING) || \
|
|
net_ratelimit()) \
|
|
wiphy_err((drvr)->wiphy, "%s: " fmt, __func__, \
|
|
##__VA_ARGS__); \
|
|
} while (0)
|
|
|
|
#if defined(DEBUG) || defined(CONFIG_BRCM_TRACING)
|
|
|
|
/* For debug/tracing purposes treat info messages as errors */
|
|
#define brcmf_info brcmf_err
|
|
|
|
__printf(3, 4)
|
|
void __brcmf_dbg(u32 level, const char *func, const char *fmt, ...);
|
|
#define brcmf_dbg(level, fmt, ...) \
|
|
do { \
|
|
__brcmf_dbg(BRCMF_##level##_VAL, __func__, \
|
|
fmt, ##__VA_ARGS__); \
|
|
} while (0)
|
|
#define BRCMF_DATA_ON() (brcmf_msg_level & BRCMF_DATA_VAL)
|
|
#define BRCMF_CTL_ON() (brcmf_msg_level & BRCMF_CTL_VAL)
|
|
#define BRCMF_HDRS_ON() (brcmf_msg_level & BRCMF_HDRS_VAL)
|
|
#define BRCMF_BYTES_ON() (brcmf_msg_level & BRCMF_BYTES_VAL)
|
|
#define BRCMF_GLOM_ON() (brcmf_msg_level & BRCMF_GLOM_VAL)
|
|
#define BRCMF_EVENT_ON() (brcmf_msg_level & BRCMF_EVENT_VAL)
|
|
#define BRCMF_FIL_ON() (brcmf_msg_level & BRCMF_FIL_VAL)
|
|
#define BRCMF_FWCON_ON() (brcmf_msg_level & BRCMF_FWCON_VAL)
|
|
#define BRCMF_SCAN_ON() (brcmf_msg_level & BRCMF_SCAN_VAL)
|
|
|
|
#else /* defined(DEBUG) || defined(CONFIG_BRCM_TRACING) */
|
|
|
|
#define brcmf_info(fmt, ...) \
|
|
do { \
|
|
pr_info("%s: " fmt, __func__, ##__VA_ARGS__); \
|
|
} while (0)
|
|
|
|
#define brcmf_dbg(level, fmt, ...) no_printk(fmt, ##__VA_ARGS__)
|
|
|
|
#define BRCMF_DATA_ON() 0
|
|
#define BRCMF_CTL_ON() 0
|
|
#define BRCMF_HDRS_ON() 0
|
|
#define BRCMF_BYTES_ON() 0
|
|
#define BRCMF_GLOM_ON() 0
|
|
#define BRCMF_EVENT_ON() 0
|
|
#define BRCMF_FIL_ON() 0
|
|
#define BRCMF_FWCON_ON() 0
|
|
#define BRCMF_SCAN_ON() 0
|
|
|
|
#endif /* defined(DEBUG) || defined(CONFIG_BRCM_TRACING) */
|
|
|
|
#define brcmf_dbg_hex_dump(test, data, len, fmt, ...) \
|
|
do { \
|
|
trace_brcmf_hexdump((void *)data, len); \
|
|
if (test) \
|
|
brcmu_dbg_hex_dump(data, len, fmt, ##__VA_ARGS__); \
|
|
} while (0)
|
|
|
|
extern int brcmf_msg_level;
|
|
|
|
struct brcmf_bus;
|
|
struct brcmf_pub;
|
|
#ifdef DEBUG
|
|
struct dentry *brcmf_debugfs_get_devdir(struct brcmf_pub *drvr);
|
|
void brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
|
|
int (*read_fn)(struct seq_file *seq, void *data));
|
|
int brcmf_debug_create_memdump(struct brcmf_bus *bus, const void *data,
|
|
size_t len);
|
|
#else
|
|
static inline struct dentry *brcmf_debugfs_get_devdir(struct brcmf_pub *drvr)
|
|
{
|
|
return ERR_PTR(-ENOENT);
|
|
}
|
|
static inline
|
|
void brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
|
|
int (*read_fn)(struct seq_file *seq, void *data))
|
|
{ }
|
|
static inline
|
|
int brcmf_debug_create_memdump(struct brcmf_bus *bus, const void *data,
|
|
size_t len)
|
|
{
|
|
return 0;
|
|
}
|
|
#endif
|
|
|
|
#endif /* BRCMFMAC_DEBUG_H */
|