Filipe Manana 2c58c3931e btrfs: remove BUG() after failure to insert delayed dir index item ... Instead of calling BUG() when we fail to insert a delayed dir index item into the delayed node's tree, we can just release all the resources we have allocated/acquired before and return the error to the caller. This is fine because all existing call chains undo anything they have done before calling btrfs_insert_delayed_dir_index() or BUG_ON (when creating pending snapshots in the transaction commit path). So remove the BUG() call and do proper error handling. This relates to a syzbot report linked below, but does not fix it because it only prevents hitting a BUG(), it does not fix the issue where somehow we attempt to use twice the same index number for different index items. Link: https://lore.kernel.org/linux-btrfs/00000000000036e1290603e097e0@google.com/ CC: stable@vger.kernel.org # 5.4+ Reviewed-by: Qu Wenruo <wqu@suse.com> Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>		2023-09-08 14:11:59 +02:00
..
tests	btrfs: tests: test invalid splitting when skipping pinned drop extent_map	2023-08-21 14:54:49 +02:00
accessors.c
accessors.h	btrfs: use helper sizeof_field in struct accessors	2023-08-21 14:52:13 +02:00
acl.c
acl.h
async-thread.c	btrfs: use alloc_ordered_workqueue() to create ordered workqueues	2023-06-19 13:59:30 +02:00
async-thread.h	btrfs: use alloc_ordered_workqueue() to create ordered workqueues	2023-06-19 13:59:30 +02:00
backref.c	btrfs: remove v0 extent handling	2023-08-21 14:54:48 +02:00
backref.h	btrfs: fix backref walking not returning all inode refs	2023-05-09 22:09:11 +02:00
bio.c	btrfs: add an ordered_extent pointer to struct btrfs_bio	2023-06-19 13:59:36 +02:00
bio.h	btrfs: add an ordered_extent pointer to struct btrfs_bio	2023-06-19 13:59:36 +02:00
block-group.c	btrfs: fix race between finishing block group creation and its item update	2023-09-08 14:10:36 +02:00
block-group.h	btrfs: rename add_new_free_space() to btrfs_add_new_free_space()	2023-08-21 14:52:12 +02:00
block-rsv.c	btrfs: account block group tree when calculating global reserve size	2023-07-20 19:22:54 +02:00
block-rsv.h	btrfs: move btrfs_check_trunc_cache_free_space into block-rsv.c	2023-06-19 13:59:24 +02:00
btrfs_inode.h	btrfs: reduce the number of arguments to btrfs_run_delalloc_range	2023-08-21 14:52:14 +02:00
check-integrity.c	btrfs: rename __btrfs_map_block to btrfs_map_block	2023-06-19 13:59:34 +02:00
check-integrity.h
compression.c	btrfs: make btrfs_compressed_bioset static	2023-06-19 17:01:44 +02:00
compression.h	btrfs: pass an ordered_extent to btrfs_submit_compressed_write	2023-06-19 13:59:36 +02:00
ctree.c	btrfs: replace BUG_ON() at split_item() with proper error handling	2023-06-19 13:59:39 +02:00
ctree.h	btrfs: fix infinite directory reads	2023-08-14 16:17:37 +02:00
defrag.c	btrfs: drop gfp from parameter extent state helpers	2023-06-19 13:59:30 +02:00
defrag.h
delalloc-space.c	btrfs: count extents before taking inode's spinlock when reserving metadata	2023-04-17 18:01:19 +02:00
delalloc-space.h
delayed-inode.c	btrfs: remove BUG() after failure to insert delayed dir index item	2023-09-08 14:11:59 +02:00
delayed-inode.h	btrfs: fix infinite directory reads	2023-08-14 16:17:37 +02:00
delayed-ref.c	btrfs: use a single switch statement when initializing delayed ref head	2023-06-19 13:59:32 +02:00
delayed-ref.h	btrfs: use bool type for delayed ref head fields that are used as booleans	2023-06-19 13:59:32 +02:00
dev-replace.c	btrfs: make find_first_extent_bit() return a boolean	2023-08-21 14:52:12 +02:00
dev-replace.h
dir-item.c
dir-item.h
discard.c	btrfs: unexport btrfs_run_discard_work and make it static	2023-06-19 13:59:25 +02:00
discard.h	btrfs: unexport btrfs_run_discard_work and make it static	2023-06-19 13:59:25 +02:00
disk-io.c	btrfs: fix a compilation error if DEBUG is defined in btree_dirty_folio	2023-09-08 14:11:04 +02:00
disk-io.h	btrfs: make btrfs_cleanup_fs_roots() static	2023-08-21 14:52:18 +02:00
export.c
export.h
extent-io-tree.c	btrfs: make find_first_extent_bit() return a boolean	2023-08-21 14:52:12 +02:00
extent-io-tree.h	btrfs: make find_first_extent_bit() return a boolean	2023-08-21 14:52:12 +02:00
extent-tree.c	btrfs: remove v0 extent handling	2023-08-21 14:54:48 +02:00
extent-tree.h	btrfs: wait on uncached block groups on every allocation loop	2023-08-21 14:54:47 +02:00
extent_io.c	btrfs: zoned: defer advancing meta write pointer	2023-08-21 14:52:19 +02:00
extent_io.h	btrfs: zoned: introduce block group context to btrfs_eb_write_context	2023-08-21 14:52:19 +02:00
extent_map.c	btrfs: fix incorrect splitting in btrfs_drop_extent_map_range	2023-08-18 14:38:10 +02:00
extent_map.h	btrfs: pass the new logical address to split_extent_map	2023-06-19 13:59:33 +02:00
file-item.c	btrfs: scrub: avoid unnecessary csum tree search preparing stripes	2023-08-21 14:54:48 +02:00
file-item.h	btrfs: scrub: avoid unnecessary csum tree search preparing stripes	2023-08-21 14:54:48 +02:00
file.c	btrfs: use LIST_HEAD() to initialize the list_head	2023-08-21 14:54:46 +02:00
file.h
free-space-cache.c	btrfs: zoned: no longer count fresh BG region as zone unusable	2023-08-21 14:52:19 +02:00
free-space-cache.h	btrfs: move btrfs_check_trunc_cache_free_space into block-rsv.c	2023-06-19 13:59:24 +02:00
free-space-tree.c	btrfs: rename add_new_free_space() to btrfs_add_new_free_space()	2023-08-21 14:52:12 +02:00
free-space-tree.h	btrfs: make clear_cache mount option to rebuild FST without disabling it	2023-05-10 14:51:27 +02:00
fs.c
fs.h	btrfs: zoned: activate metadata block group on write time	2023-08-21 14:52:19 +02:00
inode-item.c	btrfs: remove obsolete delayed ref throttling logic when truncating items	2023-04-17 18:01:19 +02:00
inode-item.h	btrfs: move split_flags/combine_flags helpers to inode-item.h	2023-06-19 13:59:25 +02:00
inode.c	btrfs: copy dir permission and time when creating a stub subvolume	2023-08-21 14:54:48 +02:00
ioctl.c	btrfs: release path before inode lookup during the ino lookup ioctl	2023-09-08 14:10:40 +02:00
ioctl.h
Kconfig	btrfs: deprecate integrity checker feature	2023-08-21 14:52:13 +02:00
locking.c	btrfs: add block-group tree to lockdep classes	2023-06-19 13:59:35 +02:00
locking.h	btrfs: do not block starts waiting on previous transaction commit	2023-09-08 14:10:49 +02:00
lru_cache.c
lru_cache.h	btrfs: remove btrfs_lru_cache_is_full() inline function	2023-04-17 18:01:18 +02:00
lzo.c	btrfs: disable allocation warnings for compression workspaces	2023-06-19 13:59:34 +02:00
Makefile
messages.c	btrfs: remove v0 extent handling	2023-08-21 14:54:48 +02:00
messages.h	btrfs: remove v0 extent handling	2023-08-21 14:54:48 +02:00
misc.h	btrfs: export bitmap_test_range_all_{set,zero}	2023-06-19 13:59:22 +02:00
ordered-data.c	btrfs: check for BTRFS_FS_ERROR in pending ordered assert	2023-09-08 14:10:59 +02:00
ordered-data.h	btrfs: add a btrfs_finish_ordered_extent helper	2023-06-19 13:59:37 +02:00
orphan.c
orphan.h
print-tree.c	btrfs: remove v0 extent handling	2023-08-21 14:54:48 +02:00
print-tree.h	btrfs: print-tree: pass const extent buffer pointer	2023-06-19 13:59:22 +02:00
props.c
props.h
qgroup.c	btrfs: avoid start and commit empty transaction when flushing qgroups	2023-08-21 14:52:18 +02:00
qgroup.h
raid56.c	btrfs: scrub: avoid unnecessary csum tree search preparing stripes	2023-08-21 14:54:48 +02:00
raid56.h	btrfs: raid56: remove unused BTRFS_RBIO_REBUILD_MISSING	2023-08-21 14:52:12 +02:00
rcu-string.h
ref-verify.c
ref-verify.h
reflink.c
reflink.h
relocation.c	btrfs: remove v0 extent handling	2023-08-21 14:54:48 +02:00
relocation.h	btrfs: pass an ordered_extent to btrfs_reloc_clone_csums	2023-06-19 13:59:36 +02:00
root-tree.c
root-tree.h
scrub.c	btrfs: scrub: move write back of repaired sectors to scrub_stripe_read_repair_worker()	2023-08-21 14:54:49 +02:00
scrub.h	btrfs: scrub: remove scrub_bio structure	2023-04-17 18:01:24 +02:00
send.c	btrfs: use LIST_HEAD() to initialize the list_head	2023-08-21 14:54:46 +02:00
send.h
space-info.c	btrfs: zoned: re-enable metadata over-commit for zoned mode	2023-08-21 14:52:19 +02:00
space-info.h	btrfs: update documentation for BTRFS_RESERVE_FLUSH_EVICT flush method	2023-04-17 18:01:18 +02:00
subpage.c	btrfs: stop setting PageError in the data I/O path	2023-06-19 13:59:35 +02:00
subpage.h	btrfs: stop setting PageError in the data I/O path	2023-06-19 13:59:35 +02:00
super.c	btrfs: deprecate integrity checker feature	2023-08-21 14:52:13 +02:00
super.h
sysfs.c	btrfs: sysfs: show if ACL support has been compiled in	2023-08-21 14:52:12 +02:00
sysfs.h
transaction.c	btrfs: do not block starts waiting on previous transaction commit	2023-09-08 14:10:49 +02:00
transaction.h	btrfs: do not block starts waiting on previous transaction commit	2023-09-08 14:10:49 +02:00
tree-checker.c	for-6.5-rc5-tag	2023-08-12 13:28:55 -07:00
tree-checker.h	btrfs: move btrfs_verify_level_key into tree-checker.c	2023-06-19 13:59:25 +02:00
tree-log.c	btrfs: use LIST_HEAD() to initialize the list_head	2023-08-21 14:54:46 +02:00
tree-log.h	btrfs: change for_rename argument of btrfs_record_unlink_dir() to bool	2023-06-19 13:59:26 +02:00
tree-mod-log.c	btrfs: avoid tree mod log ENOMEM failures when we don't need to log	2023-06-19 13:59:38 +02:00
tree-mod-log.h
ulist.c
ulist.h
uuid-tree.c
uuid-tree.h
verity.c
verity.h
volumes.c	btrfs: simplify memcpy either of metadata_uuid or fsid	2023-08-21 14:54:48 +02:00
volumes.h	btrfs: add a helper to read the superblock metadata_uuid	2023-08-21 14:54:48 +02:00
xattr.c	fs: drop unused posix acl handlers	2023-03-06 09:57:12 +01:00
xattr.h
zlib.c	btrfs: disable allocation warnings for compression workspaces	2023-06-19 13:59:34 +02:00
zoned.c	btrfs: zoned: skip splitting and logical rewriting on pre-alloc write	2023-08-22 14:19:59 +02:00
zoned.h	btrfs: zoned: reserve zones for an active metadata/system block group	2023-08-21 14:52:19 +02:00
zstd.c	btrfs: disable allocation warnings for compression workspaces	2023-06-19 13:59:34 +02:00