mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-04 16:25:34 +00:00
![]() The current-source used for the battery temp-sensor (TS) is shared with the
GPADC. For proper fuel-gauge and charger operation the TS current-source
needs to be permanently on. But to read the GPADC we need to temporary
switch the TS current-source to ondemand, so that the GPADC can use it,
otherwise we will always read an all 0 value.
The switching from on to on-ondemand is not necessary when the TS
current-source is off (this happens on devices which do not have a TS).
Prior to this commit there were 2 issues with our handling of the TS
current-source switching:
1) We were writing hardcoded values to the ADC TS pin-ctrl register,
overwriting various other unrelated bits. Specifically we were overwriting
the current-source setting for the TS and GPIO0 pins, forcing it to 80ųA
independent of its original setting. On a Chuwi Vi10 tablet this was
causing us to get a too high adc value (due to a too high current-source)
resulting in acpi_lpat_raw_to_temp() returning -ENOENT, resulting in:
ACPI Error: AE_ERROR, Returned by Handler for [UserDefinedRegion]
ACPI Error: Method parse/execution failed \_SB.SXP1._TMP, AE_ERROR
This commit fixes this by using regmap_update_bits to change only the
relevant bits.
2) At the end of intel_xpower_pmic_get_raw_temp() we were unconditionally
enabling the TS current-source even on devices where the TS-pin is not used
and the current-source thus was off on entry of the function.
This commit fixes this by checking if the TS current-source is off when
entering intel_xpower_pmic_get_raw_temp() and if so it is left as is.
Fixes:
|
||
---|---|---|
.. | ||
acpica | ||
apei | ||
arm64 | ||
dptf | ||
nfit | ||
pmic | ||
x86 | ||
ac.c | ||
acpi_adxl.c | ||
acpi_amba.c | ||
acpi_apd.c | ||
acpi_cmos_rtc.c | ||
acpi_configfs.c | ||
acpi_dbg.c | ||
acpi_extlog.c | ||
acpi_ipmi.c | ||
acpi_lpat.c | ||
acpi_lpit.c | ||
acpi_lpss.c | ||
acpi_memhotplug.c | ||
acpi_pad.c | ||
acpi_platform.c | ||
acpi_pnp.c | ||
acpi_processor.c | ||
acpi_tad.c | ||
acpi_video.c | ||
acpi_watchdog.c | ||
battery.c | ||
bgrt.c | ||
blacklist.c | ||
bus.c | ||
button.c | ||
cm_sbs.c | ||
container.c | ||
cppc_acpi.c | ||
custom_method.c | ||
debugfs.c | ||
device_pm.c | ||
device_sysfs.c | ||
dock.c | ||
ec.c | ||
ec_sys.c | ||
event.c | ||
evged.c | ||
fan.c | ||
glue.c | ||
hed.c | ||
internal.h | ||
ioapic.c | ||
irq.c | ||
Kconfig | ||
Makefile | ||
numa.c | ||
nvs.c | ||
osi.c | ||
osl.c | ||
pci_irq.c | ||
pci_link.c | ||
pci_mcfg.c | ||
pci_root.c | ||
pci_slot.c | ||
power.c | ||
pptt.c | ||
proc.c | ||
processor_core.c | ||
processor_driver.c | ||
processor_idle.c | ||
processor_pdc.c | ||
processor_perflib.c | ||
processor_thermal.c | ||
processor_throttling.c | ||
property.c | ||
reboot.c | ||
resource.c | ||
sbs.c | ||
sbshc.c | ||
sbshc.h | ||
scan.c | ||
sleep.c | ||
sleep.h | ||
spcr.c | ||
sysfs.c | ||
tables.c | ||
thermal.c | ||
utils.c | ||
video_detect.c | ||
wakeup.c |