mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-04 08:17:46 +00:00
2564fe708b
Asking the GPU to busywait on a memory address, perhaps not unexpectedly
in hindsight for a shared system, leads to bus contention that affects
CPU programs trying to concurrently access memory. This can manifest as
a drop in transcode throughput on highly over-saturated workloads.
The only clue offered by perf, is that the bus-cycles (perf stat -e
bus-cycles) jumped by 50% when enabling semaphores. This corresponds
with extra CPU active cycles being attributed to intel_idle's mwait.
This patch introduces a heuristic to try and detect when more than one
client is submitting to the GPU pushing it into an oversaturated state.
As we already keep track of when the semaphores are signaled, we can
inspect their state on submitting the busywait batch and if we planned
to use a semaphore but were too late, conclude that the GPU is
overloaded and not try to use semaphores in future requests. In
practice, this means we optimistically try to use semaphores for the
first frame of a transcode job split over multiple engines, and fail if
there are multiple clients active and continue not to use semaphores for
the subsequent frames in the sequence. Periodically, we try to
optimistically switch semaphores back on whenever the client waits to
catch up with the transcode results.
With 1 client, on Broxton J3455, with the relative fps normalized by %cpu:
x no semaphores
+ drm-tip
* patched
+------------------------------------------------------------------------+
| * |
| *+ |
| **+ |
| **+ x |
| x * +**+ x |
| x x * * +***x xx |
| x x * * *+***x *x |
| x x* + * * *****x *x x |
| + x xx+x* + *** * ********* x * |
| + x xx+x* * *** +** ********* xx * |
| * + ++++* + x*x****+*+* ***+*************+x* * |
|*+ +** *+ + +* + *++****** *xxx**********x***+*****************+*++ *|
| |__________A_____M_____| |
| |_______________A____M_________| |
| |____________A___M________| |
+------------------------------------------------------------------------+
N Min Max Median Avg Stddev
x 120 2.60475 3.50941 3.31123 3.2143953 0.21117399
+ 120 2.3826 3.57077 3.25101 3.1414161 0.28146407
Difference at 95.0% confidence
-0.0729792 +/- 0.0629585
-2.27039% +/- 1.95864%
(Student's t, pooled s = 0.248814)
* 120 2.35536 3.66713 3.2849 3.2059917 0.24618565
No difference proven at 95.0% confidence
With 10 clients over-saturating the pipeline:
x no semaphores
+ drm-tip
* patched
+------------------------------------------------------------------------+
| ++ ** |
| ++ ** |
| ++ ** |
| ++ ** |
| ++ xx *** |
| ++ xx *** |
| ++ xxx*** |
| ++ xxx*** |
| +++ xxx*** |
| +++ xx**** |
| +++ xx**** |
| +++ xx**** |
| +++ xx**** |
| ++++ xx**** |
| +++++ xx**** |
| +++++ x x****** |
| ++++++ xxx******* |
| ++++++ xxx******* |
| ++++++ xxx******* |
| ++++++ xx******** |
| ++++++ xxxx******** |
| ++++++ xxxx******** |
| ++++++++ xxxxx********* |
|+ + + + ++++++++ xxx*xx**********x* *|
| |__A__| |
| |__AM__| |
| |__A_| |
+------------------------------------------------------------------------+
N Min Max Median Avg Stddev
x 120 2.47855 2.8972 2.72376 2.7193402 0.074604933
+ 120 1.17367 1.77459 1.71977 1.6966782 0.085850697
Difference at 95.0% confidence
-1.02266 +/- 0.0203502
-37.607% +/- 0.748352%
(Student's t, pooled s = 0.0804246)
* 120 2.57868 3.00821 2.80142 2.7923878 0.058646477
Difference at 95.0% confidence
0.0730476 +/- 0.0169791
2.68622% +/- 0.624383%
(Student's t, pooled s = 0.0671018)
Indicating that we've recovered the regression from enabling semaphores
on this saturated setup, with a hint towards an overall improvement.
Very similar, but of smaller magnitude, results are observed on both
Skylake(gt2) and Kabylake(gt4). This may be due to the reduced impact of
bus-cycles, where we see a 50% hit on Broxton, it is only 10% on the big
core, in this particular test.
One observation to make here is that for a greedy client trying to
maximise its own throughput, using semaphores is the right choice. It is
only the holistic system-wide view that semaphores of one client
impacts another and reduces the overall throughput where we would choose
to disable semaphores.
The most noticeable negactive impact this has is on the no-op
microbenchmarks, which are also very notable for having no cpu bus load.
In particular, this increases the runtime and energy consumption of
gem_exec_whisper.
Fixes:
|
||
|---|---|---|
| .. | ||
| gvt | ||
| selftests | ||
| .gitignore | ||
| dvo.h | ||
| dvo_ch7xxx.c | ||
| dvo_ch7017.c | ||
| dvo_ivch.c | ||
| dvo_ns2501.c | ||
| dvo_sil164.c | ||
| dvo_tfp410.c | ||
| i915_active.c | ||
| i915_active.h | ||
| i915_active_types.h | ||
| i915_cmd_parser.c | ||
| i915_debugfs.c | ||
| i915_drv.c | ||
| i915_drv.h | ||
| i915_fixed.h | ||
| i915_gem.c | ||
| i915_gem.h | ||
| i915_gem_batch_pool.c | ||
| i915_gem_batch_pool.h | ||
| i915_gem_clflush.c | ||
| i915_gem_clflush.h | ||
| i915_gem_context.c | ||
| i915_gem_context.h | ||
| i915_gem_context_types.h | ||
| i915_gem_dmabuf.c | ||
| i915_gem_evict.c | ||
| i915_gem_execbuffer.c | ||
| i915_gem_fence_reg.c | ||
| i915_gem_fence_reg.h | ||
| i915_gem_gtt.c | ||
| i915_gem_gtt.h | ||
| i915_gem_internal.c | ||
| i915_gem_object.c | ||
| i915_gem_object.h | ||
| i915_gem_render_state.c | ||
| i915_gem_render_state.h | ||
| i915_gem_shrinker.c | ||
| i915_gem_stolen.c | ||
| i915_gem_tiling.c | ||
| i915_gem_userptr.c | ||
| i915_gemfs.c | ||
| i915_gemfs.h | ||
| i915_globals.c | ||
| i915_globals.h | ||
| i915_gpu_error.c | ||
| i915_gpu_error.h | ||
| i915_ioc32.c | ||
| i915_irq.c | ||
| i915_memcpy.c | ||
| i915_mm.c | ||
| i915_oa_bdw.c | ||
| i915_oa_bdw.h | ||
| i915_oa_bxt.c | ||
| i915_oa_bxt.h | ||
| i915_oa_cflgt2.c | ||
| i915_oa_cflgt2.h | ||
| i915_oa_cflgt3.c | ||
| i915_oa_cflgt3.h | ||
| i915_oa_chv.c | ||
| i915_oa_chv.h | ||
| i915_oa_cnl.c | ||
| i915_oa_cnl.h | ||
| i915_oa_glk.c | ||
| i915_oa_glk.h | ||
| i915_oa_hsw.c | ||
| i915_oa_hsw.h | ||
| i915_oa_icl.c | ||
| i915_oa_icl.h | ||
| i915_oa_kblgt2.c | ||
| i915_oa_kblgt2.h | ||
| i915_oa_kblgt3.c | ||
| i915_oa_kblgt3.h | ||
| i915_oa_sklgt2.c | ||
| i915_oa_sklgt2.h | ||
| i915_oa_sklgt3.c | ||
| i915_oa_sklgt3.h | ||
| i915_oa_sklgt4.c | ||
| i915_oa_sklgt4.h | ||
| i915_params.c | ||
| i915_params.h | ||
| i915_pci.c | ||
| i915_perf.c | ||
| i915_pmu.c | ||
| i915_pmu.h | ||
| i915_priolist_types.h | ||
| i915_pvinfo.h | ||
| i915_query.c | ||
| i915_query.h | ||
| i915_reg.h | ||
| i915_request.c | ||
| i915_request.h | ||
| i915_reset.c | ||
| i915_reset.h | ||
| i915_scheduler.c | ||
| i915_scheduler.h | ||
| i915_scheduler_types.h | ||
| i915_selftest.h | ||
| i915_suspend.c | ||
| i915_sw_fence.c | ||
| i915_sw_fence.h | ||
| i915_syncmap.c | ||
| i915_syncmap.h | ||
| i915_sysfs.c | ||
| i915_timeline.c | ||
| i915_timeline.h | ||
| i915_timeline_types.h | ||
| i915_trace.h | ||
| i915_trace_points.c | ||
| i915_user_extensions.c | ||
| i915_user_extensions.h | ||
| i915_utils.h | ||
| i915_vgpu.c | ||
| i915_vgpu.h | ||
| i915_vma.c | ||
| i915_vma.h | ||
| icl_dsi.c | ||
| intel_acpi.c | ||
| intel_atomic.c | ||
| intel_atomic_plane.c | ||
| intel_atomic_plane.h | ||
| intel_audio.c | ||
| intel_audio.h | ||
| intel_bios.c | ||
| intel_bios.h | ||
| intel_breadcrumbs.c | ||
| intel_cdclk.c | ||
| intel_cdclk.h | ||
| intel_color.c | ||
| intel_color.h | ||
| intel_combo_phy.c | ||
| intel_connector.c | ||
| intel_connector.h | ||
| intel_context.c | ||
| intel_context.h | ||
| intel_context_types.h | ||
| intel_crt.c | ||
| intel_crt.h | ||
| intel_csr.c | ||
| intel_csr.h | ||
| intel_ddi.c | ||
| intel_ddi.h | ||
| intel_device_info.c | ||
| intel_device_info.h | ||
| intel_display.c | ||
| intel_display.h | ||
| intel_dp.c | ||
| intel_dp.h | ||
| intel_dp_aux_backlight.c | ||
| intel_dp_link_training.c | ||
| intel_dp_mst.c | ||
| intel_dpio_phy.c | ||
| intel_dpll_mgr.c | ||
| intel_dpll_mgr.h | ||
| intel_drv.h | ||
| intel_dsi.c | ||
| intel_dsi.h | ||
| intel_dsi_dcs_backlight.c | ||
| intel_dsi_vbt.c | ||
| intel_dvo.c | ||
| intel_dvo.h | ||
| intel_engine_cs.c | ||
| intel_engine_types.h | ||
| intel_fbc.c | ||
| intel_fbc.h | ||
| intel_fbdev.c | ||
| intel_fbdev.h | ||
| intel_fifo_underrun.c | ||
| intel_frontbuffer.c | ||
| intel_frontbuffer.h | ||
| intel_gpu_commands.h | ||
| intel_guc.c | ||
| intel_guc.h | ||
| intel_guc_ads.c | ||
| intel_guc_ads.h | ||
| intel_guc_ct.c | ||
| intel_guc_ct.h | ||
| intel_guc_fw.c | ||
| intel_guc_fw.h | ||
| intel_guc_fwif.h | ||
| intel_guc_log.c | ||
| intel_guc_log.h | ||
| intel_guc_reg.h | ||
| intel_guc_submission.c | ||
| intel_guc_submission.h | ||
| intel_gvt.c | ||
| intel_gvt.h | ||
| intel_hangcheck.c | ||
| intel_hdcp.c | ||
| intel_hdcp.h | ||
| intel_hdmi.c | ||
| intel_hdmi.h | ||
| intel_hotplug.c | ||
| intel_huc.c | ||
| intel_huc.h | ||
| intel_huc_fw.c | ||
| intel_huc_fw.h | ||
| intel_i2c.c | ||
| intel_lpe_audio.c | ||
| intel_lrc.c | ||
| intel_lrc.h | ||
| intel_lrc_reg.h | ||
| intel_lspcon.c | ||
| intel_lspcon.h | ||
| intel_lvds.c | ||
| intel_lvds.h | ||
| intel_mocs.c | ||
| intel_mocs.h | ||
| intel_opregion.c | ||
| intel_opregion.h | ||
| intel_overlay.c | ||
| intel_panel.c | ||
| intel_panel.h | ||
| intel_pipe_crc.c | ||
| intel_pipe_crc.h | ||
| intel_pm.c | ||
| intel_pm.h | ||
| intel_psr.c | ||
| intel_psr.h | ||
| intel_quirks.c | ||
| intel_renderstate.h | ||
| intel_renderstate_gen6.c | ||
| intel_renderstate_gen7.c | ||
| intel_renderstate_gen8.c | ||
| intel_renderstate_gen9.c | ||
| intel_ringbuffer.c | ||
| intel_ringbuffer.h | ||
| intel_runtime_pm.c | ||
| intel_sdvo.c | ||
| intel_sdvo.h | ||
| intel_sdvo_regs.h | ||
| intel_sideband.c | ||
| intel_sprite.c | ||
| intel_sprite.h | ||
| intel_tv.c | ||
| intel_tv.h | ||
| intel_uc.c | ||
| intel_uc.h | ||
| intel_uc_fw.c | ||
| intel_uc_fw.h | ||
| intel_uncore.c | ||
| intel_uncore.h | ||
| intel_vbt_defs.h | ||
| intel_vdsc.c | ||
| intel_wopcm.c | ||
| intel_wopcm.h | ||
| intel_workarounds.c | ||
| intel_workarounds.h | ||
| intel_workarounds_types.h | ||
| Kconfig | ||
| Kconfig.debug | ||
| Makefile | ||
| Makefile.header-test | ||
| vlv_dsi.c | ||
| vlv_dsi_pll.c | ||