mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
![]() Refactor ice driver to use FIELD_PREP(), which reduces lines of code and adds clarity of intent. This code was generated by the following coccinelle/spatch script and then manually repaired. Several places I changed to OR into a single variable with |= instead of using a multi-line statement with trailing OR operators, as it (subjectively) makes the code clearer. A local variable vmvf_and_timeout was created and used to avoid multiple logical ORs being __le16 converted, which shortened some lines and makes the code cleaner. Also clean up a couple of places where conversions were made to have the code read more clearly/consistently. @prep2@ constant shift,mask; type T; expression a; @@ -(((T)(a) << shift) & mask) +FIELD_PREP(mask, a) @prep@ constant shift,mask; type T; expression a; @@ -((T)((a) << shift) & mask) +FIELD_PREP(mask, a) Cc: Julia Lawall <Julia.Lawall@inria.fr> CC: Alexander Lobakin <aleksander.lobakin@intel.com> Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com> Reviewed-by: Simon Horman <horms@kernel.org> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> |
||
---|---|---|
.. | ||
ice.h | ||
ice_adminq_cmd.h | ||
ice_arfs.c | ||
ice_arfs.h | ||
ice_base.c | ||
ice_base.h | ||
ice_cgu_regs.h | ||
ice_common.c | ||
ice_common.h | ||
ice_controlq.c | ||
ice_controlq.h | ||
ice_dcb.c | ||
ice_dcb.h | ||
ice_dcb_lib.c | ||
ice_dcb_lib.h | ||
ice_dcb_nl.c | ||
ice_dcb_nl.h | ||
ice_ddp.c | ||
ice_ddp.h | ||
ice_debugfs.c | ||
ice_devids.h | ||
ice_devlink.c | ||
ice_devlink.h | ||
ice_dpll.c | ||
ice_dpll.h | ||
ice_eswitch.c | ||
ice_eswitch.h | ||
ice_eswitch_br.c | ||
ice_eswitch_br.h | ||
ice_ethtool.c | ||
ice_ethtool.h | ||
ice_ethtool_fdir.c | ||
ice_fdir.c | ||
ice_fdir.h | ||
ice_flex_pipe.c | ||
ice_flex_pipe.h | ||
ice_flex_type.h | ||
ice_flow.c | ||
ice_flow.h | ||
ice_fltr.c | ||
ice_fltr.h | ||
ice_fw_update.c | ||
ice_fw_update.h | ||
ice_fwlog.c | ||
ice_fwlog.h | ||
ice_gnss.c | ||
ice_gnss.h | ||
ice_hw_autogen.h | ||
ice_hwmon.c | ||
ice_hwmon.h | ||
ice_idc.c | ||
ice_idc_int.h | ||
ice_irq.c | ||
ice_irq.h | ||
ice_lag.c | ||
ice_lag.h | ||
ice_lan_tx_rx.h | ||
ice_lib.c | ||
ice_lib.h | ||
ice_main.c | ||
ice_nvm.c | ||
ice_nvm.h | ||
ice_osdep.h | ||
ice_pf_vsi_vlan_ops.c | ||
ice_pf_vsi_vlan_ops.h | ||
ice_protocol_type.h | ||
ice_ptp.c | ||
ice_ptp.h | ||
ice_ptp_consts.h | ||
ice_ptp_hw.c | ||
ice_ptp_hw.h | ||
ice_repr.c | ||
ice_repr.h | ||
ice_sbq_cmd.h | ||
ice_sched.c | ||
ice_sched.h | ||
ice_sriov.c | ||
ice_sriov.h | ||
ice_switch.c | ||
ice_switch.h | ||
ice_tc_lib.c | ||
ice_tc_lib.h | ||
ice_trace.h | ||
ice_txrx.c | ||
ice_txrx.h | ||
ice_txrx_lib.c | ||
ice_txrx_lib.h | ||
ice_type.h | ||
ice_vf_lib.c | ||
ice_vf_lib.h | ||
ice_vf_lib_private.h | ||
ice_vf_mbx.c | ||
ice_vf_mbx.h | ||
ice_vf_vsi_vlan_ops.c | ||
ice_vf_vsi_vlan_ops.h | ||
ice_virtchnl.c | ||
ice_virtchnl.h | ||
ice_virtchnl_allowlist.c | ||
ice_virtchnl_allowlist.h | ||
ice_virtchnl_fdir.c | ||
ice_virtchnl_fdir.h | ||
ice_vlan.h | ||
ice_vlan_mode.c | ||
ice_vlan_mode.h | ||
ice_vsi_vlan_lib.c | ||
ice_vsi_vlan_lib.h | ||
ice_vsi_vlan_ops.c | ||
ice_vsi_vlan_ops.h | ||
ice_xsk.c | ||
ice_xsk.h | ||
Makefile |