Nikolay Aleksandrov 9d332e69c1 net: bridge: fix vlan stats use-after-free on destruction ... Syzbot reported a use-after-free of the global vlan context on port vlan destruction. When I added per-port vlan stats I missed the fact that the global vlan context can be freed before the per-port vlan rcu callback. There're a few different ways to deal with this, I've chosen to add a new private flag that is set only when per-port stats are allocated so we can directly check it on destruction without dereferencing the global context at all. The new field in net_bridge_vlan uses a hole. v2: cosmetic change, move the check to br_process_vlan_info where the other checks are done v3: add change log in the patch, add private (in-kernel only) flags in a hole in net_bridge_vlan struct and use that instead of mixing user-space flags with private flags Fixes: 9163a0fc1f ("net: bridge: add support for per-port vlan stats") Reported-by: syzbot+04681da557a0e49a52e5@syzkaller.appspotmail.com Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2018-11-17 21:38:44 -08:00
..
netfilter
br.c	bridge: switchdev: Allow clearing FDB entry offload indication	2018-10-17 17:45:08 -07:00
br_arp_nd_proxy.c
br_device.c	netpoll: allow cleanup to be synchronous	2018-10-19 17:01:43 -07:00
br_fdb.c	bridge: switchdev: Allow clearing FDB entry offload indication	2018-10-17 17:45:08 -07:00
br_forward.c
br_if.c
br_input.c
br_ioctl.c
br_mdb.c	net/bridge: Update br_mdb_dump for strict data checking	2018-10-08 10:39:05 -07:00
br_multicast.c	net: bridge: remove ipv6 zero address check in mcast queries	2018-10-28 19:18:09 -07:00
br_netfilter_hooks.c
br_netfilter_ipv6.c
br_netlink.c	net: bridge: add support for per-port vlan stats	2018-10-12 10:18:58 -07:00
br_netlink_tunnel.c
br_nf_core.c
br_private.h	net: bridge: fix vlan stats use-after-free on destruction	2018-11-17 21:38:44 -08:00
br_private_stp.h
br_private_tunnel.h
br_stp.c
br_stp_bpdu.c
br_stp_if.c
br_stp_timer.c
br_switchdev.c	bridge: switchdev: Allow clearing FDB entry offload indication	2018-10-17 17:45:08 -07:00
br_sysfs_br.c	net: bridge: add support for per-port vlan stats	2018-10-12 10:18:58 -07:00
br_sysfs_if.c
br_vlan.c	net: bridge: fix vlan stats use-after-free on destruction	2018-11-17 21:38:44 -08:00
br_vlan_tunnel.c
Kconfig
Makefile