linux/drivers/net/ethernet/microsoft/mana
Len Baker f11ee2ad25 net: mana: Prefer struct_size over open coded arithmetic
As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the struct_size() helper to do the arithmetic instead of the
argument "size + count * size" in the kzalloc() function.

[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Signed-off-by: Len Baker <len.baker@gmx.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2021-09-12 10:49:21 +01:00
..
gdma.h net: mana: Add support for EQ sharing 2021-08-25 11:06:54 +01:00
gdma_main.c net: mana: Add WARN_ON_ONCE in case of CQE read overflow 2021-08-25 11:06:54 +01:00
hw_channel.c net: mana: Prefer struct_size over open coded arithmetic 2021-09-12 10:49:21 +01:00
hw_channel.h
Makefile
mana.h net: mana: Add support for EQ sharing 2021-08-25 11:06:54 +01:00
mana_en.c net: mana: Add support for EQ sharing 2021-08-25 11:06:54 +01:00
mana_ethtool.c
shm_channel.c
shm_channel.h