mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 08:43:31 +00:00

We need shared data for actions (e.g. guc suspend/resume), and we're
using those with GuC submission disabled.
Let's introduce intel_guc_init and move shared data alloc there.
This fixes GPF during module unload with HuC, but without GuC submission:
BUG: unable to handle kernel NULL pointer dereference at 000000005aee7809
IP: intel_guc_suspend+0x34/0x140 [i915]
PGD 0 P4D 0
Oops: 0000 [#1] PREEMPT SMP
Modules linked in: i915(O-) netconsole x86_pkg_temp_thermal
intel_powerclamp coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel
mei_me i2c_i801 mei prime_numbers [last unloaded: i915]
CPU: 2 PID: 2794 Comm: rmmod Tainted: G U W O 4.15.0-rc2+ #297
Hardware name: /NUC6i5SYB, BIOS SYSKLi35.86A.0054.2016.0930.1102 09/30/2016
task: 0000000055945c61 task.stack: 00000000264ccb43
RIP: 0010:intel_guc_suspend+0x34/0x140 [i915]
RSP: 0018:ffffc90000483df8 EFLAGS: 00010286
RAX: 0000000000000000 RBX: ffff880829180000 RCX: 0000000000000000
RDX: 0000000000000006 RSI: ffff880844c2c938 RDI: ffff880844c2c000
RBP: ffff880829180000 R08: 00000000a29c58c1 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: ffffffffa040ba40
R13: ffffffffa040bab0 R14: ffff88084a195060 R15: 000055df3ef357a0
FS: 00007ff43c043740(0000) GS:ffff88084e200000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00000000000000f9 CR3: 000000083f179005 CR4: 00000000003606e0
Call Trace:
i915_gem_suspend+0x9d/0x130 [i915]
? i915_driver_unload+0x68/0x180 [i915]
i915_driver_unload+0x70/0x180 [i915]
i915_pci_remove+0x15/0x20 [i915]
pci_device_remove+0x36/0xb0
device_release_driver_internal+0x15f/0x220
driver_detach+0x3a/0x80
bus_remove_driver+0x58/0xd0
pci_unregister_driver+0x29/0x90
SyS_delete_module+0x150/0x1e0
entry_SYSCALL_64_fastpath+0x23/0x9a
RIP: 0033:0x7ff43b51b5c7
RSP: 002b:00007ffe6825a758 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007ff43b51b5c7
RDX: 000000000000000a RSI: 0000000000000800 RDI: 000055df3ef35808
RBP: 0000000000000000 R08: 00007ffe682596d1 R09: 0000000000000000
R10: 00007ff43b594880 R11: 0000000000000206 R12: 000055df3ef357a0
R13: 00007ffe68259740 R14: 000055df3ef35260 R15: 000055df3ef357a0
Code: 00 00 02 74 03 31 c0 c3 53 48 89 fb 48 83 ec 10 e8 52 0f
f8 ff 48 b8 01 05 00 00 02 00 00 00 48 89 44 24 04 48 8b 83 00 12 00 00 <f6> 80
f9 00 00 00 01 0f 84 a7 00 00 00 f6 80 98 00 00 00 01 0f
RIP: intel_guc_suspend+0x34/0x140 [i915] RSP: ffffc90000483df8
CR2: 00000000000000f9
---[ end trace 23a192a61d937a3e ]---
Fixes: b8e5eb960b
("drm/i915/guc: Allocate separate shared data object for GuC communication")
Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20171213221352.7173-1-michal.winiarski@intel.com
336 lines
8.5 KiB
C
336 lines
8.5 KiB
C
/*
|
|
* Copyright © 2016 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*
|
|
*/
|
|
|
|
#include "intel_uc.h"
|
|
#include "intel_guc_submission.h"
|
|
#include "intel_guc.h"
|
|
#include "i915_drv.h"
|
|
|
|
/* Reset GuC providing us with fresh state for both GuC and HuC.
|
|
*/
|
|
static int __intel_uc_reset_hw(struct drm_i915_private *dev_priv)
|
|
{
|
|
int ret;
|
|
u32 guc_status;
|
|
|
|
ret = intel_reset_guc(dev_priv);
|
|
if (ret) {
|
|
DRM_ERROR("Failed to reset GuC, ret = %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
guc_status = I915_READ(GUC_STATUS);
|
|
WARN(!(guc_status & GS_MIA_IN_RESET),
|
|
"GuC status: 0x%x, MIA core expected to be in reset\n",
|
|
guc_status);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int __get_platform_enable_guc(struct drm_i915_private *dev_priv)
|
|
{
|
|
struct intel_uc_fw *guc_fw = &dev_priv->guc.fw;
|
|
struct intel_uc_fw *huc_fw = &dev_priv->huc.fw;
|
|
int enable_guc = 0;
|
|
|
|
/* Default is to enable GuC/HuC if we know their firmwares */
|
|
if (intel_uc_fw_is_selected(guc_fw))
|
|
enable_guc |= ENABLE_GUC_SUBMISSION;
|
|
if (intel_uc_fw_is_selected(huc_fw))
|
|
enable_guc |= ENABLE_GUC_LOAD_HUC;
|
|
|
|
/* Any platform specific fine-tuning can be done here */
|
|
|
|
return enable_guc;
|
|
}
|
|
|
|
/**
|
|
* intel_uc_sanitize_options - sanitize uC related modparam options
|
|
* @dev_priv: device private
|
|
*
|
|
* In case of "enable_guc" option this function will attempt to modify
|
|
* it only if it was initially set to "auto(-1)". Default value for this
|
|
* modparam varies between platforms and it is hardcoded in driver code.
|
|
* Any other modparam value is only monitored against availability of the
|
|
* related hardware or firmware definitions.
|
|
*/
|
|
void intel_uc_sanitize_options(struct drm_i915_private *dev_priv)
|
|
{
|
|
struct intel_uc_fw *guc_fw = &dev_priv->guc.fw;
|
|
struct intel_uc_fw *huc_fw = &dev_priv->huc.fw;
|
|
|
|
/* A negative value means "use platform default" */
|
|
if (i915_modparams.enable_guc < 0)
|
|
i915_modparams.enable_guc = __get_platform_enable_guc(dev_priv);
|
|
|
|
DRM_DEBUG_DRIVER("enable_guc=%d (submission:%s huc:%s)\n",
|
|
i915_modparams.enable_guc,
|
|
yesno(intel_uc_is_using_guc_submission()),
|
|
yesno(intel_uc_is_using_huc()));
|
|
|
|
/* Verify GuC firmware availability */
|
|
if (intel_uc_is_using_guc() && !intel_uc_fw_is_selected(guc_fw)) {
|
|
DRM_WARN("Incompatible option detected: enable_guc=%d, %s!\n",
|
|
i915_modparams.enable_guc,
|
|
!HAS_GUC(dev_priv) ? "no GuC hardware" :
|
|
"no GuC firmware");
|
|
}
|
|
|
|
/* Verify HuC firmware availability */
|
|
if (intel_uc_is_using_huc() && !intel_uc_fw_is_selected(huc_fw)) {
|
|
DRM_WARN("Incompatible option detected: enable_guc=%d, %s!\n",
|
|
i915_modparams.enable_guc,
|
|
!HAS_HUC(dev_priv) ? "no HuC hardware" :
|
|
"no HuC firmware");
|
|
}
|
|
|
|
/* Make sure that sanitization was done */
|
|
GEM_BUG_ON(i915_modparams.enable_guc < 0);
|
|
}
|
|
|
|
void intel_uc_init_early(struct drm_i915_private *dev_priv)
|
|
{
|
|
intel_guc_init_early(&dev_priv->guc);
|
|
intel_huc_init_early(&dev_priv->huc);
|
|
}
|
|
|
|
void intel_uc_init_fw(struct drm_i915_private *dev_priv)
|
|
{
|
|
if (!USES_GUC(dev_priv))
|
|
return;
|
|
|
|
if (USES_HUC(dev_priv))
|
|
intel_uc_fw_fetch(dev_priv, &dev_priv->huc.fw);
|
|
|
|
intel_uc_fw_fetch(dev_priv, &dev_priv->guc.fw);
|
|
}
|
|
|
|
void intel_uc_fini_fw(struct drm_i915_private *dev_priv)
|
|
{
|
|
if (!USES_GUC(dev_priv))
|
|
return;
|
|
|
|
intel_uc_fw_fini(&dev_priv->guc.fw);
|
|
|
|
if (USES_HUC(dev_priv))
|
|
intel_uc_fw_fini(&dev_priv->huc.fw);
|
|
}
|
|
|
|
/**
|
|
* intel_uc_init_mmio - setup uC MMIO access
|
|
*
|
|
* @dev_priv: device private
|
|
*
|
|
* Setup minimal state necessary for MMIO accesses later in the
|
|
* initialization sequence.
|
|
*/
|
|
void intel_uc_init_mmio(struct drm_i915_private *dev_priv)
|
|
{
|
|
intel_guc_init_send_regs(&dev_priv->guc);
|
|
}
|
|
|
|
static void guc_capture_load_err_log(struct intel_guc *guc)
|
|
{
|
|
if (!guc->log.vma || i915_modparams.guc_log_level < 0)
|
|
return;
|
|
|
|
if (!guc->load_err_log)
|
|
guc->load_err_log = i915_gem_object_get(guc->log.vma->obj);
|
|
|
|
return;
|
|
}
|
|
|
|
static void guc_free_load_err_log(struct intel_guc *guc)
|
|
{
|
|
if (guc->load_err_log)
|
|
i915_gem_object_put(guc->load_err_log);
|
|
}
|
|
|
|
static int guc_enable_communication(struct intel_guc *guc)
|
|
{
|
|
struct drm_i915_private *dev_priv = guc_to_i915(guc);
|
|
|
|
if (HAS_GUC_CT(dev_priv))
|
|
return intel_guc_enable_ct(guc);
|
|
|
|
guc->send = intel_guc_send_mmio;
|
|
return 0;
|
|
}
|
|
|
|
static void guc_disable_communication(struct intel_guc *guc)
|
|
{
|
|
struct drm_i915_private *dev_priv = guc_to_i915(guc);
|
|
|
|
if (HAS_GUC_CT(dev_priv))
|
|
intel_guc_disable_ct(guc);
|
|
|
|
guc->send = intel_guc_send_nop;
|
|
}
|
|
|
|
int intel_uc_init_hw(struct drm_i915_private *dev_priv)
|
|
{
|
|
struct intel_guc *guc = &dev_priv->guc;
|
|
struct intel_huc *huc = &dev_priv->huc;
|
|
int ret, attempts;
|
|
|
|
if (!USES_GUC(dev_priv))
|
|
return 0;
|
|
|
|
if (!HAS_GUC(dev_priv)) {
|
|
ret = -ENODEV;
|
|
goto err_out;
|
|
}
|
|
|
|
guc_disable_communication(guc);
|
|
gen9_reset_guc_interrupts(dev_priv);
|
|
|
|
ret = intel_guc_init(guc);
|
|
if (ret)
|
|
goto err_out;
|
|
|
|
if (USES_GUC_SUBMISSION(dev_priv)) {
|
|
/*
|
|
* This is stuff we need to have available at fw load time
|
|
* if we are planning to enable submission later
|
|
*/
|
|
ret = intel_guc_submission_init(guc);
|
|
if (ret)
|
|
goto err_guc;
|
|
}
|
|
|
|
/* init WOPCM */
|
|
I915_WRITE(GUC_WOPCM_SIZE, intel_guc_wopcm_size(dev_priv));
|
|
I915_WRITE(DMA_GUC_WOPCM_OFFSET,
|
|
GUC_WOPCM_OFFSET_VALUE | HUC_LOADING_AGENT_GUC);
|
|
|
|
/* WaEnableuKernelHeaderValidFix:skl */
|
|
/* WaEnableGuCBootHashCheckNotSet:skl,bxt,kbl */
|
|
if (IS_GEN9(dev_priv))
|
|
attempts = 3;
|
|
else
|
|
attempts = 1;
|
|
|
|
while (attempts--) {
|
|
/*
|
|
* Always reset the GuC just before (re)loading, so
|
|
* that the state and timing are fairly predictable
|
|
*/
|
|
ret = __intel_uc_reset_hw(dev_priv);
|
|
if (ret)
|
|
goto err_submission;
|
|
|
|
if (USES_HUC(dev_priv)) {
|
|
ret = intel_huc_init_hw(huc);
|
|
if (ret)
|
|
goto err_submission;
|
|
}
|
|
|
|
intel_guc_init_params(guc);
|
|
ret = intel_guc_fw_upload(guc);
|
|
if (ret == 0 || ret != -EAGAIN)
|
|
break;
|
|
|
|
DRM_DEBUG_DRIVER("GuC fw load failed: %d; will reset and "
|
|
"retry %d more time(s)\n", ret, attempts);
|
|
}
|
|
|
|
/* Did we succeded or run out of retries? */
|
|
if (ret)
|
|
goto err_log_capture;
|
|
|
|
ret = guc_enable_communication(guc);
|
|
if (ret)
|
|
goto err_log_capture;
|
|
|
|
if (USES_HUC(dev_priv)) {
|
|
ret = intel_huc_auth(huc);
|
|
if (ret)
|
|
goto err_communication;
|
|
}
|
|
|
|
if (USES_GUC_SUBMISSION(dev_priv)) {
|
|
if (i915_modparams.guc_log_level >= 0)
|
|
gen9_enable_guc_interrupts(dev_priv);
|
|
|
|
ret = intel_guc_submission_enable(guc);
|
|
if (ret)
|
|
goto err_interrupts;
|
|
}
|
|
|
|
dev_info(dev_priv->drm.dev, "GuC firmware version %u.%u\n",
|
|
guc->fw.major_ver_found, guc->fw.minor_ver_found);
|
|
dev_info(dev_priv->drm.dev, "GuC submission %s\n",
|
|
enableddisabled(USES_GUC_SUBMISSION(dev_priv)));
|
|
dev_info(dev_priv->drm.dev, "HuC %s\n",
|
|
enableddisabled(USES_HUC(dev_priv)));
|
|
|
|
return 0;
|
|
|
|
/*
|
|
* We've failed to load the firmware :(
|
|
*/
|
|
err_interrupts:
|
|
gen9_disable_guc_interrupts(dev_priv);
|
|
err_communication:
|
|
guc_disable_communication(guc);
|
|
err_log_capture:
|
|
guc_capture_load_err_log(guc);
|
|
err_submission:
|
|
if (USES_GUC_SUBMISSION(dev_priv))
|
|
intel_guc_submission_fini(guc);
|
|
err_guc:
|
|
intel_guc_fini(guc);
|
|
err_out:
|
|
/*
|
|
* Note that there is no fallback as either user explicitly asked for
|
|
* the GuC or driver default option was to run with the GuC enabled.
|
|
*/
|
|
if (GEM_WARN_ON(ret == -EIO))
|
|
ret = -EINVAL;
|
|
|
|
dev_err(dev_priv->drm.dev, "GuC initialization failed %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
void intel_uc_fini_hw(struct drm_i915_private *dev_priv)
|
|
{
|
|
struct intel_guc *guc = &dev_priv->guc;
|
|
|
|
guc_free_load_err_log(guc);
|
|
|
|
if (!USES_GUC(dev_priv))
|
|
return;
|
|
|
|
if (USES_GUC_SUBMISSION(dev_priv))
|
|
intel_guc_submission_disable(guc);
|
|
|
|
guc_disable_communication(guc);
|
|
|
|
if (USES_GUC_SUBMISSION(dev_priv)) {
|
|
gen9_disable_guc_interrupts(dev_priv);
|
|
intel_guc_submission_fini(guc);
|
|
}
|
|
|
|
intel_guc_fini(guc);
|
|
}
|