mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-04 08:17:46 +00:00
1ad87824f4
Currently, the log-level of show_stack() depends on a platform realization. It creates situations where the headers are printed with lower log level or higher than the stacktrace (depending on a platform or user). Furthermore, it forces the logic decision from user to an architecture side. In result, some users as sysrq/kdb/etc are doing tricks with temporary rising console_loglevel while printing their messages. And in result it not only may print unwanted messages from other CPUs, but also omit printing at all in the unlucky case where the printk() was deferred. Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems an easier approach than introducing more printk buffers. Also, it will consolidate printings with headers. Introduce show_stack_loglvl(), that eventually will substitute show_stack(). [1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@arista.com/T/#u Signed-off-by: Dmitry Safonov <dima@arista.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> Cc: Jeff Dike <jdike@addtoit.com> Cc: Richard Weinberger <richard@nod.at> Link: http://lkml.kernel.org/r/20200418201944.482088-37-dima@arista.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
63 lines
1.5 KiB
C
63 lines
1.5 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2001 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com)
|
|
* Copyright (C) 2013 Richard Weinberger <richrd@nod.at>
|
|
*/
|
|
|
|
#include <linux/kallsyms.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/sched/debug.h>
|
|
#include <linux/sched/task_stack.h>
|
|
|
|
#include <asm/sysrq.h>
|
|
#include <asm/stacktrace.h>
|
|
#include <os.h>
|
|
|
|
static void _print_addr(void *data, unsigned long address, int reliable)
|
|
{
|
|
const char *loglvl = data;
|
|
|
|
printk("%s [<%08lx>] %s%pS\n", loglvl, address, reliable ? "" : "? ",
|
|
(void *)address);
|
|
}
|
|
|
|
static const struct stacktrace_ops stackops = {
|
|
.address = _print_addr
|
|
};
|
|
|
|
void show_stack_loglvl(struct task_struct *task, unsigned long *stack,
|
|
const char *loglvl)
|
|
{
|
|
struct pt_regs *segv_regs = current->thread.segv_regs;
|
|
int i;
|
|
|
|
if (!segv_regs && os_is_signal_stack()) {
|
|
pr_err("Received SIGSEGV in SIGSEGV handler,"
|
|
" aborting stack trace!\n");
|
|
return;
|
|
}
|
|
|
|
if (!stack)
|
|
stack = get_stack_pointer(task, segv_regs);
|
|
|
|
printk("%sStack:\n", loglvl);
|
|
for (i = 0; i < 3 * STACKSLOTS_PER_LINE; i++) {
|
|
if (kstack_end(stack))
|
|
break;
|
|
if (i && ((i % STACKSLOTS_PER_LINE) == 0))
|
|
printk("%s\n", loglvl);
|
|
pr_cont(" %08lx", *stack++);
|
|
}
|
|
printk("%s\n", loglvl);
|
|
|
|
printk("%sCall Trace:\n", loglvl);
|
|
dump_trace(current, &stackops, (void *)loglvl);
|
|
printk("%s\n", loglvl);
|
|
}
|
|
|
|
void show_stack(struct task_struct *task, unsigned long *stack)
|
|
{
|
|
show_stack_loglvl(task, stack, KERN_INFO);
|
|
}
|