mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 00:34:52 +00:00
12a26c298d
divider_recalc_rate() is an helper function used by clock divider of
different types, so the structure containing the 'hw' pointer is not
always a 'struct clk_divider'
At the following line:
> div = _get_div(table, val, flags, divider->width);
in several cases, the value of 'divider->width' is garbage as the actual
structure behind this memory is not a 'struct clk_divider'
Fortunately, this width value is used by _get_val() only when
CLK_DIVIDER_MAX_AT_ZERO flag is set. This has never been the case so
far when the structure is not a 'struct clk_divider'. This is probably
why we did not notice this bug before
Fixes: afe76c8fd0 ("clk: allow a clk divider with max divisor when zero")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
70 lines
2.1 KiB
C
70 lines
2.1 KiB
C
/*
|
|
* Copyright (c) 2014, The Linux Foundation. All rights reserved.
|
|
*
|
|
* This software is licensed under the terms of the GNU General Public
|
|
* License version 2, as published by the Free Software Foundation, and
|
|
* may be copied, distributed, and modified under those terms.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/bitops.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/export.h>
|
|
|
|
#include "clk-regmap-divider.h"
|
|
|
|
static inline struct clk_regmap_div *to_clk_regmap_div(struct clk_hw *hw)
|
|
{
|
|
return container_of(to_clk_regmap(hw), struct clk_regmap_div, clkr);
|
|
}
|
|
|
|
static long div_round_rate(struct clk_hw *hw, unsigned long rate,
|
|
unsigned long *prate)
|
|
{
|
|
struct clk_regmap_div *divider = to_clk_regmap_div(hw);
|
|
|
|
return divider_round_rate(hw, rate, prate, NULL, divider->width,
|
|
CLK_DIVIDER_ROUND_CLOSEST);
|
|
}
|
|
|
|
static int div_set_rate(struct clk_hw *hw, unsigned long rate,
|
|
unsigned long parent_rate)
|
|
{
|
|
struct clk_regmap_div *divider = to_clk_regmap_div(hw);
|
|
struct clk_regmap *clkr = ÷r->clkr;
|
|
u32 div;
|
|
|
|
div = divider_get_val(rate, parent_rate, NULL, divider->width,
|
|
CLK_DIVIDER_ROUND_CLOSEST);
|
|
|
|
return regmap_update_bits(clkr->regmap, divider->reg,
|
|
(BIT(divider->width) - 1) << divider->shift,
|
|
div << divider->shift);
|
|
}
|
|
|
|
static unsigned long div_recalc_rate(struct clk_hw *hw,
|
|
unsigned long parent_rate)
|
|
{
|
|
struct clk_regmap_div *divider = to_clk_regmap_div(hw);
|
|
struct clk_regmap *clkr = ÷r->clkr;
|
|
u32 div;
|
|
|
|
regmap_read(clkr->regmap, divider->reg, &div);
|
|
div >>= divider->shift;
|
|
div &= BIT(divider->width) - 1;
|
|
|
|
return divider_recalc_rate(hw, parent_rate, div, NULL,
|
|
CLK_DIVIDER_ROUND_CLOSEST, divider->width);
|
|
}
|
|
|
|
const struct clk_ops clk_regmap_div_ops = {
|
|
.round_rate = div_round_rate,
|
|
.set_rate = div_set_rate,
|
|
.recalc_rate = div_recalc_rate,
|
|
};
|
|
EXPORT_SYMBOL_GPL(clk_regmap_div_ops);
|