public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-05-24 10:39:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
linux/drivers/infiniband/core
History
Julia Lawall 10f32065a2 RDMA/iwcm: Test rdma_create_id() for IS_ERR rather than 0 
The function rdma_create_id() always returns either a valid pointer or
a value made with ERR_PTR, so its result should be tested with IS_ERR,
not with a test for 0.

The problem was found using the following semantic match.
(http://www.emn.fr/x-info/coccinelle/)

//<smpl>
@a@
expression E, E1;
statement S,S1;
position p;
@@

E = rdma_create_id(...)
... when != E = E1
if@p (E) S else S1

@n@
position a.p;
expression E,E1;
statement S,S1;
@@

E = NULL
... when != E = E1
if@p (E) S else S1

@depends on !n@
expression E;
statement S,S1;
position a.p;
@@

* if@p (E)
  S else S1
//</smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
2008-04-16 21:09:25 -07:00
..
addr.c trivial endianness annotations: infiniband core 2008-03-30 14:20:24 -07:00
agent.c IB/mad: agent_send_response() should be void 2007-08-03 10:45:17 -07:00
agent.h IB/mad: agent_send_response() should be void 2007-08-03 10:45:17 -07:00
cache.c
cm.c IB/cm: Endianness annotations 2008-04-16 21:01:07 -07:00
cm_msgs.h
cma.c RDMA/iwcm: Test rdma_create_id() for IS_ERR rather than 0 2008-04-16 21:09:25 -07:00
core_priv.h
device.c IB: find_first_zero_bit() takes unsigned pointer 2007-10-09 19:59:04 -07:00
fmr_pool.c IB/fmr_pool: Flush all dirty FMRs from ib_fmr_pool_flush() 2008-02-29 13:31:48 -08:00
iwcm.c RDMA/iwcm: Don't access a cm_id after dropping reference 2008-03-10 21:22:22 -07:00
iwcm.h
mad.c IB/mad: Fix incorrect access to items on local_list 2008-01-25 14:15:31 -08:00
mad_priv.h IB/mad: Report number of times a mad was retried 2008-01-25 14:15:30 -08:00
mad_rmpp.c IB/mad: Report number of times a mad was retried 2008-01-25 14:15:30 -08:00
mad_rmpp.h
Makefile
multicast.c IB/multicast: Report errors on multicast groups if P_key changes 2008-01-25 14:15:29 -08:00
packer.c
sa.h
sa_query.c IB/sa: Add new QoS fields to path record 2007-10-09 19:59:12 -07:00
smi.c
smi.h IB/mad: Enable loopback of DR SMP responses from userspace 2008-01-25 14:15:25 -08:00
sysfs.c IB: Fix return value in ib_device_register_sysfs() 2008-02-15 15:05:05 -08:00
ucm.c IB/cm: Add basic performance counters 2008-01-25 14:15:30 -08:00
ucma.c RDMA/ucma: Endian annotation 2008-04-16 21:01:07 -07:00
ud_header.c
umem.c SG: Change sg_set_page() to take length and offset argument 2007-10-24 11:20:47 +02:00
user_mad.c IB/umad: Simplify and fix locking 2008-01-25 14:15:42 -08:00
uverbs.h IB/uverbs: Don't store struct file * for event files 2008-04-16 21:01:08 -07:00
uverbs_cmd.c IB/uverbs: Fix checking of userspace object ownership 2007-10-19 20:01:43 -07:00
uverbs_main.c IB/uverbs: Use alloc_file() instead of get_empty_filp() 2008-04-16 21:01:08 -07:00
uverbs_marshall.c
verbs.c