public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-18 22:14:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
linux/drivers/net/ethernet/freescale
History
Vladimir Oltean 325fd36ae7 net: enetc: fix the incorrect clearing of IF_MODE bits 
The enetc phylink .mac_config handler intends to clear the IFMODE field
(bits 1:0) of the PM0_IF_MODE register, but incorrectly clears all the
other fields instead.

For normal operation, the bug was inconsequential, due to the fact that
we write the PM0_IF_MODE register in two stages, first in
phylink .mac_config (which incorrectly cleared out a bunch of stuff),
then we update the speed and duplex to the correct values in
phylink .mac_link_up.

Judging by the code (not tested), it looks like maybe loopback mode was
broken, since this is one of the settings in PM0_IF_MODE which is
incorrectly cleared.

Fixes: c76a97218d ("net: enetc: force the RGMII speed and duplex instead of operating in inband mode")
Reported-by: Pavel Machek (CIP) <pavel@denx.de>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2021-09-24 14:03:04 +01:00
..
dpaa ethtool: extend coalesce setting uAPI with CQE mode 2021-08-24 07:38:29 -07:00
dpaa2 dpaa2-eth: Replace strlcpy with strscpy 2021-08-31 11:30:53 +01:00
enetc net: enetc: fix the incorrect clearing of IF_MODE bits 2021-09-24 14:03:04 +01:00
fman fsl/fman: Add fibre support 2021-07-20 07:16:45 -07:00
fs_enet dev_ioctl: split out ndo_eth_ioctl 2021-07-27 20:11:45 +01:00
fec.h net: fec: add WoL support for i.MX8MQ 2021-08-13 16:10:31 -07:00
fec_main.c net: freescale: drop unneeded MODULE_ALIAS 2021-09-19 13:01:40 +01:00
fec_mpc52xx.c dev_ioctl: split out ndo_eth_ioctl 2021-07-27 20:11:45 +01:00
fec_mpc52xx.h
fec_mpc52xx_phy.c
fec_ptp.c net: fec_ptp: fix issue caused by refactor the fec_devtype 2021-06-16 12:39:03 -07:00
fsl_pq_mdio.c
gianfar.c dev_ioctl: split out ndo_eth_ioctl 2021-07-27 20:11:45 +01:00
gianfar.h net: gianfar: Implement rx_missed_errors counter 2021-06-17 11:39:48 -07:00
gianfar_ethtool.c ethtool: extend coalesce setting uAPI with CQE mode 2021-08-24 07:38:29 -07:00
Kconfig ethernet: fix PTP_1588_CLOCK dependencies 2021-08-13 17:49:05 -07:00
Makefile net: enetc: fix link error again 2021-04-22 13:23:07 -07:00
ucc_geth.c dev_ioctl: split out ndo_eth_ioctl 2021-07-27 20:11:45 +01:00
ucc_geth.h
ucc_geth_ethtool.c
xgmac_mdio.c net: mdiobus: withdraw fwnode_mdbiobus_register 2021-06-25 11:46:29 -07:00