mirror of
				git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
				synced 2025-11-01 09:13:37 +00:00 
			
		
		
		
	We were grabbing the sequence number before unlock incremented it - fix this by moving the increment to seqmutex_lock() (so the seqmutex_relock() failure path skips the mutex_trylock()), and returning the sequence number from unlock(), to make the API simpler and safer. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
		
			
				
	
	
		
			45 lines
		
	
	
	
		
			825 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			45 lines
		
	
	
	
		
			825 B
		
	
	
	
		
			C
		
	
	
	
	
	
/* SPDX-License-Identifier: GPL-2.0 */
 | 
						|
#ifndef _BCACHEFS_SEQMUTEX_H
 | 
						|
#define _BCACHEFS_SEQMUTEX_H
 | 
						|
 | 
						|
#include <linux/mutex.h>
 | 
						|
 | 
						|
struct seqmutex {
 | 
						|
	struct mutex	lock;
 | 
						|
	u32		seq;
 | 
						|
};
 | 
						|
 | 
						|
#define seqmutex_init(_lock)	mutex_init(&(_lock)->lock)
 | 
						|
 | 
						|
static inline bool seqmutex_trylock(struct seqmutex *lock)
 | 
						|
{
 | 
						|
	return mutex_trylock(&lock->lock);
 | 
						|
}
 | 
						|
 | 
						|
static inline void seqmutex_lock(struct seqmutex *lock)
 | 
						|
{
 | 
						|
	mutex_lock(&lock->lock);
 | 
						|
	lock->seq++;
 | 
						|
}
 | 
						|
 | 
						|
static inline u32 seqmutex_unlock(struct seqmutex *lock)
 | 
						|
{
 | 
						|
	u32 seq = lock->seq;
 | 
						|
	mutex_unlock(&lock->lock);
 | 
						|
	return seq;
 | 
						|
}
 | 
						|
 | 
						|
static inline bool seqmutex_relock(struct seqmutex *lock, u32 seq)
 | 
						|
{
 | 
						|
	if (lock->seq != seq || !mutex_trylock(&lock->lock))
 | 
						|
		return false;
 | 
						|
 | 
						|
	if (lock->seq != seq) {
 | 
						|
		mutex_unlock(&lock->lock);
 | 
						|
		return false;
 | 
						|
	}
 | 
						|
 | 
						|
	return true;
 | 
						|
}
 | 
						|
 | 
						|
#endif /* _BCACHEFS_SEQMUTEX_H */
 |