mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
![]() The dma-mapping core and the implementations do not change the DMA attributes passed by pointer. Thus the pointer can point to const data. However the attributes do not have to be a bitfield. Instead unsigned long will do fine: 1. This is just simpler. Both in terms of reading the code and setting attributes. Instead of initializing local attributes on the stack and passing pointer to it to dma_set_attr(), just set the bits. 2. It brings safeness and checking for const correctness because the attributes are passed by value. Semantic patches for this change (at least most of them): virtual patch virtual context @r@ identifier f, attrs; @@ f(..., - struct dma_attrs *attrs + unsigned long attrs , ...) { ... } @@ identifier r.f; @@ f(..., - NULL + 0 ) and // Options: --all-includes virtual patch virtual context @r@ identifier f, attrs; type t; @@ t f(..., struct dma_attrs *attrs); @@ identifier r.f; @@ f(..., - NULL + 0 ) Link: http://lkml.kernel.org/r/1468399300-5399-2-git-send-email-k.kozlowski@samsung.com Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Acked-by: Vineet Gupta <vgupta@synopsys.com> Acked-by: Robin Murphy <robin.murphy@arm.com> Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> Acked-by: Mark Salter <msalter@redhat.com> [c6x] Acked-by: Jesper Nilsson <jesper.nilsson@axis.com> [cris] Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> [drm] Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> Acked-by: Joerg Roedel <jroedel@suse.de> [iommu] Acked-by: Fabien Dessenne <fabien.dessenne@st.com> [bdisp] Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> [vb2-core] Acked-by: David Vrabel <david.vrabel@citrix.com> [xen] Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> [xen swiotlb] Acked-by: Joerg Roedel <jroedel@suse.de> [iommu] Acked-by: Richard Kuo <rkuo@codeaurora.org> [hexagon] Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> [m68k] Acked-by: Gerald Schaefer <gerald.schaefer@de.ibm.com> [s390] Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> [avr32] Acked-by: Vineet Gupta <vgupta@synopsys.com> [arc] Acked-by: Robin Murphy <robin.murphy@arm.com> [arm64 and dma-iommu] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
---|---|---|
.. | ||
adc.h | ||
addrspace.h | ||
alignment.h | ||
asm-offsets.h | ||
atomic-grb.h | ||
atomic-irq.h | ||
atomic-llsc.h | ||
atomic.h | ||
barrier.h | ||
bitops-grb.h | ||
bitops-llsc.h | ||
bitops-op32.h | ||
bitops.h | ||
bl_bit.h | ||
bl_bit_32.h | ||
bl_bit_64.h | ||
bug.h | ||
bugs.h | ||
cache.h | ||
cache_insns.h | ||
cache_insns_32.h | ||
cache_insns_64.h | ||
cacheflush.h | ||
checksum.h | ||
checksum_32.h | ||
clock.h | ||
cmpxchg-grb.h | ||
cmpxchg-irq.h | ||
cmpxchg-llsc.h | ||
cmpxchg-xchg.h | ||
cmpxchg.h | ||
device.h | ||
dma-mapping.h | ||
dma-register.h | ||
dma.h | ||
dmabrg.h | ||
dwarf.h | ||
elf.h | ||
entry-macros.S | ||
fb.h | ||
fixmap.h | ||
flat.h | ||
fpu.h | ||
freq.h | ||
ftrace.h | ||
futex-irq.h | ||
futex.h | ||
gpio.h | ||
hardirq.h | ||
hd64461.h | ||
heartbeat.h | ||
hugetlb.h | ||
hw_breakpoint.h | ||
hw_irq.h | ||
i2c-sh7760.h | ||
io.h | ||
io_generic.h | ||
io_noioport.h | ||
io_trapped.h | ||
irq.h | ||
irqflags.h | ||
Kbuild | ||
kdebug.h | ||
kexec.h | ||
kgdb.h | ||
kmap_types.h | ||
kprobes.h | ||
linkage.h | ||
machvec.h | ||
mc146818rtc.h | ||
mmu.h | ||
mmu_context.h | ||
mmu_context_32.h | ||
mmu_context_64.h | ||
mmzone.h | ||
module.h | ||
mutex-llsc.h | ||
mutex.h | ||
page.h | ||
pci.h | ||
perf_event.h | ||
pgalloc.h | ||
pgtable-2level.h | ||
pgtable-3level.h | ||
pgtable.h | ||
pgtable_32.h | ||
pgtable_64.h | ||
posix_types.h | ||
processor.h | ||
processor_32.h | ||
processor_64.h | ||
ptrace.h | ||
ptrace_32.h | ||
ptrace_64.h | ||
push-switch.h | ||
reboot.h | ||
romimage-macros.h | ||
rtc.h | ||
seccomp.h | ||
sections.h | ||
segment.h | ||
setup.h | ||
sfp-machine.h | ||
sh7760fb.h | ||
sh_bios.h | ||
shmparam.h | ||
siu.h | ||
smc37c93x.h | ||
smp-ops.h | ||
smp.h | ||
sparsemem.h | ||
spi.h | ||
spinlock.h | ||
spinlock_types.h | ||
sram.h | ||
stackprotector.h | ||
stacktrace.h | ||
string.h | ||
string_32.h | ||
string_64.h | ||
suspend.h | ||
switch_to.h | ||
switch_to_32.h | ||
switch_to_64.h | ||
syscall.h | ||
syscall_32.h | ||
syscall_64.h | ||
syscalls.h | ||
syscalls_32.h | ||
syscalls_64.h | ||
thread_info.h | ||
timex.h | ||
tlb.h | ||
tlb_64.h | ||
tlbflush.h | ||
topology.h | ||
traps.h | ||
traps_32.h | ||
traps_64.h | ||
types.h | ||
uaccess.h | ||
uaccess_32.h | ||
uaccess_64.h | ||
unaligned-sh4a.h | ||
unaligned.h | ||
uncached.h | ||
unistd.h | ||
unwinder.h | ||
user.h | ||
vga.h | ||
vmlinux.lds.h | ||
watchdog.h | ||
word-at-a-time.h |