mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
dbd6b649e7
The x86 selftests frequently register and clean up signal handlers, but the sethandler() and clearhandler() functions have been redundantly copied across multiple .c files. Move these functions to helpers.h to enable reuse across tests, eliminating around 250 lines of duplicate code. Converge the error handling by using ksft_exit_fail_msg(), which is functionally equivalent with err() within the selftest framework. This change is a prerequisite for the upcoming xstate selftest, which requires signal handling for registering and cleaning up handlers. Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Link: https://lore.kernel.org/r/20250226010731.2456-2-chang.seok.bae@intel.com
53 lines
1.1 KiB
C
53 lines
1.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
#ifndef __SELFTESTS_X86_HELPERS_H
|
|
#define __SELFTESTS_X86_HELPERS_H
|
|
|
|
#include <signal.h>
|
|
#include <string.h>
|
|
|
|
#include <asm/processor-flags.h>
|
|
|
|
#include "../kselftest.h"
|
|
|
|
static inline unsigned long get_eflags(void)
|
|
{
|
|
#ifdef __x86_64__
|
|
return __builtin_ia32_readeflags_u64();
|
|
#else
|
|
return __builtin_ia32_readeflags_u32();
|
|
#endif
|
|
}
|
|
|
|
static inline void set_eflags(unsigned long eflags)
|
|
{
|
|
#ifdef __x86_64__
|
|
__builtin_ia32_writeeflags_u64(eflags);
|
|
#else
|
|
__builtin_ia32_writeeflags_u32(eflags);
|
|
#endif
|
|
}
|
|
|
|
static inline void sethandler(int sig, void (*handler)(int, siginfo_t *, void *), int flags)
|
|
{
|
|
struct sigaction sa;
|
|
|
|
memset(&sa, 0, sizeof(sa));
|
|
sa.sa_sigaction = handler;
|
|
sa.sa_flags = SA_SIGINFO | flags;
|
|
sigemptyset(&sa.sa_mask);
|
|
if (sigaction(sig, &sa, 0))
|
|
ksft_exit_fail_msg("sigaction failed");
|
|
}
|
|
|
|
static inline void clearhandler(int sig)
|
|
{
|
|
struct sigaction sa;
|
|
|
|
memset(&sa, 0, sizeof(sa));
|
|
sa.sa_handler = SIG_DFL;
|
|
sigemptyset(&sa.sa_mask);
|
|
if (sigaction(sig, &sa, 0))
|
|
ksft_exit_fail_msg("sigaction failed");
|
|
}
|
|
|
|
#endif /* __SELFTESTS_X86_HELPERS_H */
|