mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-21 06:50:25 +00:00
e6d7626881
Commit2677010e77("Add support to set NAPI threaded for individual NAPI") added support to enable/disable threaded napi using netlink. This also extended the napi config save/restore functionality to set the napi threaded state. This breaks netdev reset for drivers that use napi threaded at device level and also use napi config save/restore on napi_disable/napi_enable. Basically on netdev with napi threaded enabled at device level, a napi_enable call will get stuck trying to stop the napi kthread. This is because the napi->config->threaded is set to disabled when threaded is enabled at device level. The issue can be reproduced on virtio-net device using qemu. To reproduce the issue run following, echo 1 > /sys/class/net/threaded ethtool -L eth0 combined 1 Update the threaded state in napi config in netif_set_threaded and add a new test that verifies this scenario. Tested on qemu with virtio-net: NETIF=eth0 ./tools/testing/selftests/drivers/net/napi_threaded.py TAP version 13 1..2 ok 1 napi_threaded.change_num_queues ok 2 napi_threaded.enable_dev_threaded_disable_napi_threaded # Totals: pass:2 fail:0 xfail:0 xpass:0 skip:0 error:0 Fixes:2677010e77("Add support to set NAPI threaded for individual NAPI") Signed-off-by: Samiullah Khawaja <skhawaja@google.com> Link: https://patch.msgid.link/20250804164457.2494390-1-skhawaja@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
29 lines
518 B
Makefile
29 lines
518 B
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
CFLAGS += $(KHDR_INCLUDES)
|
|
|
|
TEST_INCLUDES := $(wildcard lib/py/*.py) \
|
|
$(wildcard lib/sh/*.sh) \
|
|
../../net/lib.sh \
|
|
|
|
TEST_GEN_FILES := \
|
|
napi_id_helper \
|
|
# end of TEST_GEN_FILES
|
|
|
|
TEST_PROGS := \
|
|
napi_id.py \
|
|
napi_threaded.py \
|
|
netcons_basic.sh \
|
|
netcons_cmdline.sh \
|
|
netcons_fragmented_msg.sh \
|
|
netcons_overflow.sh \
|
|
netcons_sysdata.sh \
|
|
netpoll_basic.py \
|
|
ping.py \
|
|
queues.py \
|
|
stats.py \
|
|
shaper.py \
|
|
hds.py \
|
|
xdp.py \
|
|
# end of TEST_PROGS
|
|
|
|
include ../../lib.mk
|