mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
1c684d77df
Patch series "selftests/damon: three fixes for false results".
Fix three DAMON selftest bugs that cause two and one false positive
failures and successes.
This patch (of 3):
damos_quota.py assumes the quota will always exceeded. But whether quota
will be exceeded or not depend on the monitoring results. Actually the
monitored workload has chaning access pattern and hence sometimes the
quota may not really be exceeded. As a result, false positive test
failures happen. Expect how much time the quota will be exceeded by
checking the monitoring results, and use it instead of the naive
assumption.
Link: https://lkml.kernel.org/r/20250225222333.505646-1-sj@kernel.org
Link: https://lkml.kernel.org/r/20250225222333.505646-2-sj@kernel.org
Fixes: 51f58c9da1 ("selftests/damon: add a test for DAMOS quota")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
70 lines
2.3 KiB
Python
Executable file
70 lines
2.3 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
import subprocess
|
|
import time
|
|
|
|
import _damon_sysfs
|
|
|
|
def main():
|
|
# access two 10 MiB memory regions, 2 second per each
|
|
sz_region = 10 * 1024 * 1024
|
|
proc = subprocess.Popen(['./access_memory', '2', '%d' % sz_region, '2000'])
|
|
|
|
# Set quota up to 1 MiB per 100 ms
|
|
sz_quota = 1024 * 1024 # 1 MiB
|
|
quota_reset_interval = 100 # 100 ms
|
|
kdamonds = _damon_sysfs.Kdamonds([_damon_sysfs.Kdamond(
|
|
contexts=[_damon_sysfs.DamonCtx(
|
|
ops='vaddr',
|
|
targets=[_damon_sysfs.DamonTarget(pid=proc.pid)],
|
|
schemes=[_damon_sysfs.Damos(
|
|
access_pattern=_damon_sysfs.DamosAccessPattern(
|
|
# >= 25% access rate, >= 200ms age
|
|
nr_accesses=[5, 20], age=[2, 2**64 - 1]),
|
|
quota=_damon_sysfs.DamosQuota(
|
|
sz=sz_quota, reset_interval_ms=quota_reset_interval)
|
|
)] # schemes
|
|
)] # contexts
|
|
)]) # kdamonds
|
|
|
|
err = kdamonds.start()
|
|
if err != None:
|
|
print('kdamond start failed: %s' % err)
|
|
exit(1)
|
|
|
|
wss_collected = []
|
|
nr_quota_exceeds = 0
|
|
while proc.poll() == None:
|
|
time.sleep(0.1)
|
|
err = kdamonds.kdamonds[0].update_schemes_tried_bytes()
|
|
if err != None:
|
|
print('tried bytes update failed: %s' % err)
|
|
exit(1)
|
|
err = kdamonds.kdamonds[0].update_schemes_stats()
|
|
if err != None:
|
|
print('stats update failed: %s' % err)
|
|
exit(1)
|
|
|
|
scheme = kdamonds.kdamonds[0].contexts[0].schemes[0]
|
|
wss_collected.append(scheme.tried_bytes)
|
|
nr_quota_exceeds = scheme.stats.qt_exceeds
|
|
|
|
wss_collected.sort()
|
|
nr_expected_quota_exceeds = 0
|
|
for wss in wss_collected:
|
|
if wss > sz_quota:
|
|
print('quota is not kept: %s > %s' % (wss, sz_quota))
|
|
print('collected samples are as below')
|
|
print('\n'.join(['%d' % wss for wss in wss_collected]))
|
|
exit(1)
|
|
if wss == sz_quota:
|
|
nr_expected_quota_exceeds += 1
|
|
|
|
if nr_quota_exceeds < nr_expected_quota_exceeds:
|
|
print('quota is exceeded less than expected: %d < %d' %
|
|
(nr_quota_exceeds, nr_expected_quota_exceeds))
|
|
exit(1)
|
|
|
|
if __name__ == '__main__':
|
|
main()
|