mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
937a1c29a2
The timer_lockup test needs 2 CPUs to work, on single-CPU nodes it fails
to set thread affinity to CPU 1 since it doesn't exist:
# ./test_progs -t timer_lockup
test_timer_lockup:PASS:timer_lockup__open_and_load 0 nsec
test_timer_lockup:PASS:pthread_create thread1 0 nsec
test_timer_lockup:PASS:pthread_create thread2 0 nsec
timer_lockup_thread:PASS:cpu affinity 0 nsec
timer_lockup_thread:FAIL:cpu affinity unexpected error: 22 (errno 0)
test_timer_lockup:PASS: 0 nsec
#406 timer_lockup:FAIL
Skip the test if only 1 CPU is available.
Signed-off-by: Viktor Malik <vmalik@redhat.com>
Fixes: 50bd5a0c65 ("selftests/bpf: Add timer lockup selftest")
Tested-by: Philo Lu <lulie@linux.alibaba.com>
Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Link: https://lore.kernel.org/r/20241107115231.75200-1-vmalik@redhat.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
97 lines
2.1 KiB
C
97 lines
2.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
#define _GNU_SOURCE
|
|
#include <sched.h>
|
|
#include <test_progs.h>
|
|
#include <pthread.h>
|
|
#include <network_helpers.h>
|
|
#include <sys/sysinfo.h>
|
|
|
|
#include "timer_lockup.skel.h"
|
|
|
|
static long cpu;
|
|
static int *timer1_err;
|
|
static int *timer2_err;
|
|
static bool skip;
|
|
|
|
volatile int k = 0;
|
|
|
|
static void *timer_lockup_thread(void *arg)
|
|
{
|
|
LIBBPF_OPTS(bpf_test_run_opts, opts,
|
|
.data_in = &pkt_v4,
|
|
.data_size_in = sizeof(pkt_v4),
|
|
.repeat = 1000,
|
|
);
|
|
int i, prog_fd = *(int *)arg;
|
|
cpu_set_t cpuset;
|
|
|
|
CPU_ZERO(&cpuset);
|
|
CPU_SET(__sync_fetch_and_add(&cpu, 1), &cpuset);
|
|
ASSERT_OK(pthread_setaffinity_np(pthread_self(), sizeof(cpuset),
|
|
&cpuset),
|
|
"cpu affinity");
|
|
|
|
for (i = 0; !READ_ONCE(*timer1_err) && !READ_ONCE(*timer2_err); i++) {
|
|
bpf_prog_test_run_opts(prog_fd, &opts);
|
|
/* Skip the test if we can't reproduce the race in a reasonable
|
|
* amount of time.
|
|
*/
|
|
if (i > 50) {
|
|
WRITE_ONCE(skip, true);
|
|
break;
|
|
}
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
void test_timer_lockup(void)
|
|
{
|
|
int timer1_prog, timer2_prog;
|
|
struct timer_lockup *skel;
|
|
pthread_t thrds[2];
|
|
void *ret;
|
|
|
|
if (get_nprocs() < 2) {
|
|
test__skip();
|
|
return;
|
|
}
|
|
|
|
skel = timer_lockup__open_and_load();
|
|
if (!ASSERT_OK_PTR(skel, "timer_lockup__open_and_load"))
|
|
return;
|
|
|
|
timer1_prog = bpf_program__fd(skel->progs.timer1_prog);
|
|
timer2_prog = bpf_program__fd(skel->progs.timer2_prog);
|
|
|
|
timer1_err = &skel->bss->timer1_err;
|
|
timer2_err = &skel->bss->timer2_err;
|
|
|
|
if (!ASSERT_OK(pthread_create(&thrds[0], NULL, timer_lockup_thread,
|
|
&timer1_prog),
|
|
"pthread_create thread1"))
|
|
goto out;
|
|
if (!ASSERT_OK(pthread_create(&thrds[1], NULL, timer_lockup_thread,
|
|
&timer2_prog),
|
|
"pthread_create thread2")) {
|
|
pthread_exit(&thrds[0]);
|
|
goto out;
|
|
}
|
|
|
|
pthread_join(thrds[1], &ret);
|
|
pthread_join(thrds[0], &ret);
|
|
|
|
if (skip) {
|
|
test__skip();
|
|
goto out;
|
|
}
|
|
|
|
if (*timer1_err != -EDEADLK && *timer1_err != 0)
|
|
ASSERT_FAIL("timer1_err bad value");
|
|
if (*timer2_err != -EDEADLK && *timer2_err != 0)
|
|
ASSERT_FAIL("timer2_err bad value");
|
|
out:
|
|
timer_lockup__destroy(skel);
|
|
return;
|
|
}
|