mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
2f5d370dec
There are 43 instances of posix shell tests and 35 instances of bash. To give us a single consistent language for testing in, replace all #!/bin/sh to #!/bin/bash. Common sources that are included in both different shells will now work as expected. And we no longer have to fix up bashisms that appear to work when someone's system has sh symlinked to bash, but don't work on other systems that have both shells installed. Although we could have chosen sh, it's not backwards compatible so it wouldn't be possible to bulk convert without re-writing the existing bash tests. Choosing bash also gives us some nicer features including 'local' variable definitions and regexes in if statements that are already widely used in the tests. It's not expected that there are any users with only sh available due to the large number of bash tests that exist. Discussed in relation to running shellcheck here: https://lore.kernel.org/linux-perf-users/e3751a74be34bbf3781c4644f518702a7270220b.1749785642.git.collin.funk1@gmail.com/ Signed-off-by: James Clark <james.clark@linaro.org> Reviewed-by: Collin Funk <collin.funk1@gmail.com> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> Link: https://lore.kernel.org/r/20250623-james-perf-bash-tests-v1-1-f572f54d4559@linaro.org Signed-off-by: Namhyung Kim <namhyung@kernel.org>
50 lines
1.5 KiB
Bash
Executable file
50 lines
1.5 KiB
Bash
Executable file
#!/bin/bash
|
|
# Check open filename arg using perf trace + vfs_getname (exclusive)
|
|
|
|
# Uses the 'perf test shell' library to add probe:vfs_getname to the system
|
|
# then use it with 'perf trace' using 'touch' to write to a temp file, then
|
|
# checks that that was captured by the vfs_getname was used by 'perf trace',
|
|
# that already handles "probe:vfs_getname" if present, and used in the
|
|
# "open" syscall "filename" argument beautifier.
|
|
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
# Arnaldo Carvalho de Melo <acme@kernel.org>, 2017
|
|
|
|
# shellcheck source=lib/probe.sh
|
|
. "$(dirname $0)"/lib/probe.sh
|
|
|
|
skip_if_no_perf_probe || exit 2
|
|
skip_if_no_perf_trace || exit 2
|
|
[ "$(id -u)" = 0 ] || exit 2
|
|
|
|
. "$(dirname $0)"/lib/probe_vfs_getname.sh
|
|
|
|
trace_open_vfs_getname() {
|
|
evts="$(echo "$(perf list tracepoint 2>/dev/null | grep -E 'syscalls:sys_enter_open(at)? ' | sed -r 's/.*sys_enter_([a-z]+) +\[.*$/\1/')" | sed ':a;N;s:\n:,:g')"
|
|
perf trace -e $evts touch $file 2>&1 | \
|
|
grep -E " +[0-9]+\.[0-9]+ +\( +[0-9]+\.[0-9]+ ms\): +touch/[0-9]+ open(at)?\((dfd: +CWD, +)?filename: +\"?${file}\"?, +flags: CREAT\|NOCTTY\|NONBLOCK\|WRONLY, +mode: +IRUGO\|IWUGO\) += +[0-9]+$"
|
|
}
|
|
|
|
add_probe_vfs_getname
|
|
err=$?
|
|
|
|
if [ $err -eq 1 ] ; then
|
|
skip_if_no_debuginfo
|
|
err=$?
|
|
fi
|
|
|
|
if [ $err -ne 0 ] ; then
|
|
exit $err
|
|
fi
|
|
|
|
file=$(mktemp /tmp/temporary_file.XXXXX)
|
|
|
|
# Do not use whatever ~/.perfconfig file, it may change the output
|
|
# via trace.{show_timestamp,show_prefix,etc}
|
|
export PERF_CONFIG=/dev/null
|
|
|
|
trace_open_vfs_getname
|
|
err=$?
|
|
rm -f ${file}
|
|
cleanup_probe_vfs_getname
|
|
exit $err
|