mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
02ba09c8ab
Test case "stat_all_pmu.sh" is not correctly checking 'perf stat' output
due to a poor design. Firstly, having the 'set -e' option with a trap
catching the sigexit causes the shell to exit immediately if 'perf stat' ends
with any non-zero value, which is then caught by the trap reporting an
unexpected signal. This causes events that should be parsed by the if-else
statement to be caught by the trap handler and are reported as errors:
$ perf test -vv "perf all pmu"
Testing i915/actual-frequency/
Unexpected signal in main
Error:
Access to performance monitoring and observability operations is limited.
Secondly, the if-else branches are not exclusive as the checking if the
event is present in the output log covers also the "<not supported>"
events, which should be accepted, and also the "Bad name events", which
should be rejected.
Remove the "set -e" option from the test case, correctly parse the
"perf stat" output log and check its return value. Add the missing
outputs for the 'perf stat' result and also add logs messages to
report the branch that parsed the event for more info.
Fixes: 7e73ea4029 ("perf test: Ignore security failures in all PMU test")
Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
Tested-by: Qiao Zhao <qzhao@redhat.com>
Link: https://lore.kernel.org/r/20241122231233.79509-1-vmolnaro@redhat.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
71 lines
1.7 KiB
Bash
Executable file
71 lines
1.7 KiB
Bash
Executable file
#!/bin/bash
|
|
# perf all PMU test (exclusive)
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
err=0
|
|
result=""
|
|
|
|
trap_cleanup() {
|
|
echo "Unexpected signal in ${FUNCNAME[1]}"
|
|
echo "$result"
|
|
exit 1
|
|
}
|
|
trap trap_cleanup EXIT TERM INT
|
|
|
|
# Test all PMU events; however exclude parameterized ones (name contains '?')
|
|
for p in $(perf list --raw-dump pmu | sed 's/[[:graph:]]\+?[[:graph:]]\+[[:space:]]//g')
|
|
do
|
|
echo -n "Testing $p -- "
|
|
output=$(perf stat -e "$p" true 2>&1)
|
|
stat_result=$?
|
|
if echo "$output" | grep -q "$p"
|
|
then
|
|
# Event seen in output.
|
|
if [ $stat_result -eq 0 ] && ! echo "$output" | grep -q "<not supported>"
|
|
then
|
|
# Event supported.
|
|
echo "supported"
|
|
continue
|
|
elif echo "$output" | grep -q "<not supported>"
|
|
then
|
|
# Event not supported, so ignore.
|
|
echo "not supported"
|
|
continue
|
|
elif echo "$output" | grep -q "No permission to enable"
|
|
then
|
|
# No permissions, so ignore.
|
|
echo "no permission to enable"
|
|
continue
|
|
elif echo "$output" | grep -q "Bad event name"
|
|
then
|
|
# Non-existent event.
|
|
echo "Error: Bad event name"
|
|
echo "$output"
|
|
err=1
|
|
continue
|
|
fi
|
|
fi
|
|
|
|
if echo "$output" | grep -q "Access to performance monitoring and observability operations is limited."
|
|
then
|
|
# Access is limited, so ignore.
|
|
echo "access limited"
|
|
continue
|
|
fi
|
|
|
|
# We failed to see the event and it is supported. Possibly the workload was
|
|
# too small so retry with something longer.
|
|
output=$(perf stat -e "$p" perf bench internals synthesize 2>&1)
|
|
if echo "$output" | grep -q "$p"
|
|
then
|
|
# Event seen in output.
|
|
echo "supported"
|
|
continue
|
|
fi
|
|
echo "Error: event '$p' not printed in:"
|
|
echo "$output"
|
|
err=1
|
|
done
|
|
|
|
trap - EXIT TERM INT
|
|
exit $err
|