mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
2f5d370dec
There are 43 instances of posix shell tests and 35 instances of bash. To give us a single consistent language for testing in, replace all #!/bin/sh to #!/bin/bash. Common sources that are included in both different shells will now work as expected. And we no longer have to fix up bashisms that appear to work when someone's system has sh symlinked to bash, but don't work on other systems that have both shells installed. Although we could have chosen sh, it's not backwards compatible so it wouldn't be possible to bulk convert without re-writing the existing bash tests. Choosing bash also gives us some nicer features including 'local' variable definitions and regexes in if statements that are already widely used in the tests. It's not expected that there are any users with only sh available due to the large number of bash tests that exist. Discussed in relation to running shellcheck here: https://lore.kernel.org/linux-perf-users/e3751a74be34bbf3781c4644f518702a7270220b.1749785642.git.collin.funk1@gmail.com/ Signed-off-by: James Clark <james.clark@linaro.org> Reviewed-by: Collin Funk <collin.funk1@gmail.com> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> Link: https://lore.kernel.org/r/20250623-james-perf-bash-tests-v1-1-f572f54d4559@linaro.org Signed-off-by: Namhyung Kim <namhyung@kernel.org>
108 lines
1.9 KiB
Bash
Executable file
108 lines
1.9 KiB
Bash
Executable file
#!/bin/bash
|
|
# perf diff tests
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
set -e
|
|
|
|
err=0
|
|
perfdata1=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
|
|
perfdata2=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
|
|
perfdata3=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
|
|
testprog="perf test -w thloop"
|
|
|
|
shelldir=$(dirname "$0")
|
|
# shellcheck source=lib/perf_has_symbol.sh
|
|
. "${shelldir}"/lib/perf_has_symbol.sh
|
|
|
|
testsym="test_loop"
|
|
|
|
skip_test_missing_symbol ${testsym}
|
|
|
|
cleanup() {
|
|
rm -rf "${perfdata1}"
|
|
rm -rf "${perfdata1}".old
|
|
rm -rf "${perfdata2}"
|
|
rm -rf "${perfdata2}".old
|
|
rm -rf "${perfdata3}"
|
|
rm -rf "${perfdata3}".old
|
|
|
|
trap - EXIT TERM INT
|
|
}
|
|
|
|
trap_cleanup() {
|
|
cleanup
|
|
exit 1
|
|
}
|
|
trap trap_cleanup EXIT TERM INT
|
|
|
|
make_data() {
|
|
file="$1"
|
|
if ! perf record -o "${file}" ${testprog} 2> /dev/null
|
|
then
|
|
echo "Workload record [Failed record]" >&2
|
|
echo 1
|
|
return
|
|
fi
|
|
if ! perf report -i "${file}" -q | grep -q "${testsym}"
|
|
then
|
|
echo "Workload record [Failed missing output]" >&2
|
|
echo 1
|
|
return
|
|
fi
|
|
echo 0
|
|
}
|
|
|
|
test_two_files() {
|
|
echo "Basic two file diff test"
|
|
err=$(make_data "${perfdata1}")
|
|
if [ "$err" != 0 ]
|
|
then
|
|
return
|
|
fi
|
|
err=$(make_data "${perfdata2}")
|
|
if [ "$err" != 0 ]
|
|
then
|
|
return
|
|
fi
|
|
|
|
if ! perf diff "${perfdata1}" "${perfdata2}" | grep -q "${testsym}"
|
|
then
|
|
echo "Basic two file diff test [Failed diff]"
|
|
err=1
|
|
return
|
|
fi
|
|
echo "Basic two file diff test [Success]"
|
|
}
|
|
|
|
test_three_files() {
|
|
echo "Basic three file diff test"
|
|
err=$(make_data "${perfdata1}")
|
|
if [ "$err" != 0 ]
|
|
then
|
|
return
|
|
fi
|
|
err=$(make_data "${perfdata2}")
|
|
if [ "$err" != 0 ]
|
|
then
|
|
return
|
|
fi
|
|
err=$(make_data "${perfdata3}")
|
|
if [ $err != 0 ]
|
|
then
|
|
return
|
|
fi
|
|
|
|
if ! perf diff "${perfdata1}" "${perfdata2}" "${perfdata3}" | grep -q "${testsym}"
|
|
then
|
|
echo "Basic three file diff test [Failed diff]"
|
|
err=1
|
|
return
|
|
fi
|
|
echo "Basic three file diff test [Success]"
|
|
}
|
|
|
|
test_two_files
|
|
test_three_files
|
|
|
|
cleanup
|
|
exit $err
|