mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00

There are 43 instances of posix shell tests and 35 instances of bash. To give us a single consistent language for testing in, replace all #!/bin/sh to #!/bin/bash. Common sources that are included in both different shells will now work as expected. And we no longer have to fix up bashisms that appear to work when someone's system has sh symlinked to bash, but don't work on other systems that have both shells installed. Although we could have chosen sh, it's not backwards compatible so it wouldn't be possible to bulk convert without re-writing the existing bash tests. Choosing bash also gives us some nicer features including 'local' variable definitions and regexes in if statements that are already widely used in the tests. It's not expected that there are any users with only sh available due to the large number of bash tests that exist. Discussed in relation to running shellcheck here: https://lore.kernel.org/linux-perf-users/e3751a74be34bbf3781c4644f518702a7270220b.1749785642.git.collin.funk1@gmail.com/ Signed-off-by: James Clark <james.clark@linaro.org> Reviewed-by: Collin Funk <collin.funk1@gmail.com> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> Link: https://lore.kernel.org/r/20250623-james-perf-bash-tests-v1-1-f572f54d4559@linaro.org Signed-off-by: Namhyung Kim <namhyung@kernel.org>
175 lines
4.1 KiB
Bash
Executable file
175 lines
4.1 KiB
Bash
Executable file
#!/bin/bash
|
|
# build id cache operations
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
# skip if there's no readelf
|
|
if ! [ -x "$(command -v readelf)" ]; then
|
|
echo "failed: no readelf, install binutils"
|
|
exit 2
|
|
fi
|
|
|
|
# skip if there's no compiler
|
|
if ! [ -x "$(command -v cc)" ]; then
|
|
echo "failed: no compiler, install gcc"
|
|
exit 2
|
|
fi
|
|
|
|
# check what we need to test windows binaries
|
|
add_pe=1
|
|
run_pe=1
|
|
if ! perf version --build-options | grep -q 'libbfd: .* on '; then
|
|
echo "WARNING: perf not built with libbfd. PE binaries will not be tested."
|
|
add_pe=0
|
|
run_pe=0
|
|
fi
|
|
if ! which wine > /dev/null; then
|
|
echo "WARNING: wine not found. PE binaries will not be run."
|
|
run_pe=0
|
|
fi
|
|
|
|
# set up wine
|
|
if [ ${run_pe} -eq 1 ]; then
|
|
wineprefix=$(mktemp -d /tmp/perf.wineprefix.XXX)
|
|
export WINEPREFIX=${wineprefix}
|
|
# clear display variables to prevent wine from popping up dialogs
|
|
unset DISPLAY
|
|
unset WAYLAND_DISPLAY
|
|
fi
|
|
|
|
ex_md5=$(mktemp /tmp/perf.ex.MD5.XXX)
|
|
ex_sha1=$(mktemp /tmp/perf.ex.SHA1.XXX)
|
|
ex_pe=$(dirname $0)/../pe-file.exe
|
|
|
|
echo 'int main(void) { return 0; }' | cc -Wl,--build-id=sha1 -o ${ex_sha1} -x c -
|
|
echo 'int main(void) { return 0; }' | cc -Wl,--build-id=md5 -o ${ex_md5} -x c -
|
|
|
|
echo "test binaries: ${ex_sha1} ${ex_md5} ${ex_pe}"
|
|
|
|
check()
|
|
{
|
|
case $1 in
|
|
*.exe)
|
|
# We don't have a tool that can pull a nicely formatted build-id out of
|
|
# a PE file, but we can extract the whole section with objcopy and
|
|
# format it ourselves. The .buildid section is a Debug Directory
|
|
# containing a CodeView entry:
|
|
# https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#debug-directory-image-only
|
|
# https://github.com/dotnet/runtime/blob/da94c022576a5c3bbc0e896f006565905eb137f9/docs/design/specs/PE-COFF.md
|
|
# The build-id starts at byte 33 and must be rearranged into a GUID.
|
|
id=`objcopy -O binary --only-section=.buildid $1 /dev/stdout | \
|
|
cut -c 33-48 | hexdump -ve '/1 "%02x"' | \
|
|
sed 's@^\(..\)\(..\)\(..\)\(..\)\(..\)\(..\)\(..\)\(..\)\(.*\)0a$@\4\3\2\1\6\5\8\7\9@'`
|
|
;;
|
|
*)
|
|
id=`readelf -n ${1} 2>/dev/null | grep 'Build ID' | awk '{print $3}'`
|
|
;;
|
|
esac
|
|
echo "build id: ${id}"
|
|
|
|
id_file=${id#??}
|
|
id_dir=${id%$id_file}
|
|
link=$build_id_dir/.build-id/$id_dir/$id_file
|
|
echo "link: ${link}"
|
|
|
|
if [ ! -h $link ]; then
|
|
echo "failed: link ${link} does not exist"
|
|
exit 1
|
|
fi
|
|
|
|
file=${build_id_dir}/.build-id/$id_dir/`readlink ${link}`/elf
|
|
echo "file: ${file}"
|
|
|
|
# Check for file permission of original file
|
|
# in case of pe-file.exe file
|
|
echo $1 | grep ".exe"
|
|
if [ $? -eq 0 ]; then
|
|
if [ -x $1 ] && [ ! -x $file ]; then
|
|
echo "failed: file ${file} executable does not exist"
|
|
exit 1
|
|
fi
|
|
|
|
if [ ! -x $file ] && [ ! -e $file ]; then
|
|
echo "failed: file ${file} does not exist"
|
|
exit 1
|
|
fi
|
|
elif [ ! -x $file ]; then
|
|
echo "failed: file ${file} does not exist"
|
|
exit 1
|
|
fi
|
|
|
|
diff ${file} ${1}
|
|
if [ $? -ne 0 ]; then
|
|
echo "failed: ${file} do not match"
|
|
exit 1
|
|
fi
|
|
|
|
${perf} buildid-cache -l | grep ${id}
|
|
if [ $? -ne 0 ]; then
|
|
echo "failed: ${id} is not reported by \"perf buildid-cache -l\""
|
|
exit 1
|
|
fi
|
|
|
|
echo "OK for ${1}"
|
|
}
|
|
|
|
test_add()
|
|
{
|
|
build_id_dir=$(mktemp -d /tmp/perf.debug.XXX)
|
|
perf="perf --buildid-dir ${build_id_dir}"
|
|
|
|
${perf} buildid-cache -v -a ${1}
|
|
if [ $? -ne 0 ]; then
|
|
echo "failed: add ${1} to build id cache"
|
|
exit 1
|
|
fi
|
|
|
|
check ${1}
|
|
|
|
rm -rf ${build_id_dir}
|
|
}
|
|
|
|
test_record()
|
|
{
|
|
data=$(mktemp /tmp/perf.data.XXX)
|
|
build_id_dir=$(mktemp -d /tmp/perf.debug.XXX)
|
|
log_out=$(mktemp /tmp/perf.log.out.XXX)
|
|
log_err=$(mktemp /tmp/perf.log.err.XXX)
|
|
perf="perf --buildid-dir ${build_id_dir}"
|
|
|
|
echo "running: perf record $*"
|
|
${perf} record --buildid-all -o ${data} "$@" 1>${log_out} 2>${log_err}
|
|
if [ $? -ne 0 ]; then
|
|
echo "failed: record $*"
|
|
echo "see log: ${log_err}"
|
|
exit 1
|
|
fi
|
|
|
|
args="$*"
|
|
check ${args##* }
|
|
|
|
rm -f ${log_out} ${log_err}
|
|
rm -rf ${build_id_dir}
|
|
rm -rf ${data}
|
|
}
|
|
|
|
# add binaries manual via perf buildid-cache -a
|
|
test_add ${ex_sha1}
|
|
test_add ${ex_md5}
|
|
if [ ${add_pe} -eq 1 ]; then
|
|
test_add ${ex_pe}
|
|
fi
|
|
|
|
# add binaries via perf record post processing
|
|
test_record ${ex_sha1}
|
|
test_record ${ex_md5}
|
|
if [ ${run_pe} -eq 1 ]; then
|
|
test_record wine ${ex_pe}
|
|
fi
|
|
|
|
# cleanup
|
|
rm ${ex_sha1} ${ex_md5}
|
|
if [ ${run_pe} -eq 1 ]; then
|
|
rm -r ${wineprefix}
|
|
fi
|
|
|
|
exit 0
|