mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00

There are 43 instances of posix shell tests and 35 instances of bash. To give us a single consistent language for testing in, replace all #!/bin/sh to #!/bin/bash. Common sources that are included in both different shells will now work as expected. And we no longer have to fix up bashisms that appear to work when someone's system has sh symlinked to bash, but don't work on other systems that have both shells installed. Although we could have chosen sh, it's not backwards compatible so it wouldn't be possible to bulk convert without re-writing the existing bash tests. Choosing bash also gives us some nicer features including 'local' variable definitions and regexes in if statements that are already widely used in the tests. It's not expected that there are any users with only sh available due to the large number of bash tests that exist. Discussed in relation to running shellcheck here: https://lore.kernel.org/linux-perf-users/e3751a74be34bbf3781c4644f518702a7270220b.1749785642.git.collin.funk1@gmail.com/ Signed-off-by: James Clark <james.clark@linaro.org> Reviewed-by: Collin Funk <collin.funk1@gmail.com> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> Link: https://lore.kernel.org/r/20250623-james-perf-bash-tests-v1-1-f572f54d4559@linaro.org Signed-off-by: Namhyung Kim <namhyung@kernel.org>
23 lines
720 B
Bash
Executable file
23 lines
720 B
Bash
Executable file
#!/bin/bash
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
# Test one of the main kernel Makefile targets to generate a perf sources tarball
|
|
# suitable for build outside the full kernel sources.
|
|
#
|
|
# This is to test that the tools/perf/MANIFEST file lists all the files needed to
|
|
# be in such tarball, which sometimes gets broken when we move files around,
|
|
# like when we made some files that were in tools/perf/ available to other tools/
|
|
# codebases by moving it to tools/include/, etc.
|
|
set -e
|
|
|
|
PERF=$1
|
|
cd ${PERF}/../..
|
|
make perf-targz-src-pkg
|
|
TARBALL=$(ls -rt perf-*.tar.gz)
|
|
TMP_DEST=$(mktemp -d)
|
|
tar xf ${TARBALL} -C $TMP_DEST
|
|
rm -f ${TARBALL}
|
|
cd - > /dev/null
|
|
make -C $TMP_DEST/perf*/tools/perf
|
|
RC=$?
|
|
rm -rf ${TMP_DEST}
|
|
exit $RC
|