mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
ad5a0970f8
Currently the return value from spi_setup() is not checked for a failure.
It is unlikely it will ever fail in this particular case but it is still
better to add this check for the sake of completeness and correctness. This
is cheap since it is performed once when the device is being probed.
Handle spi_setup() return value.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Fixes: 872fc0b6bd ("ASoC: cs35l41: Set the max SPI speed for the whole device")
Signed-off-by: Vitaliy Shevtsov <v.shevtsov@mt-integration.ru>
Link: https://patch.msgid.link/20250304115643.2748-1-v.shevtsov@mt-integration.ru
Signed-off-by: Mark Brown <broonie@kernel.org>
99 lines
2.4 KiB
C
99 lines
2.4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
//
|
|
// cs35l41-spi.c -- CS35l41 SPI driver
|
|
//
|
|
// Copyright 2017-2021 Cirrus Logic, Inc.
|
|
//
|
|
// Author: David Rhodes <david.rhodes@cirrus.com>
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/init.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/moduleparam.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/spi/spi.h>
|
|
|
|
#include "cs35l41.h"
|
|
|
|
static const struct spi_device_id cs35l41_id_spi[] = {
|
|
{ "cs35l40", 0 },
|
|
{ "cs35l41", 0 },
|
|
{ "cs35l51", 0 },
|
|
{ "cs35l53", 0 },
|
|
{}
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(spi, cs35l41_id_spi);
|
|
|
|
static int cs35l41_spi_probe(struct spi_device *spi)
|
|
{
|
|
const struct regmap_config *regmap_config = &cs35l41_regmap_spi;
|
|
struct cs35l41_hw_cfg *hw_cfg = dev_get_platdata(&spi->dev);
|
|
struct cs35l41_private *cs35l41;
|
|
int ret;
|
|
|
|
cs35l41 = devm_kzalloc(&spi->dev, sizeof(struct cs35l41_private), GFP_KERNEL);
|
|
if (!cs35l41)
|
|
return -ENOMEM;
|
|
|
|
spi->max_speed_hz = CS35L41_SPI_MAX_FREQ;
|
|
ret = spi_setup(spi);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
spi_set_drvdata(spi, cs35l41);
|
|
cs35l41->regmap = devm_regmap_init_spi(spi, regmap_config);
|
|
if (IS_ERR(cs35l41->regmap))
|
|
return dev_err_probe(cs35l41->dev, PTR_ERR(cs35l41->regmap),
|
|
"Failed to allocate register map\n");
|
|
|
|
cs35l41->dev = &spi->dev;
|
|
cs35l41->irq = spi->irq;
|
|
|
|
return cs35l41_probe(cs35l41, hw_cfg);
|
|
}
|
|
|
|
static void cs35l41_spi_remove(struct spi_device *spi)
|
|
{
|
|
struct cs35l41_private *cs35l41 = spi_get_drvdata(spi);
|
|
|
|
cs35l41_remove(cs35l41);
|
|
}
|
|
|
|
#ifdef CONFIG_OF
|
|
static const struct of_device_id cs35l41_of_match[] = {
|
|
{ .compatible = "cirrus,cs35l40" },
|
|
{ .compatible = "cirrus,cs35l41" },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, cs35l41_of_match);
|
|
#endif
|
|
|
|
#ifdef CONFIG_ACPI
|
|
static const struct acpi_device_id cs35l41_acpi_match[] = {
|
|
{ "CSC3541", 0 }, /* Cirrus Logic PnP ID + part ID */
|
|
{ "CLSA3541", 0 }, /* Cirrus Logic PnP ID + part ID */
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_match);
|
|
#endif
|
|
|
|
static struct spi_driver cs35l41_spi_driver = {
|
|
.driver = {
|
|
.name = "cs35l41",
|
|
.pm = pm_ptr(&cs35l41_pm_ops),
|
|
.of_match_table = of_match_ptr(cs35l41_of_match),
|
|
.acpi_match_table = ACPI_PTR(cs35l41_acpi_match),
|
|
},
|
|
.id_table = cs35l41_id_spi,
|
|
.probe = cs35l41_spi_probe,
|
|
.remove = cs35l41_spi_remove,
|
|
};
|
|
|
|
module_spi_driver(cs35l41_spi_driver);
|
|
|
|
MODULE_DESCRIPTION("SPI CS35L41 driver");
|
|
MODULE_AUTHOR("David Rhodes, Cirrus Logic Inc, <david.rhodes@cirrus.com>");
|
|
MODULE_LICENSE("GPL");
|