mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00

Toolchain and infrastructure: - Enable a set of Clippy lints: 'ptr_as_ptr', 'ptr_cast_constness', 'as_ptr_cast_mut', 'as_underscore', 'cast_lossless' and 'ref_as_ptr'. These are intended to avoid type casts with the 'as' operator, which are quite powerful, into restricted variants that are less powerful and thus should help to avoid mistakes. - Remove the 'author' key now that most instances were moved to the plural one in the previous cycle. 'kernel' crate: - New 'bug' module: add 'warn_on!' macro which reuses the existing 'BUG'/'WARN' infrastructure, i.e. it respects the usual sysctls and kernel parameters: warn_on!(value == 42); To avoid duplicating the assembly code, the same strategy is followed as for the static branch code in order to share the assembly between both C and Rust. This required a few rearrangements on C arch headers -- the existing C macros should still generate the same outputs, thus no functional change expected there. - 'workqueue' module: add delayed work items, including a 'DelayedWork' struct, a 'impl_has_delayed_work!' macro and an 'enqueue_delayed' method, e.g.: /// Enqueue the struct for execution on the system workqueue, /// where its value will be printed 42 jiffies later. fn print_later(value: Arc<MyStruct>) { let _ = workqueue::system().enqueue_delayed(value, 42); } - New 'bits' module: add support for 'bit' and 'genmask' functions, with runtime- and compile-time variants, e.g.: static_assert!(0b00010000 == bit_u8(4)); static_assert!(0b00011110 == genmask_u8(1..=4)); assert!(checked_bit_u32(u32::BITS).is_none()); - 'uaccess' module: add 'UserSliceReader::strcpy_into_buf', which reads NUL-terminated strings from userspace into a '&CStr'. Introduce 'UserPtr' newtype, similar in purpose to '__user' in C, to minimize mistakes handling userspace pointers, including mixing them up with integers and leaking them via the 'Debug' trait. Add it to the prelude, too. - Start preparations for the replacement of our custom 'CStr' type with the analogous type in the 'core' standard library. This will take place across several cycles to make it easier. For this one, it includes a new 'fmt' module, using upstream method names and some other cleanups. Replace 'fmt!' with a re-export, which helps Clippy lint properly, and clean up the found 'uninlined-format-args' instances. - 'dma' module: - Clarify wording and be consistent in 'coherent' nomenclature. - Convert the 'read!()' and 'write!()' macros to return a 'Result'. - Add 'as_slice()', 'write()' methods in 'CoherentAllocation'. - Expose 'count()' and 'size()' in 'CoherentAllocation' and add the corresponding type invariants. - Implement 'CoherentAllocation::dma_handle_with_offset()'. - 'time' module: - Make 'Instant' generic over clock source. This allows the compiler to assert that arithmetic expressions involving the 'Instant' use 'Instants' based on the same clock source. - Make 'HrTimer' generic over the timer mode. 'HrTimer' timers take a 'Duration' or an 'Instant' when setting the expiry time, depending on the timer mode. With this change, the compiler can check the type matches the timer mode. - Add an abstraction for 'fsleep'. 'fsleep' is a flexible sleep function that will select an appropriate sleep method depending on the requested sleep time. - Avoid 64-bit divisions on 32-bit hardware when calculating timestamps. - Seal the 'HrTimerMode' trait. This prevents users of the 'HrTimerMode' from implementing the trait on their own types. - Pass the correct timer mode ID to 'hrtimer_start_range_ns()'. - 'list' module: remove 'OFFSET' constants, allowing to remove pointer arithmetic; now 'impl_list_item!' invokes 'impl_has_list_links!' or 'impl_has_list_links_self_ptr!'. Other simplifications too. - 'types' module: remove 'ForeignOwnable::PointedTo' in favor of a constant, which avoids exposing the type of the opaque pointer, and require 'into_foreign' to return non-null. Remove the 'Either<L, R>' type as well. It is unused, and we want to encourage the use of custom enums for concrete use cases. - 'sync' module: implement 'Borrow' and 'BorrowMut' for 'Arc' types to allow them to be used in generic APIs. - 'alloc' module: implement 'Borrow' and 'BorrowMut' for 'Box<T, A>'; and 'Borrow', 'BorrowMut' and 'Default' for 'Vec<T, A>'. - 'Opaque' type: add 'cast_from' method to perform a restricted cast that cannot change the inner type and use it in callers of 'container_of!'. Rename 'raw_get' to 'cast_into' to match it. - 'rbtree' module: add 'is_empty' method. - 'sync' module: new 'aref' submodule to hold 'AlwaysRefCounted' and 'ARef', which are moved from the too general 'types' module which we want to reduce or eventually remove. Also fix a safety comment in 'static_lock_class'. 'pin-init' crate: - Add 'impl<T, E> [Pin]Init<T, E> for Result<T, E>', so results are now (pin-)initializers. - Add 'Zeroable::init_zeroed()' that delegates to 'init_zeroed()'. - New 'zeroed()', a safe version of 'mem::zeroed()' and also provide it via 'Zeroable::zeroed()'. - Implement 'Zeroable' for 'Option<&T>', 'Option<&mut T>' and for 'Option<[unsafe] [extern "abi"] fn(...args...) -> ret>' for '"Rust"' and '"C"' ABIs and up to 20 arguments. - Changed blanket impls of 'Init' and 'PinInit' from 'impl<T, E> [Pin]Init<T, E> for T' to 'impl<T> [Pin]Init<T> for T'. - Renamed 'zeroed()' to 'init_zeroed()'. - Upstream dev news: improve CI more to deny warnings, use '--all-targets'. Check the synchronization status of the two '-next' branches in upstream and the kernel. MAINTAINERS: - Add Vlastimil Babka, Liam R. Howlett, Uladzislau Rezki and Lorenzo Stoakes as reviewers (thanks everyone). And a few other cleanups and improvements. -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEPjU5OPd5QIZ9jqqOGXyLc2htIW0FAmiOWREACgkQGXyLc2ht IW39Ig/9E0ExSiBgNKdkCOaULMq31wAxnu3iWoVVisFndlh/Inv+JlaLrmA57BCi xXgBwVZ1GoMsG8Fzt6gT+gyhGYi8waNd+5KXr/WJZVTaJ9v1KpdvxuCnSz0DjCbk GaKfAfxvJ5GAOEwiIIX8X0TFu6kx911DCJY387/VrqZQ7Msh1QSM3tcZeir/EV4w lPjUdlOh1FnLJLI9CGuW20d1IhQUP7K3pdoywgJPpCZV0I8QCyMlMqCEael8Tw2S r/PzRaQtiIzk5HTx06V8paK+nEn0K2vQXqW2kV56Y6TNm1Zcv6dES/8hCITsISs2 nwney3vXEwvoZX+YkQRffZddY4i6YenWMrtLgVxZzdshBL3bn6eHqBL04Nfix+p7 pQe3qMH3G8UBtX1lugBE7RrWGWcz9ARN8sK12ClmpAUnKJOwTpo97kpqXP7pDme8 Buh/oV3voAMsqwooSbVBzuUUWnbGaQ5Oj6CiiosSadfNh6AxJLYLKHtRLKJHZEw3 0Ob/1HhoWS6JSvYKVjMyD19qcH7O8ThZE+83CfMAkI4KphXJarWhpSmN4cHkFn/v 0clQ7Y5m+up9v1XWTaEq0Biqa6CaxLQwm/qW5WU0Y/TiovmvxAFdCwsQqDkRoJNx 9kNfMJRvNl78KQxrjEDz9gl7/ajgqX1KkqP8CQbGjv29cGzFlVE= =5Wt9 -----END PGP SIGNATURE----- Merge tag 'rust-6.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ojeda/linux Pull Rust updates from Miguel Ojeda: "Toolchain and infrastructure: - Enable a set of Clippy lints: 'ptr_as_ptr', 'ptr_cast_constness', 'as_ptr_cast_mut', 'as_underscore', 'cast_lossless' and 'ref_as_ptr' These are intended to avoid type casts with the 'as' operator, which are quite powerful, into restricted variants that are less powerful and thus should help to avoid mistakes - Remove the 'author' key now that most instances were moved to the plural one in the previous cycle 'kernel' crate: - New 'bug' module: add 'warn_on!' macro which reuses the existing 'BUG'/'WARN' infrastructure, i.e. it respects the usual sysctls and kernel parameters: warn_on!(value == 42); To avoid duplicating the assembly code, the same strategy is followed as for the static branch code in order to share the assembly between both C and Rust This required a few rearrangements on C arch headers -- the existing C macros should still generate the same outputs, thus no functional change expected there - 'workqueue' module: add delayed work items, including a 'DelayedWork' struct, a 'impl_has_delayed_work!' macro and an 'enqueue_delayed' method, e.g.: /// Enqueue the struct for execution on the system workqueue, /// where its value will be printed 42 jiffies later. fn print_later(value: Arc<MyStruct>) { let _ = workqueue::system().enqueue_delayed(value, 42); } - New 'bits' module: add support for 'bit' and 'genmask' functions, with runtime- and compile-time variants, e.g.: static_assert!(0b00010000 == bit_u8(4)); static_assert!(0b00011110 == genmask_u8(1..=4)); assert!(checked_bit_u32(u32::BITS).is_none()); - 'uaccess' module: add 'UserSliceReader::strcpy_into_buf', which reads NUL-terminated strings from userspace into a '&CStr' Introduce 'UserPtr' newtype, similar in purpose to '__user' in C, to minimize mistakes handling userspace pointers, including mixing them up with integers and leaking them via the 'Debug' trait. Add it to the prelude, too - Start preparations for the replacement of our custom 'CStr' type with the analogous type in the 'core' standard library. This will take place across several cycles to make it easier. For this one, it includes a new 'fmt' module, using upstream method names and some other cleanups Replace 'fmt!' with a re-export, which helps Clippy lint properly, and clean up the found 'uninlined-format-args' instances - 'dma' module: - Clarify wording and be consistent in 'coherent' nomenclature - Convert the 'read!()' and 'write!()' macros to return a 'Result' - Add 'as_slice()', 'write()' methods in 'CoherentAllocation' - Expose 'count()' and 'size()' in 'CoherentAllocation' and add the corresponding type invariants - Implement 'CoherentAllocation::dma_handle_with_offset()' - 'time' module: - Make 'Instant' generic over clock source. This allows the compiler to assert that arithmetic expressions involving the 'Instant' use 'Instants' based on the same clock source - Make 'HrTimer' generic over the timer mode. 'HrTimer' timers take a 'Duration' or an 'Instant' when setting the expiry time, depending on the timer mode. With this change, the compiler can check the type matches the timer mode - Add an abstraction for 'fsleep'. 'fsleep' is a flexible sleep function that will select an appropriate sleep method depending on the requested sleep time - Avoid 64-bit divisions on 32-bit hardware when calculating timestamps - Seal the 'HrTimerMode' trait. This prevents users of the 'HrTimerMode' from implementing the trait on their own types - Pass the correct timer mode ID to 'hrtimer_start_range_ns()' - 'list' module: remove 'OFFSET' constants, allowing to remove pointer arithmetic; now 'impl_list_item!' invokes 'impl_has_list_links!' or 'impl_has_list_links_self_ptr!'. Other simplifications too - 'types' module: remove 'ForeignOwnable::PointedTo' in favor of a constant, which avoids exposing the type of the opaque pointer, and require 'into_foreign' to return non-null Remove the 'Either<L, R>' type as well. It is unused, and we want to encourage the use of custom enums for concrete use cases - 'sync' module: implement 'Borrow' and 'BorrowMut' for 'Arc' types to allow them to be used in generic APIs - 'alloc' module: implement 'Borrow' and 'BorrowMut' for 'Box<T, A>'; and 'Borrow', 'BorrowMut' and 'Default' for 'Vec<T, A>' - 'Opaque' type: add 'cast_from' method to perform a restricted cast that cannot change the inner type and use it in callers of 'container_of!'. Rename 'raw_get' to 'cast_into' to match it - 'rbtree' module: add 'is_empty' method - 'sync' module: new 'aref' submodule to hold 'AlwaysRefCounted' and 'ARef', which are moved from the too general 'types' module which we want to reduce or eventually remove. Also fix a safety comment in 'static_lock_class' 'pin-init' crate: - Add 'impl<T, E> [Pin]Init<T, E> for Result<T, E>', so results are now (pin-)initializers - Add 'Zeroable::init_zeroed()' that delegates to 'init_zeroed()' - New 'zeroed()', a safe version of 'mem::zeroed()' and also provide it via 'Zeroable::zeroed()' - Implement 'Zeroable' for 'Option<&T>', 'Option<&mut T>' and for 'Option<[unsafe] [extern "abi"] fn(...args...) -> ret>' for '"Rust"' and '"C"' ABIs and up to 20 arguments - Changed blanket impls of 'Init' and 'PinInit' from 'impl<T, E> [Pin]Init<T, E> for T' to 'impl<T> [Pin]Init<T> for T' - Renamed 'zeroed()' to 'init_zeroed()' - Upstream dev news: improve CI more to deny warnings, use '--all-targets'. Check the synchronization status of the two '-next' branches in upstream and the kernel MAINTAINERS: - Add Vlastimil Babka, Liam R. Howlett, Uladzislau Rezki and Lorenzo Stoakes as reviewers (thanks everyone) And a few other cleanups and improvements" * tag 'rust-6.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ojeda/linux: (76 commits) rust: Add warn_on macro arm64/bug: Add ARCH_WARN_ASM macro for BUG/WARN asm code sharing with Rust riscv/bug: Add ARCH_WARN_ASM macro for BUG/WARN asm code sharing with Rust x86/bug: Add ARCH_WARN_ASM macro for BUG/WARN asm code sharing with Rust rust: kernel: move ARef and AlwaysRefCounted to sync::aref rust: sync: fix safety comment for `static_lock_class` rust: types: remove `Either<L, R>` rust: kernel: use `core::ffi::CStr` method names rust: str: add `CStr` methods matching `core::ffi::CStr` rust: str: remove unnecessary qualification rust: use `kernel::{fmt,prelude::fmt!}` rust: kernel: add `fmt` module rust: kernel: remove `fmt!`, fix clippy::uninlined-format-args scripts: rust: emit path candidates in panic message scripts: rust: replace length checks with match rust: list: remove nonexistent generic parameter in link rust: bits: add support for bits/genmask macros rust: list: remove OFFSET constants rust: list: add `impl_list_item!` examples rust: list: use fully qualified path ...
263 lines
9.9 KiB
Rust
263 lines
9.9 KiB
Rust
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
//! Revocable objects.
|
|
//!
|
|
//! The [`Revocable`] type wraps other types and allows access to them to be revoked. The existence
|
|
//! of a [`RevocableGuard`] ensures that objects remain valid.
|
|
|
|
use pin_init::Wrapper;
|
|
|
|
use crate::{bindings, prelude::*, sync::rcu, types::Opaque};
|
|
use core::{
|
|
marker::PhantomData,
|
|
ops::Deref,
|
|
ptr::drop_in_place,
|
|
sync::atomic::{AtomicBool, Ordering},
|
|
};
|
|
|
|
/// An object that can become inaccessible at runtime.
|
|
///
|
|
/// Once access is revoked and all concurrent users complete (i.e., all existing instances of
|
|
/// [`RevocableGuard`] are dropped), the wrapped object is also dropped.
|
|
///
|
|
/// # Examples
|
|
///
|
|
/// ```
|
|
/// # use kernel::revocable::Revocable;
|
|
///
|
|
/// struct Example {
|
|
/// a: u32,
|
|
/// b: u32,
|
|
/// }
|
|
///
|
|
/// fn add_two(v: &Revocable<Example>) -> Option<u32> {
|
|
/// let guard = v.try_access()?;
|
|
/// Some(guard.a + guard.b)
|
|
/// }
|
|
///
|
|
/// let v = KBox::pin_init(Revocable::new(Example { a: 10, b: 20 }), GFP_KERNEL).unwrap();
|
|
/// assert_eq!(add_two(&v), Some(30));
|
|
/// v.revoke();
|
|
/// assert_eq!(add_two(&v), None);
|
|
/// ```
|
|
///
|
|
/// Sample example as above, but explicitly using the rcu read side lock.
|
|
///
|
|
/// ```
|
|
/// # use kernel::revocable::Revocable;
|
|
/// use kernel::sync::rcu;
|
|
///
|
|
/// struct Example {
|
|
/// a: u32,
|
|
/// b: u32,
|
|
/// }
|
|
///
|
|
/// fn add_two(v: &Revocable<Example>) -> Option<u32> {
|
|
/// let guard = rcu::read_lock();
|
|
/// let e = v.try_access_with_guard(&guard)?;
|
|
/// Some(e.a + e.b)
|
|
/// }
|
|
///
|
|
/// let v = KBox::pin_init(Revocable::new(Example { a: 10, b: 20 }), GFP_KERNEL).unwrap();
|
|
/// assert_eq!(add_two(&v), Some(30));
|
|
/// v.revoke();
|
|
/// assert_eq!(add_two(&v), None);
|
|
/// ```
|
|
#[pin_data(PinnedDrop)]
|
|
pub struct Revocable<T> {
|
|
is_available: AtomicBool,
|
|
#[pin]
|
|
data: Opaque<T>,
|
|
}
|
|
|
|
// SAFETY: `Revocable` is `Send` if the wrapped object is also `Send`. This is because while the
|
|
// functionality exposed by `Revocable` can be accessed from any thread/CPU, it is possible that
|
|
// this isn't supported by the wrapped object.
|
|
unsafe impl<T: Send> Send for Revocable<T> {}
|
|
|
|
// SAFETY: `Revocable` is `Sync` if the wrapped object is both `Send` and `Sync`. We require `Send`
|
|
// from the wrapped object as well because of `Revocable::revoke`, which can trigger the `Drop`
|
|
// implementation of the wrapped object from an arbitrary thread.
|
|
unsafe impl<T: Sync + Send> Sync for Revocable<T> {}
|
|
|
|
impl<T> Revocable<T> {
|
|
/// Creates a new revocable instance of the given data.
|
|
pub fn new<E>(data: impl PinInit<T, E>) -> impl PinInit<Self, E> {
|
|
try_pin_init!(Self {
|
|
is_available: AtomicBool::new(true),
|
|
data <- Opaque::pin_init(data),
|
|
}? E)
|
|
}
|
|
|
|
/// Tries to access the revocable wrapped object.
|
|
///
|
|
/// Returns `None` if the object has been revoked and is therefore no longer accessible.
|
|
///
|
|
/// Returns a guard that gives access to the object otherwise; the object is guaranteed to
|
|
/// remain accessible while the guard is alive. In such cases, callers are not allowed to sleep
|
|
/// because another CPU may be waiting to complete the revocation of this object.
|
|
pub fn try_access(&self) -> Option<RevocableGuard<'_, T>> {
|
|
let guard = rcu::read_lock();
|
|
if self.is_available.load(Ordering::Relaxed) {
|
|
// Since `self.is_available` is true, data is initialised and has to remain valid
|
|
// because the RCU read side lock prevents it from being dropped.
|
|
Some(RevocableGuard::new(self.data.get(), guard))
|
|
} else {
|
|
None
|
|
}
|
|
}
|
|
|
|
/// Tries to access the revocable wrapped object.
|
|
///
|
|
/// Returns `None` if the object has been revoked and is therefore no longer accessible.
|
|
///
|
|
/// Returns a shared reference to the object otherwise; the object is guaranteed to
|
|
/// remain accessible while the rcu read side guard is alive. In such cases, callers are not
|
|
/// allowed to sleep because another CPU may be waiting to complete the revocation of this
|
|
/// object.
|
|
pub fn try_access_with_guard<'a>(&'a self, _guard: &'a rcu::Guard) -> Option<&'a T> {
|
|
if self.is_available.load(Ordering::Relaxed) {
|
|
// SAFETY: Since `self.is_available` is true, data is initialised and has to remain
|
|
// valid because the RCU read side lock prevents it from being dropped.
|
|
Some(unsafe { &*self.data.get() })
|
|
} else {
|
|
None
|
|
}
|
|
}
|
|
|
|
/// Tries to access the wrapped object and run a closure on it while the guard is held.
|
|
///
|
|
/// This is a convenience method to run short non-sleepable code blocks while ensuring the
|
|
/// guard is dropped afterwards. [`Self::try_access`] carries the risk that the caller will
|
|
/// forget to explicitly drop that returned guard before calling sleepable code; this method
|
|
/// adds an extra safety to make sure it doesn't happen.
|
|
///
|
|
/// Returns [`None`] if the object has been revoked and is therefore no longer accessible, or
|
|
/// the result of the closure wrapped in [`Some`]. If the closure returns a [`Result`] then the
|
|
/// return type becomes `Option<Result<>>`, which can be inconvenient. Users are encouraged to
|
|
/// define their own macro that turns the [`Option`] into a proper error code and flattens the
|
|
/// inner result into it if it makes sense within their subsystem.
|
|
pub fn try_access_with<R, F: FnOnce(&T) -> R>(&self, f: F) -> Option<R> {
|
|
self.try_access().map(|t| f(&*t))
|
|
}
|
|
|
|
/// Directly access the revocable wrapped object.
|
|
///
|
|
/// # Safety
|
|
///
|
|
/// The caller must ensure this [`Revocable`] instance hasn't been revoked and won't be revoked
|
|
/// as long as the returned `&T` lives.
|
|
pub unsafe fn access(&self) -> &T {
|
|
// SAFETY: By the safety requirement of this function it is guaranteed that
|
|
// `self.data.get()` is a valid pointer to an instance of `T`.
|
|
unsafe { &*self.data.get() }
|
|
}
|
|
|
|
/// # Safety
|
|
///
|
|
/// Callers must ensure that there are no more concurrent users of the revocable object.
|
|
unsafe fn revoke_internal<const SYNC: bool>(&self) -> bool {
|
|
let revoke = self.is_available.swap(false, Ordering::Relaxed);
|
|
|
|
if revoke {
|
|
if SYNC {
|
|
// SAFETY: Just an FFI call, there are no further requirements.
|
|
unsafe { bindings::synchronize_rcu() };
|
|
}
|
|
|
|
// SAFETY: We know `self.data` is valid because only one CPU can succeed the
|
|
// `compare_exchange` above that takes `is_available` from `true` to `false`.
|
|
unsafe { drop_in_place(self.data.get()) };
|
|
}
|
|
|
|
revoke
|
|
}
|
|
|
|
/// Revokes access to and drops the wrapped object.
|
|
///
|
|
/// Access to the object is revoked immediately to new callers of [`Revocable::try_access`],
|
|
/// expecting that there are no concurrent users of the object.
|
|
///
|
|
/// Returns `true` if `&self` has been revoked with this call, `false` if it was revoked
|
|
/// already.
|
|
///
|
|
/// # Safety
|
|
///
|
|
/// Callers must ensure that there are no more concurrent users of the revocable object.
|
|
pub unsafe fn revoke_nosync(&self) -> bool {
|
|
// SAFETY: By the safety requirement of this function, the caller ensures that nobody is
|
|
// accessing the data anymore and hence we don't have to wait for the grace period to
|
|
// finish.
|
|
unsafe { self.revoke_internal::<false>() }
|
|
}
|
|
|
|
/// Revokes access to and drops the wrapped object.
|
|
///
|
|
/// Access to the object is revoked immediately to new callers of [`Revocable::try_access`].
|
|
///
|
|
/// If there are concurrent users of the object (i.e., ones that called
|
|
/// [`Revocable::try_access`] beforehand and still haven't dropped the returned guard), this
|
|
/// function waits for the concurrent access to complete before dropping the wrapped object.
|
|
///
|
|
/// Returns `true` if `&self` has been revoked with this call, `false` if it was revoked
|
|
/// already.
|
|
pub fn revoke(&self) -> bool {
|
|
// SAFETY: By passing `true` we ask `revoke_internal` to wait for the grace period to
|
|
// finish.
|
|
unsafe { self.revoke_internal::<true>() }
|
|
}
|
|
}
|
|
|
|
#[pinned_drop]
|
|
impl<T> PinnedDrop for Revocable<T> {
|
|
fn drop(self: Pin<&mut Self>) {
|
|
// Drop only if the data hasn't been revoked yet (in which case it has already been
|
|
// dropped).
|
|
// SAFETY: We are not moving out of `p`, only dropping in place
|
|
let p = unsafe { self.get_unchecked_mut() };
|
|
if *p.is_available.get_mut() {
|
|
// SAFETY: We know `self.data` is valid because no other CPU has changed
|
|
// `is_available` to `false` yet, and no other CPU can do it anymore because this CPU
|
|
// holds the only reference (mutable) to `self` now.
|
|
unsafe { drop_in_place(p.data.get()) };
|
|
}
|
|
}
|
|
}
|
|
|
|
/// A guard that allows access to a revocable object and keeps it alive.
|
|
///
|
|
/// CPUs may not sleep while holding on to [`RevocableGuard`] because it's in atomic context
|
|
/// holding the RCU read-side lock.
|
|
///
|
|
/// # Invariants
|
|
///
|
|
/// The RCU read-side lock is held while the guard is alive.
|
|
pub struct RevocableGuard<'a, T> {
|
|
// This can't use the `&'a T` type because references that appear in function arguments must
|
|
// not become dangling during the execution of the function, which can happen if the
|
|
// `RevocableGuard` is passed as a function argument and then dropped during execution of the
|
|
// function.
|
|
data_ref: *const T,
|
|
_rcu_guard: rcu::Guard,
|
|
_p: PhantomData<&'a ()>,
|
|
}
|
|
|
|
impl<T> RevocableGuard<'_, T> {
|
|
fn new(data_ref: *const T, rcu_guard: rcu::Guard) -> Self {
|
|
Self {
|
|
data_ref,
|
|
_rcu_guard: rcu_guard,
|
|
_p: PhantomData,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<T> Deref for RevocableGuard<'_, T> {
|
|
type Target = T;
|
|
|
|
fn deref(&self) -> &Self::Target {
|
|
// SAFETY: By the type invariants, we hold the rcu read-side lock, so the object is
|
|
// guaranteed to remain valid.
|
|
unsafe { &*self.data_ref }
|
|
}
|
|
}
|