mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00

During ILA address translations, the L4 checksums can be handled in
different ways. One of them, adj-transport, consist in parsing the
transport layer and updating any found checksum. This logic relies on
inet_proto_csum_replace_by_diff and produces an incorrect skb->csum when
in state CHECKSUM_COMPLETE.
This bug can be reproduced with a simple ILA to SIR mapping, assuming
packets are received with CHECKSUM_COMPLETE:
$ ip a show dev eth0
14: eth0@if15: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
link/ether 62:ae:35:9e:0f:8d brd ff:ff:ff:ff:ff:ff link-netnsid 0
inet6 3333:0:0:1::c078/64 scope global
valid_lft forever preferred_lft forever
inet6 fd00:10:244:1::c078/128 scope global nodad
valid_lft forever preferred_lft forever
inet6 fe80::60ae:35ff:fe9e:f8d/64 scope link proto kernel_ll
valid_lft forever preferred_lft forever
$ ip ila add loc_match fd00:10:244:1 loc 3333:0:0:1 \
csum-mode adj-transport ident-type luid dev eth0
Then I hit [fd00:10:244:1::c078]:8000 with a server listening only on
[3333:0:0:1::c078]:8000. With the bug, the SYN packet is dropped with
SKB_DROP_REASON_TCP_CSUM after inet_proto_csum_replace_by_diff changed
skb->csum. The translation and drop are visible on pwru [1] traces:
IFACE TUPLE FUNC
eth0:9 [fd00:10:244:3::3d8]:51420->[fd00:10:244:1::c078]:8000(tcp) ipv6_rcv
eth0:9 [fd00:10:244:3::3d8]:51420->[fd00:10:244:1::c078]:8000(tcp) ip6_rcv_core
eth0:9 [fd00:10:244:3::3d8]:51420->[fd00:10:244:1::c078]:8000(tcp) nf_hook_slow
eth0:9 [fd00:10:244:3::3d8]:51420->[fd00:10:244:1::c078]:8000(tcp) inet_proto_csum_replace_by_diff
eth0:9 [fd00:10:244:3::3d8]:51420->[3333:0:0:1::c078]:8000(tcp) tcp_v6_early_demux
eth0:9 [fd00:10:244:3::3d8]:51420->[3333:0:0:1::c078]:8000(tcp) ip6_route_input
eth0:9 [fd00:10:244:3::3d8]:51420->[3333:0:0:1::c078]:8000(tcp) ip6_input
eth0:9 [fd00:10:244:3::3d8]:51420->[3333:0:0:1::c078]:8000(tcp) ip6_input_finish
eth0:9 [fd00:10:244:3::3d8]:51420->[3333:0:0:1::c078]:8000(tcp) ip6_protocol_deliver_rcu
eth0:9 [fd00:10:244:3::3d8]:51420->[3333:0:0:1::c078]:8000(tcp) raw6_local_deliver
eth0:9 [fd00:10:244:3::3d8]:51420->[3333:0:0:1::c078]:8000(tcp) ipv6_raw_deliver
eth0:9 [fd00:10:244:3::3d8]:51420->[3333:0:0:1::c078]:8000(tcp) tcp_v6_rcv
eth0:9 [fd00:10:244:3::3d8]:51420->[3333:0:0:1::c078]:8000(tcp) __skb_checksum_complete
eth0:9 [fd00:10:244:3::3d8]:51420->[3333:0:0:1::c078]:8000(tcp) kfree_skb_reason(SKB_DROP_REASON_TCP_CSUM)
eth0:9 [fd00:10:244:3::3d8]:51420->[3333:0:0:1::c078]:8000(tcp) skb_release_head_state
eth0:9 [fd00:10:244:3::3d8]:51420->[3333:0:0:1::c078]:8000(tcp) skb_release_data
eth0:9 [fd00:10:244:3::3d8]:51420->[3333:0:0:1::c078]:8000(tcp) skb_free_head
eth0:9 [fd00:10:244:3::3d8]:51420->[3333:0:0:1::c078]:8000(tcp) kfree_skbmem
This is happening because inet_proto_csum_replace_by_diff is updating
skb->csum when it shouldn't. The L4 checksum is updated such that it
"cancels" the IPv6 address change in terms of checksum computation, so
the impact on skb->csum is null.
Note this would be different for an IPv4 packet since three fields
would be updated: the IPv4 address, the IP checksum, and the L4
checksum. Two would cancel each other and skb->csum would still need
to be updated to take the L4 checksum change into account.
This patch fixes it by passing an ipv6 flag to
inet_proto_csum_replace_by_diff, to skip the skb->csum update if we're
in the IPv6 case. Note the behavior of the only other user of
inet_proto_csum_replace_by_diff, the BPF subsystem, is left as is in
this patch and fixed in the subsequent patch.
With the fix, using the reproduction from above, I can confirm
skb->csum is not touched by inet_proto_csum_replace_by_diff and the TCP
SYN proceeds to the application after the ILA translation.
Link: https://github.com/cilium/pwru [1]
Fixes: 65d7ab8de5
("net: Identifier Locator Addressing module")
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://patch.msgid.link/b5539869e3550d46068504feb02d37653d939c0b.1748509484.git.paul.chaignon@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
155 lines
3.8 KiB
C
155 lines
3.8 KiB
C
#include <linux/errno.h>
|
|
#include <linux/ip.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/socket.h>
|
|
#include <linux/types.h>
|
|
#include <net/checksum.h>
|
|
#include <net/ip.h>
|
|
#include <net/ip6_fib.h>
|
|
#include <net/lwtunnel.h>
|
|
#include <net/protocol.h>
|
|
#include <uapi/linux/ila.h>
|
|
#include "ila.h"
|
|
|
|
void ila_init_saved_csum(struct ila_params *p)
|
|
{
|
|
if (!p->locator_match.v64)
|
|
return;
|
|
|
|
p->csum_diff = compute_csum_diff8(
|
|
(__be32 *)&p->locator,
|
|
(__be32 *)&p->locator_match);
|
|
}
|
|
|
|
static __wsum get_csum_diff_iaddr(struct ila_addr *iaddr, struct ila_params *p)
|
|
{
|
|
if (p->locator_match.v64)
|
|
return p->csum_diff;
|
|
else
|
|
return compute_csum_diff8((__be32 *)&p->locator,
|
|
(__be32 *)&iaddr->loc);
|
|
}
|
|
|
|
static __wsum get_csum_diff(struct ipv6hdr *ip6h, struct ila_params *p)
|
|
{
|
|
return get_csum_diff_iaddr(ila_a2i(&ip6h->daddr), p);
|
|
}
|
|
|
|
static void ila_csum_do_neutral_fmt(struct ila_addr *iaddr,
|
|
struct ila_params *p)
|
|
{
|
|
__sum16 *adjust = (__force __sum16 *)&iaddr->ident.v16[3];
|
|
__wsum diff, fval;
|
|
|
|
diff = get_csum_diff_iaddr(iaddr, p);
|
|
|
|
fval = (__force __wsum)(ila_csum_neutral_set(iaddr->ident) ?
|
|
CSUM_NEUTRAL_FLAG : ~CSUM_NEUTRAL_FLAG);
|
|
|
|
diff = csum_add(diff, fval);
|
|
|
|
*adjust = ~csum_fold(csum_add(diff, csum_unfold(*adjust)));
|
|
|
|
/* Flip the csum-neutral bit. Either we are doing a SIR->ILA
|
|
* translation with ILA_CSUM_NEUTRAL_MAP as the csum_method
|
|
* and the C-bit is not set, or we are doing an ILA-SIR
|
|
* tranlsation and the C-bit is set.
|
|
*/
|
|
iaddr->ident.csum_neutral ^= 1;
|
|
}
|
|
|
|
static void ila_csum_do_neutral_nofmt(struct ila_addr *iaddr,
|
|
struct ila_params *p)
|
|
{
|
|
__sum16 *adjust = (__force __sum16 *)&iaddr->ident.v16[3];
|
|
__wsum diff;
|
|
|
|
diff = get_csum_diff_iaddr(iaddr, p);
|
|
|
|
*adjust = ~csum_fold(csum_add(diff, csum_unfold(*adjust)));
|
|
}
|
|
|
|
static void ila_csum_adjust_transport(struct sk_buff *skb,
|
|
struct ila_params *p)
|
|
{
|
|
size_t nhoff = sizeof(struct ipv6hdr);
|
|
struct ipv6hdr *ip6h = ipv6_hdr(skb);
|
|
__wsum diff;
|
|
|
|
switch (ip6h->nexthdr) {
|
|
case NEXTHDR_TCP:
|
|
if (likely(pskb_may_pull(skb, nhoff + sizeof(struct tcphdr)))) {
|
|
struct tcphdr *th = (struct tcphdr *)
|
|
(skb_network_header(skb) + nhoff);
|
|
|
|
diff = get_csum_diff(ip6h, p);
|
|
inet_proto_csum_replace_by_diff(&th->check, skb,
|
|
diff, true, true);
|
|
}
|
|
break;
|
|
case NEXTHDR_UDP:
|
|
if (likely(pskb_may_pull(skb, nhoff + sizeof(struct udphdr)))) {
|
|
struct udphdr *uh = (struct udphdr *)
|
|
(skb_network_header(skb) + nhoff);
|
|
|
|
if (uh->check || skb->ip_summed == CHECKSUM_PARTIAL) {
|
|
diff = get_csum_diff(ip6h, p);
|
|
inet_proto_csum_replace_by_diff(&uh->check, skb,
|
|
diff, true, true);
|
|
if (!uh->check)
|
|
uh->check = CSUM_MANGLED_0;
|
|
}
|
|
}
|
|
break;
|
|
case NEXTHDR_ICMP:
|
|
if (likely(pskb_may_pull(skb,
|
|
nhoff + sizeof(struct icmp6hdr)))) {
|
|
struct icmp6hdr *ih = (struct icmp6hdr *)
|
|
(skb_network_header(skb) + nhoff);
|
|
|
|
diff = get_csum_diff(ip6h, p);
|
|
inet_proto_csum_replace_by_diff(&ih->icmp6_cksum, skb,
|
|
diff, true, true);
|
|
}
|
|
break;
|
|
}
|
|
}
|
|
|
|
void ila_update_ipv6_locator(struct sk_buff *skb, struct ila_params *p,
|
|
bool sir2ila)
|
|
{
|
|
struct ipv6hdr *ip6h = ipv6_hdr(skb);
|
|
struct ila_addr *iaddr = ila_a2i(&ip6h->daddr);
|
|
|
|
switch (p->csum_mode) {
|
|
case ILA_CSUM_ADJUST_TRANSPORT:
|
|
ila_csum_adjust_transport(skb, p);
|
|
break;
|
|
case ILA_CSUM_NEUTRAL_MAP:
|
|
if (sir2ila) {
|
|
if (WARN_ON(ila_csum_neutral_set(iaddr->ident))) {
|
|
/* Checksum flag should never be
|
|
* set in a formatted SIR address.
|
|
*/
|
|
break;
|
|
}
|
|
} else if (!ila_csum_neutral_set(iaddr->ident)) {
|
|
/* ILA to SIR translation and C-bit isn't
|
|
* set so we're good.
|
|
*/
|
|
break;
|
|
}
|
|
ila_csum_do_neutral_fmt(iaddr, p);
|
|
break;
|
|
case ILA_CSUM_NEUTRAL_MAP_AUTO:
|
|
ila_csum_do_neutral_nofmt(iaddr, p);
|
|
break;
|
|
case ILA_CSUM_NO_ACTION:
|
|
break;
|
|
}
|
|
|
|
/* Now change destination address */
|
|
iaddr->loc = p->locator;
|
|
}
|