mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-05-24 10:39:52 +00:00

Kernel panic occurs when a devmem TCP socket is closed after NIC module
is unloaded.
This is Devmem TCP unregistration scenarios. number is an order.
(a)netlink socket close (b)pp destroy (c)uninstall result
1 2 3 OK
1 3 2 (d)Impossible
2 1 3 OK
3 1 2 (e)Kernel panic
2 3 1 (d)Impossible
3 2 1 (d)Impossible
(a) netdev_nl_sock_priv_destroy() is called when devmem TCP socket is
closed.
(b) page_pool_destroy() is called when the interface is down.
(c) mp_ops->uninstall() is called when an interface is unregistered.
(d) There is no scenario in mp_ops->uninstall() is called before
page_pool_destroy().
Because unregister_netdevice_many_notify() closes interfaces first
and then calls mp_ops->uninstall().
(e) netdev_nl_sock_priv_destroy() accesses struct net_device to acquire
netdev_lock().
But if the interface module has already been removed, net_device
pointer is invalid, so it causes kernel panic.
In summary, there are only 3 possible scenarios.
A. sk close -> pp destroy -> uninstall.
B. pp destroy -> sk close -> uninstall.
C. pp destroy -> uninstall -> sk close.
Case C is a kernel panic scenario.
In order to fix this problem, It makes mp_dmabuf_devmem_uninstall() set
binding->dev to NULL.
It indicates an bound net_device was unregistered.
It makes netdev_nl_sock_priv_destroy() do not acquire netdev_lock()
if binding->dev is NULL.
A new binding->lock is added to protect a dev of a binding.
So, lock ordering is like below.
priv->lock
netdev_lock(dev)
binding->lock
Tests:
Scenario A:
./ncdevmem -s 192.168.1.4 -c 192.168.1.2 -f $interface -l -p 8000 \
-v 7 -t 1 -q 1 &
pid=$!
sleep 10
kill $pid
ip link set $interface down
modprobe -rv $module
Scenario B:
./ncdevmem -s 192.168.1.4 -c 192.168.1.2 -f $interface -l -p 8000 \
-v 7 -t 1 -q 1 &
pid=$!
sleep 10
ip link set $interface down
kill $pid
modprobe -rv $module
Scenario C:
./ncdevmem -s 192.168.1.4 -c 192.168.1.2 -f $interface -l -p 8000 \
-v 7 -t 1 -q 1 &
pid=$!
sleep 10
modprobe -rv $module
sleep 5
kill $pid
Splat looks like:
Oops: general protection fault, probably for non-canonical address 0xdffffc001fffa9f7: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN NOPTI
KASAN: probably user-memory-access in range [0x00000000fffd4fb8-0x00000000fffd4fbf]
CPU: 0 UID: 0 PID: 2041 Comm: ncdevmem Tainted: G B W 6.15.0-rc1+ #2 PREEMPT(undef) 0947ec89efa0fd68838b78e36aa1617e97ff5d7f
Tainted: [B]=BAD_PAGE, [W]=WARN
RIP: 0010:__mutex_lock (./include/linux/sched.h:2244 kernel/locking/mutex.c:400 kernel/locking/mutex.c:443 kernel/locking/mutex.c:605 kernel/locking/mutex.c:746)
Code: ea 03 80 3c 02 00 0f 85 4f 13 00 00 49 8b 1e 48 83 e3 f8 74 6a 48 b8 00 00 00 00 00 fc ff df 48 8d 7b 34 48 89 fa 48 c1 ea 03 <0f> b6 f
RSP: 0018:ffff88826f7ef730 EFLAGS: 00010203
RAX: dffffc0000000000 RBX: 00000000fffd4f88 RCX: ffffffffaa9bc811
RDX: 000000001fffa9f7 RSI: 0000000000000008 RDI: 00000000fffd4fbc
RBP: ffff88826f7ef8b0 R08: 0000000000000000 R09: ffffed103e6aa1a4
R10: 0000000000000007 R11: ffff88826f7ef442 R12: fffffbfff669f65e
R13: ffff88812a830040 R14: ffff8881f3550d20 R15: 00000000fffd4f88
FS: 0000000000000000(0000) GS:ffff888866c05000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000563bed0cb288 CR3: 00000001a7c98000 CR4: 00000000007506f0
PKRU: 55555554
Call Trace:
<TASK>
...
netdev_nl_sock_priv_destroy (net/core/netdev-genl.c:953 (discriminator 3))
genl_release (net/netlink/genetlink.c:653 net/netlink/genetlink.c:694 net/netlink/genetlink.c:705)
...
netlink_release (net/netlink/af_netlink.c:737)
...
__sock_release (net/socket.c:647)
sock_close (net/socket.c:1393)
Fixes: 1d22d3060b
("net: drop rtnl_lock for queue_mgmt operations")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250514154028.1062909-1-ap420073@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
177 lines
4.4 KiB
C
177 lines
4.4 KiB
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Device memory TCP support
|
|
*
|
|
* Authors: Mina Almasry <almasrymina@google.com>
|
|
* Willem de Bruijn <willemb@google.com>
|
|
* Kaiyuan Zhang <kaiyuanz@google.com>
|
|
*
|
|
*/
|
|
#ifndef _NET_DEVMEM_H
|
|
#define _NET_DEVMEM_H
|
|
|
|
#include <net/netmem.h>
|
|
|
|
struct netlink_ext_ack;
|
|
|
|
struct net_devmem_dmabuf_binding {
|
|
struct dma_buf *dmabuf;
|
|
struct dma_buf_attachment *attachment;
|
|
struct sg_table *sgt;
|
|
struct net_device *dev;
|
|
struct gen_pool *chunk_pool;
|
|
/* Protect dev */
|
|
struct mutex lock;
|
|
|
|
/* The user holds a ref (via the netlink API) for as long as they want
|
|
* the binding to remain alive. Each page pool using this binding holds
|
|
* a ref to keep the binding alive. Each allocated net_iov holds a
|
|
* ref.
|
|
*
|
|
* The binding undos itself and unmaps the underlying dmabuf once all
|
|
* those refs are dropped and the binding is no longer desired or in
|
|
* use.
|
|
*/
|
|
refcount_t ref;
|
|
|
|
/* The list of bindings currently active. Used for netlink to notify us
|
|
* of the user dropping the bind.
|
|
*/
|
|
struct list_head list;
|
|
|
|
/* rxq's this binding is active on. */
|
|
struct xarray bound_rxqs;
|
|
|
|
/* ID of this binding. Globally unique to all bindings currently
|
|
* active.
|
|
*/
|
|
u32 id;
|
|
};
|
|
|
|
#if defined(CONFIG_NET_DEVMEM)
|
|
/* Owner of the dma-buf chunks inserted into the gen pool. Each scatterlist
|
|
* entry from the dmabuf is inserted into the genpool as a chunk, and needs
|
|
* this owner struct to keep track of some metadata necessary to create
|
|
* allocations from this chunk.
|
|
*/
|
|
struct dmabuf_genpool_chunk_owner {
|
|
struct net_iov_area area;
|
|
struct net_devmem_dmabuf_binding *binding;
|
|
|
|
/* dma_addr of the start of the chunk. */
|
|
dma_addr_t base_dma_addr;
|
|
};
|
|
|
|
void __net_devmem_dmabuf_binding_free(struct net_devmem_dmabuf_binding *binding);
|
|
struct net_devmem_dmabuf_binding *
|
|
net_devmem_bind_dmabuf(struct net_device *dev, unsigned int dmabuf_fd,
|
|
struct netlink_ext_ack *extack);
|
|
void net_devmem_unbind_dmabuf(struct net_devmem_dmabuf_binding *binding);
|
|
int net_devmem_bind_dmabuf_to_queue(struct net_device *dev, u32 rxq_idx,
|
|
struct net_devmem_dmabuf_binding *binding,
|
|
struct netlink_ext_ack *extack);
|
|
|
|
static inline struct dmabuf_genpool_chunk_owner *
|
|
net_devmem_iov_to_chunk_owner(const struct net_iov *niov)
|
|
{
|
|
struct net_iov_area *owner = net_iov_owner(niov);
|
|
|
|
return container_of(owner, struct dmabuf_genpool_chunk_owner, area);
|
|
}
|
|
|
|
static inline struct net_devmem_dmabuf_binding *
|
|
net_devmem_iov_binding(const struct net_iov *niov)
|
|
{
|
|
return net_devmem_iov_to_chunk_owner(niov)->binding;
|
|
}
|
|
|
|
static inline u32 net_devmem_iov_binding_id(const struct net_iov *niov)
|
|
{
|
|
return net_devmem_iov_binding(niov)->id;
|
|
}
|
|
|
|
static inline unsigned long net_iov_virtual_addr(const struct net_iov *niov)
|
|
{
|
|
struct net_iov_area *owner = net_iov_owner(niov);
|
|
|
|
return owner->base_virtual +
|
|
((unsigned long)net_iov_idx(niov) << PAGE_SHIFT);
|
|
}
|
|
|
|
static inline void
|
|
net_devmem_dmabuf_binding_get(struct net_devmem_dmabuf_binding *binding)
|
|
{
|
|
refcount_inc(&binding->ref);
|
|
}
|
|
|
|
static inline void
|
|
net_devmem_dmabuf_binding_put(struct net_devmem_dmabuf_binding *binding)
|
|
{
|
|
if (!refcount_dec_and_test(&binding->ref))
|
|
return;
|
|
|
|
__net_devmem_dmabuf_binding_free(binding);
|
|
}
|
|
|
|
struct net_iov *
|
|
net_devmem_alloc_dmabuf(struct net_devmem_dmabuf_binding *binding);
|
|
void net_devmem_free_dmabuf(struct net_iov *ppiov);
|
|
|
|
bool net_is_devmem_iov(struct net_iov *niov);
|
|
|
|
#else
|
|
struct net_devmem_dmabuf_binding;
|
|
|
|
static inline void
|
|
__net_devmem_dmabuf_binding_free(struct net_devmem_dmabuf_binding *binding)
|
|
{
|
|
}
|
|
|
|
static inline struct net_devmem_dmabuf_binding *
|
|
net_devmem_bind_dmabuf(struct net_device *dev, unsigned int dmabuf_fd,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
return ERR_PTR(-EOPNOTSUPP);
|
|
}
|
|
|
|
static inline void
|
|
net_devmem_unbind_dmabuf(struct net_devmem_dmabuf_binding *binding)
|
|
{
|
|
}
|
|
|
|
static inline int
|
|
net_devmem_bind_dmabuf_to_queue(struct net_device *dev, u32 rxq_idx,
|
|
struct net_devmem_dmabuf_binding *binding,
|
|
struct netlink_ext_ack *extack)
|
|
|
|
{
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
static inline struct net_iov *
|
|
net_devmem_alloc_dmabuf(struct net_devmem_dmabuf_binding *binding)
|
|
{
|
|
return NULL;
|
|
}
|
|
|
|
static inline void net_devmem_free_dmabuf(struct net_iov *ppiov)
|
|
{
|
|
}
|
|
|
|
static inline unsigned long net_iov_virtual_addr(const struct net_iov *niov)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline u32 net_devmem_iov_binding_id(const struct net_iov *niov)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline bool net_is_devmem_iov(struct net_iov *niov)
|
|
{
|
|
return false;
|
|
}
|
|
#endif
|
|
|
|
#endif /* _NET_DEVMEM_H */
|