mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-04-13 09:59:31 +00:00

Cosmin reports an issue with ipv6_add_dev being called from
NETDEV_CHANGE notifier:
[ 3455.008776] ? ipv6_add_dev+0x370/0x620
[ 3455.010097] ipv6_find_idev+0x96/0xe0
[ 3455.010725] addrconf_add_dev+0x1e/0xa0
[ 3455.011382] addrconf_init_auto_addrs+0xb0/0x720
[ 3455.013537] addrconf_notify+0x35f/0x8d0
[ 3455.014214] notifier_call_chain+0x38/0xf0
[ 3455.014903] netdev_state_change+0x65/0x90
[ 3455.015586] linkwatch_do_dev+0x5a/0x70
[ 3455.016238] rtnl_getlink+0x241/0x3e0
[ 3455.019046] rtnetlink_rcv_msg+0x177/0x5e0
Similarly, linkwatch might get to ipv6_add_dev without ops lock:
[ 3456.656261] ? ipv6_add_dev+0x370/0x620
[ 3456.660039] ipv6_find_idev+0x96/0xe0
[ 3456.660445] addrconf_add_dev+0x1e/0xa0
[ 3456.660861] addrconf_init_auto_addrs+0xb0/0x720
[ 3456.661803] addrconf_notify+0x35f/0x8d0
[ 3456.662236] notifier_call_chain+0x38/0xf0
[ 3456.662676] netdev_state_change+0x65/0x90
[ 3456.663112] linkwatch_do_dev+0x5a/0x70
[ 3456.663529] __linkwatch_run_queue+0xeb/0x200
[ 3456.663990] linkwatch_event+0x21/0x30
[ 3456.664399] process_one_work+0x211/0x610
[ 3456.664828] worker_thread+0x1cc/0x380
[ 3456.665691] kthread+0xf4/0x210
Reclassify NETDEV_CHANGE as a notifier that consistently runs under the
instance lock.
Link: https://lore.kernel.org/netdev/aac073de8beec3e531c86c101b274d434741c28e.camel@nvidia.com/
Reported-by: Cosmin Ratiu <cratiu@nvidia.com>
Tested-by: Cosmin Ratiu <cratiu@nvidia.com>
Fixes: ad7c7b2172
("net: hold netdev instance lock during sysfs operations")
Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250404161122.3907628-1-sdf@fomichev.me
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
345 lines
7.8 KiB
C
345 lines
7.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
#include <linux/netdevice.h>
|
|
#include <net/netdev_lock.h>
|
|
|
|
#include "dev.h"
|
|
|
|
/**
|
|
* dev_change_name() - change name of a device
|
|
* @dev: device
|
|
* @newname: name (or format string) must be at least IFNAMSIZ
|
|
*
|
|
* Change name of a device, can pass format strings "eth%d".
|
|
* for wildcarding.
|
|
*
|
|
* Return: 0 on success, -errno on failure.
|
|
*/
|
|
int dev_change_name(struct net_device *dev, const char *newname)
|
|
{
|
|
int ret;
|
|
|
|
netdev_lock_ops(dev);
|
|
ret = netif_change_name(dev, newname);
|
|
netdev_unlock_ops(dev);
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* dev_set_alias() - change ifalias of a device
|
|
* @dev: device
|
|
* @alias: name up to IFALIASZ
|
|
* @len: limit of bytes to copy from info
|
|
*
|
|
* Set ifalias for a device.
|
|
*
|
|
* Return: 0 on success, -errno on failure.
|
|
*/
|
|
int dev_set_alias(struct net_device *dev, const char *alias, size_t len)
|
|
{
|
|
int ret;
|
|
|
|
netdev_lock_ops(dev);
|
|
ret = netif_set_alias(dev, alias, len);
|
|
netdev_unlock_ops(dev);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(dev_set_alias);
|
|
|
|
/**
|
|
* dev_change_flags() - change device settings
|
|
* @dev: device
|
|
* @flags: device state flags
|
|
* @extack: netlink extended ack
|
|
*
|
|
* Change settings on device based state flags. The flags are
|
|
* in the userspace exported format.
|
|
*
|
|
* Return: 0 on success, -errno on failure.
|
|
*/
|
|
int dev_change_flags(struct net_device *dev, unsigned int flags,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
int ret;
|
|
|
|
netdev_lock_ops(dev);
|
|
ret = netif_change_flags(dev, flags, extack);
|
|
netdev_unlock_ops(dev);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(dev_change_flags);
|
|
|
|
/**
|
|
* dev_set_group() - change group this device belongs to
|
|
* @dev: device
|
|
* @new_group: group this device should belong to
|
|
*/
|
|
void dev_set_group(struct net_device *dev, int new_group)
|
|
{
|
|
netdev_lock_ops(dev);
|
|
netif_set_group(dev, new_group);
|
|
netdev_unlock_ops(dev);
|
|
}
|
|
|
|
int dev_set_mac_address_user(struct net_device *dev, struct sockaddr *sa,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
int ret;
|
|
|
|
down_write(&dev_addr_sem);
|
|
netdev_lock_ops(dev);
|
|
ret = netif_set_mac_address(dev, sa, extack);
|
|
netdev_unlock_ops(dev);
|
|
up_write(&dev_addr_sem);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(dev_set_mac_address_user);
|
|
|
|
/**
|
|
* dev_change_net_namespace() - move device to different nethost namespace
|
|
* @dev: device
|
|
* @net: network namespace
|
|
* @pat: If not NULL name pattern to try if the current device name
|
|
* is already taken in the destination network namespace.
|
|
*
|
|
* This function shuts down a device interface and moves it
|
|
* to a new network namespace. On success 0 is returned, on
|
|
* a failure a netagive errno code is returned.
|
|
*
|
|
* Callers must hold the rtnl semaphore.
|
|
*
|
|
* Return: 0 on success, -errno on failure.
|
|
*/
|
|
int dev_change_net_namespace(struct net_device *dev, struct net *net,
|
|
const char *pat)
|
|
{
|
|
return __dev_change_net_namespace(dev, net, pat, 0, NULL);
|
|
}
|
|
EXPORT_SYMBOL_GPL(dev_change_net_namespace);
|
|
|
|
/**
|
|
* dev_change_carrier() - change device carrier
|
|
* @dev: device
|
|
* @new_carrier: new value
|
|
*
|
|
* Change device carrier
|
|
*
|
|
* Return: 0 on success, -errno on failure.
|
|
*/
|
|
int dev_change_carrier(struct net_device *dev, bool new_carrier)
|
|
{
|
|
int ret;
|
|
|
|
netdev_lock_ops(dev);
|
|
ret = netif_change_carrier(dev, new_carrier);
|
|
netdev_unlock_ops(dev);
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* dev_change_tx_queue_len() - change TX queue length of a netdevice
|
|
* @dev: device
|
|
* @new_len: new tx queue length
|
|
*
|
|
* Return: 0 on success, -errno on failure.
|
|
*/
|
|
int dev_change_tx_queue_len(struct net_device *dev, unsigned long new_len)
|
|
{
|
|
int ret;
|
|
|
|
netdev_lock_ops(dev);
|
|
ret = netif_change_tx_queue_len(dev, new_len);
|
|
netdev_unlock_ops(dev);
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* dev_change_proto_down() - set carrier according to proto_down
|
|
* @dev: device
|
|
* @proto_down: new value
|
|
*
|
|
* Return: 0 on success, -errno on failure.
|
|
*/
|
|
int dev_change_proto_down(struct net_device *dev, bool proto_down)
|
|
{
|
|
int ret;
|
|
|
|
netdev_lock_ops(dev);
|
|
ret = netif_change_proto_down(dev, proto_down);
|
|
netdev_unlock_ops(dev);
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* dev_open() - prepare an interface for use
|
|
* @dev: device to open
|
|
* @extack: netlink extended ack
|
|
*
|
|
* Takes a device from down to up state. The device's private open
|
|
* function is invoked and then the multicast lists are loaded. Finally
|
|
* the device is moved into the up state and a %NETDEV_UP message is
|
|
* sent to the netdev notifier chain.
|
|
*
|
|
* Calling this function on an active interface is a nop. On a failure
|
|
* a negative errno code is returned.
|
|
*
|
|
* Return: 0 on success, -errno on failure.
|
|
*/
|
|
int dev_open(struct net_device *dev, struct netlink_ext_ack *extack)
|
|
{
|
|
int ret;
|
|
|
|
netdev_lock_ops(dev);
|
|
ret = netif_open(dev, extack);
|
|
netdev_unlock_ops(dev);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(dev_open);
|
|
|
|
/**
|
|
* dev_close() - shutdown an interface
|
|
* @dev: device to shutdown
|
|
*
|
|
* This function moves an active device into down state. A
|
|
* %NETDEV_GOING_DOWN is sent to the netdev notifier chain. The device
|
|
* is then deactivated and finally a %NETDEV_DOWN is sent to the notifier
|
|
* chain.
|
|
*/
|
|
void dev_close(struct net_device *dev)
|
|
{
|
|
netdev_lock_ops(dev);
|
|
netif_close(dev);
|
|
netdev_unlock_ops(dev);
|
|
}
|
|
EXPORT_SYMBOL(dev_close);
|
|
|
|
int dev_eth_ioctl(struct net_device *dev,
|
|
struct ifreq *ifr, unsigned int cmd)
|
|
{
|
|
const struct net_device_ops *ops = dev->netdev_ops;
|
|
int ret = -ENODEV;
|
|
|
|
if (!ops->ndo_eth_ioctl)
|
|
return -EOPNOTSUPP;
|
|
|
|
netdev_lock_ops(dev);
|
|
if (netif_device_present(dev))
|
|
ret = ops->ndo_eth_ioctl(dev, ifr, cmd);
|
|
netdev_unlock_ops(dev);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(dev_eth_ioctl);
|
|
|
|
int dev_set_mtu(struct net_device *dev, int new_mtu)
|
|
{
|
|
int ret;
|
|
|
|
netdev_lock_ops(dev);
|
|
ret = netif_set_mtu(dev, new_mtu);
|
|
netdev_unlock_ops(dev);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(dev_set_mtu);
|
|
|
|
/**
|
|
* dev_disable_lro() - disable Large Receive Offload on a device
|
|
* @dev: device
|
|
*
|
|
* Disable Large Receive Offload (LRO) on a net device. Must be
|
|
* called under RTNL. This is needed if received packets may be
|
|
* forwarded to another interface.
|
|
*/
|
|
void dev_disable_lro(struct net_device *dev)
|
|
{
|
|
netdev_lock_ops(dev);
|
|
netif_disable_lro(dev);
|
|
netdev_unlock_ops(dev);
|
|
}
|
|
EXPORT_SYMBOL(dev_disable_lro);
|
|
|
|
/**
|
|
* dev_set_allmulti() - update allmulti count on a device
|
|
* @dev: device
|
|
* @inc: modifier
|
|
*
|
|
* Add or remove reception of all multicast frames to a device. While the
|
|
* count in the device remains above zero the interface remains listening
|
|
* to all interfaces. Once it hits zero the device reverts back to normal
|
|
* filtering operation. A negative @inc value is used to drop the counter
|
|
* when releasing a resource needing all multicasts.
|
|
*
|
|
* Return: 0 on success, -errno on failure.
|
|
*/
|
|
|
|
int dev_set_allmulti(struct net_device *dev, int inc)
|
|
{
|
|
int ret;
|
|
|
|
netdev_lock_ops(dev);
|
|
ret = netif_set_allmulti(dev, inc, true);
|
|
netdev_unlock_ops(dev);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(dev_set_allmulti);
|
|
|
|
/**
|
|
* dev_set_mac_address() - change Media Access Control Address
|
|
* @dev: device
|
|
* @sa: new address
|
|
* @extack: netlink extended ack
|
|
*
|
|
* Change the hardware (MAC) address of the device
|
|
*
|
|
* Return: 0 on success, -errno on failure.
|
|
*/
|
|
int dev_set_mac_address(struct net_device *dev, struct sockaddr *sa,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
int ret;
|
|
|
|
netdev_lock_ops(dev);
|
|
ret = netif_set_mac_address(dev, sa, extack);
|
|
netdev_unlock_ops(dev);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(dev_set_mac_address);
|
|
|
|
int dev_xdp_propagate(struct net_device *dev, struct netdev_bpf *bpf)
|
|
{
|
|
int ret;
|
|
|
|
netdev_lock_ops(dev);
|
|
ret = netif_xdp_propagate(dev, bpf);
|
|
netdev_unlock_ops(dev);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL_GPL(dev_xdp_propagate);
|
|
|
|
/**
|
|
* netdev_state_change() - device changes state
|
|
* @dev: device to cause notification
|
|
*
|
|
* Called to indicate a device has changed state. This function calls
|
|
* the notifier chains for netdev_chain and sends a NEWLINK message
|
|
* to the routing socket.
|
|
*/
|
|
void netdev_state_change(struct net_device *dev)
|
|
{
|
|
netdev_lock_ops(dev);
|
|
netif_state_change(dev);
|
|
netdev_unlock_ops(dev);
|
|
}
|
|
EXPORT_SYMBOL(netdev_state_change);
|