mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00

devmem code performs a number of safety checks to avoid having
to reimplement all of them in the drivers. Move those to
__net_mp_open_rxq() and reuse that function for binding to make
sure that io_uring ZC also benefits from them.
While at it rename the queue ID variable to rxq_idx in
__net_mp_open_rxq(), we touch most of the relevant lines.
The XArray insertion is reordered after the netdev_rx_queue_restart()
call, otherwise we'd need to duplicate the queue index check
or risk inserting an invalid pointer. The XArray allocation
failures should be extremely rare.
Reviewed-by: Mina Almasry <almasrymina@google.com>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Fixes: 6e18ed929d
("net: add helpers for setting a memory provider on an rx queue")
Link: https://patch.msgid.link/20250403013405.2827250-2-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
51 lines
1.8 KiB
C
51 lines
1.8 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _NET_PAGE_POOL_MEMORY_PROVIDER_H
|
|
#define _NET_PAGE_POOL_MEMORY_PROVIDER_H
|
|
|
|
#include <net/netmem.h>
|
|
#include <net/page_pool/types.h>
|
|
|
|
struct netdev_rx_queue;
|
|
struct netlink_ext_ack;
|
|
struct sk_buff;
|
|
|
|
struct memory_provider_ops {
|
|
netmem_ref (*alloc_netmems)(struct page_pool *pool, gfp_t gfp);
|
|
bool (*release_netmem)(struct page_pool *pool, netmem_ref netmem);
|
|
int (*init)(struct page_pool *pool);
|
|
void (*destroy)(struct page_pool *pool);
|
|
int (*nl_fill)(void *mp_priv, struct sk_buff *rsp,
|
|
struct netdev_rx_queue *rxq);
|
|
void (*uninstall)(void *mp_priv, struct netdev_rx_queue *rxq);
|
|
};
|
|
|
|
bool net_mp_niov_set_dma_addr(struct net_iov *niov, dma_addr_t addr);
|
|
void net_mp_niov_set_page_pool(struct page_pool *pool, struct net_iov *niov);
|
|
void net_mp_niov_clear_page_pool(struct net_iov *niov);
|
|
|
|
int net_mp_open_rxq(struct net_device *dev, unsigned ifq_idx,
|
|
struct pp_memory_provider_params *p);
|
|
int __net_mp_open_rxq(struct net_device *dev, unsigned int rxq_idx,
|
|
const struct pp_memory_provider_params *p,
|
|
struct netlink_ext_ack *extack);
|
|
void net_mp_close_rxq(struct net_device *dev, unsigned ifq_idx,
|
|
struct pp_memory_provider_params *old_p);
|
|
void __net_mp_close_rxq(struct net_device *dev, unsigned int rxq_idx,
|
|
const struct pp_memory_provider_params *old_p);
|
|
|
|
/**
|
|
* net_mp_netmem_place_in_cache() - give a netmem to a page pool
|
|
* @pool: the page pool to place the netmem into
|
|
* @netmem: netmem to give
|
|
*
|
|
* Push an accounted netmem into the page pool's allocation cache. The caller
|
|
* must ensure that there is space in the cache. It should only be called off
|
|
* the mp_ops->alloc_netmems() path.
|
|
*/
|
|
static inline void net_mp_netmem_place_in_cache(struct page_pool *pool,
|
|
netmem_ref netmem)
|
|
{
|
|
pool->alloc.cache[pool->alloc.count++] = netmem;
|
|
}
|
|
|
|
#endif
|