public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-18 22:14:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
linux/fs/ceph
History
Exact
Max Kellermann 249e0a47cd ceph: fix crash after fscrypt_encrypt_pagecache_blocks() error 
The function move_dirty_folio_in_page_array() was created by commit
ce80b76dd3 ("ceph: introduce ceph_process_folio_batch() method") by
moving code from ceph_writepages_start() to this function.

This new function is supposed to return an error code which is checked
by the caller (now ceph_process_folio_batch()), and on error, the
caller invokes redirty_page_for_writepage() and then breaks from the
loop.

However, the refactoring commit has gone wrong, and it by accident, it
always returns 0 (= success) because it first NULLs the pointer and
then returns PTR_ERR(NULL) which is always 0.  This means errors are
silently ignored, leaving NULL entries in the page array, which may
later crash the kernel.

The simple solution is to call PTR_ERR() before clearing the pointer.

Cc: stable@vger.kernel.org
Fixes: ce80b76dd3 ("ceph: introduce ceph_process_folio_batch() method")
Link: https://lore.kernel.org/ceph-devel/aK4v548CId5GIKG1@swift.blarg.de/
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2025-09-09 12:57:03 +02:00
..
acl.c
addr.c ceph: fix crash after fscrypt_encrypt_pagecache_blocks() error 2025-09-09 12:57:03 +02:00
cache.c
cache.h
caps.c ceph: fix a race with rename() in ceph_mdsc_build_path() 2025-06-17 17:58:14 -04:00
ceph_frag.c
crypto.c fscrypt updates for 6.17 2025-07-28 18:07:38 -07:00
crypto.h fscrypt updates for 6.17 2025-07-28 18:07:38 -07:00
debugfs.c ceph: fix race condition validating r_parent before applying state 2025-09-09 12:57:02 +02:00
dir.c ceph: fix race condition validating r_parent before applying state 2025-09-09 12:57:02 +02:00
export.c ceph: cleanup hardcoded constants of file handle size 2025-06-01 17:53:16 +02:00
file.c ceph: fix race condition validating r_parent before applying state 2025-09-09 12:57:02 +02:00
inode.c ceph: fix race condition where r_parent becomes stale before sending message 2025-09-09 12:57:02 +02:00
io.c
io.h
ioctl.c
ioctl.h
Kconfig lib/crc: remove CONFIG_LIBCRC32C 2025-04-04 11:31:42 -07:00
locks.c
Makefile
mds_client.c ceph: fix race condition validating r_parent before applying state 2025-09-09 12:57:02 +02:00
mds_client.h ceph: fix race condition validating r_parent before applying state 2025-09-09 12:57:02 +02:00
mdsmap.c
mdsmap.h
metric.c
metric.h
quota.c ceph: convert timeouts to secs_to_jiffies() 2025-01-12 20:21:04 -08:00
snap.c
strings.c ceph: add getvxattr op 2022-03-01 18:26:37 +01:00
super.c new helper: set_default_d_op() 2025-06-10 22:21:16 -04:00
super.h fs: replace mmap hook with .mmap_prepare for simple mappings 2025-06-19 13:56:59 +02:00
util.c
xattr.c lsm: lsm_context in security_dentry_init_security 2024-12-04 14:58:51 -05:00