linux/drivers/net/phy/cortina.c
Christophe JAILLET b01b59a4fa net: phy: Constify struct mdio_device_id
'struct mdio_device_id' is not modified in these drivers.

Constifying these structures moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig, as an example:
Before:
======
   text	   data	    bss	    dec	    hex	filename
  27014	  12792	      0	  39806	   9b7e	drivers/net/phy/broadcom.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
  27206	  12600	      0	  39806	   9b7e	drivers/net/phy/broadcom.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/403c381b7d9156b67ad68ffc44b8eee70c5e86a9.1736691226.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2025-01-14 15:01:32 -08:00

99 lines
2.1 KiB
C

// SPDX-License-Identifier: GPL-2.0+
/*
* Copyright 2017 NXP
*
* CORTINA is a registered trademark of Cortina Systems, Inc.
*
*/
#include <linux/module.h>
#include <linux/phy.h>
#define PHY_ID_CS4340 0x13e51002
#define VILLA_GLOBAL_CHIP_ID_LSB 0x0
#define VILLA_GLOBAL_CHIP_ID_MSB 0x1
#define VILLA_GLOBAL_GPIO_1_INTS 0x017
static int cortina_read_reg(struct phy_device *phydev, u16 regnum)
{
return mdiobus_c45_read(phydev->mdio.bus, phydev->mdio.addr, 0, regnum);
}
static int cortina_read_status(struct phy_device *phydev)
{
int gpio_int_status, ret = 0;
gpio_int_status = cortina_read_reg(phydev, VILLA_GLOBAL_GPIO_1_INTS);
if (gpio_int_status < 0) {
ret = gpio_int_status;
goto err;
}
if (gpio_int_status & 0x8) {
/* up when edc_convergedS set */
phydev->speed = SPEED_10000;
phydev->duplex = DUPLEX_FULL;
phydev->link = 1;
} else {
phydev->link = 0;
}
err:
return ret;
}
static int cortina_probe(struct phy_device *phydev)
{
u32 phy_id = 0;
int id_lsb = 0, id_msb = 0;
/* Read device id from phy registers. */
id_lsb = cortina_read_reg(phydev, VILLA_GLOBAL_CHIP_ID_LSB);
if (id_lsb < 0)
return -ENXIO;
phy_id = id_lsb << 16;
id_msb = cortina_read_reg(phydev, VILLA_GLOBAL_CHIP_ID_MSB);
if (id_msb < 0)
return -ENXIO;
phy_id |= id_msb;
/* Make sure the device tree binding matched the driver with the
* right device.
*/
if (phy_id != phydev->drv->phy_id) {
phydev_err(phydev, "Error matching phy with %s driver\n",
phydev->drv->name);
return -ENODEV;
}
return 0;
}
static struct phy_driver cortina_driver[] = {
{
.phy_id = PHY_ID_CS4340,
.phy_id_mask = 0xffffffff,
.name = "Cortina CS4340",
.features = PHY_10GBIT_FEATURES,
.config_aneg = gen10g_config_aneg,
.read_status = cortina_read_status,
.probe = cortina_probe,
},
};
module_phy_driver(cortina_driver);
static const struct mdio_device_id __maybe_unused cortina_tbl[] = {
{ PHY_ID_CS4340, 0xffffffff},
{},
};
MODULE_DEVICE_TABLE(mdio, cortina_tbl);
MODULE_DESCRIPTION("Cortina EDC CDR 10G Ethernet PHY driver");
MODULE_AUTHOR("NXP");
MODULE_LICENSE("GPL");