mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00

Netlink ops do not expect all attributes to be always set, however
this condition is not explicitly coded any where, leading the user
to believe that all sent attributes are somewhat processed.
Fix this behaviour by introducing explicit checks.
For CMD_OVPN_PEER_GET and CMD_OVPN_KEY_GET directly open-code the
needed condition in the related ops handlers.
While for all other ops use attribute subsets in the ovpn.yaml spec file.
Fixes: b7a63391aa
("ovpn: add basic netlink support")
Reported-by: Ralf Lici <ralf@mandelbit.com>
Closes: https://github.com/OpenVPN/ovpn-net-next/issues/19
Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
262 lines
9.4 KiB
C
262 lines
9.4 KiB
C
// SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)
|
|
/* Do not edit directly, auto-generated from: */
|
|
/* Documentation/netlink/specs/ovpn.yaml */
|
|
/* YNL-GEN kernel source */
|
|
|
|
#include <net/netlink.h>
|
|
#include <net/genetlink.h>
|
|
|
|
#include "netlink-gen.h"
|
|
|
|
#include <uapi/linux/ovpn.h>
|
|
|
|
/* Integer value ranges */
|
|
static const struct netlink_range_validation ovpn_a_peer_id_range = {
|
|
.max = 16777215ULL,
|
|
};
|
|
|
|
static const struct netlink_range_validation ovpn_a_keyconf_peer_id_range = {
|
|
.max = 16777215ULL,
|
|
};
|
|
|
|
/* Common nested types */
|
|
const struct nla_policy ovpn_keyconf_nl_policy[OVPN_A_KEYCONF_DECRYPT_DIR + 1] = {
|
|
[OVPN_A_KEYCONF_PEER_ID] = NLA_POLICY_FULL_RANGE(NLA_U32, &ovpn_a_keyconf_peer_id_range),
|
|
[OVPN_A_KEYCONF_SLOT] = NLA_POLICY_MAX(NLA_U32, 1),
|
|
[OVPN_A_KEYCONF_KEY_ID] = NLA_POLICY_MAX(NLA_U32, 7),
|
|
[OVPN_A_KEYCONF_CIPHER_ALG] = NLA_POLICY_MAX(NLA_U32, 2),
|
|
[OVPN_A_KEYCONF_ENCRYPT_DIR] = NLA_POLICY_NESTED(ovpn_keydir_nl_policy),
|
|
[OVPN_A_KEYCONF_DECRYPT_DIR] = NLA_POLICY_NESTED(ovpn_keydir_nl_policy),
|
|
};
|
|
|
|
const struct nla_policy ovpn_keyconf_del_input_nl_policy[OVPN_A_KEYCONF_SLOT + 1] = {
|
|
[OVPN_A_KEYCONF_PEER_ID] = NLA_POLICY_FULL_RANGE(NLA_U32, &ovpn_a_keyconf_peer_id_range),
|
|
[OVPN_A_KEYCONF_SLOT] = NLA_POLICY_MAX(NLA_U32, 1),
|
|
};
|
|
|
|
const struct nla_policy ovpn_keyconf_get_nl_policy[OVPN_A_KEYCONF_CIPHER_ALG + 1] = {
|
|
[OVPN_A_KEYCONF_PEER_ID] = NLA_POLICY_FULL_RANGE(NLA_U32, &ovpn_a_keyconf_peer_id_range),
|
|
[OVPN_A_KEYCONF_SLOT] = NLA_POLICY_MAX(NLA_U32, 1),
|
|
[OVPN_A_KEYCONF_KEY_ID] = NLA_POLICY_MAX(NLA_U32, 7),
|
|
[OVPN_A_KEYCONF_CIPHER_ALG] = NLA_POLICY_MAX(NLA_U32, 2),
|
|
};
|
|
|
|
const struct nla_policy ovpn_keyconf_swap_input_nl_policy[OVPN_A_KEYCONF_PEER_ID + 1] = {
|
|
[OVPN_A_KEYCONF_PEER_ID] = NLA_POLICY_FULL_RANGE(NLA_U32, &ovpn_a_keyconf_peer_id_range),
|
|
};
|
|
|
|
const struct nla_policy ovpn_keydir_nl_policy[OVPN_A_KEYDIR_NONCE_TAIL + 1] = {
|
|
[OVPN_A_KEYDIR_CIPHER_KEY] = NLA_POLICY_MAX_LEN(256),
|
|
[OVPN_A_KEYDIR_NONCE_TAIL] = NLA_POLICY_EXACT_LEN(OVPN_NONCE_TAIL_SIZE),
|
|
};
|
|
|
|
const struct nla_policy ovpn_peer_nl_policy[OVPN_A_PEER_LINK_TX_PACKETS + 1] = {
|
|
[OVPN_A_PEER_ID] = NLA_POLICY_FULL_RANGE(NLA_U32, &ovpn_a_peer_id_range),
|
|
[OVPN_A_PEER_REMOTE_IPV4] = { .type = NLA_BE32, },
|
|
[OVPN_A_PEER_REMOTE_IPV6] = NLA_POLICY_EXACT_LEN(16),
|
|
[OVPN_A_PEER_REMOTE_IPV6_SCOPE_ID] = { .type = NLA_U32, },
|
|
[OVPN_A_PEER_REMOTE_PORT] = NLA_POLICY_MIN(NLA_BE16, 1),
|
|
[OVPN_A_PEER_SOCKET] = { .type = NLA_U32, },
|
|
[OVPN_A_PEER_SOCKET_NETNSID] = { .type = NLA_S32, },
|
|
[OVPN_A_PEER_VPN_IPV4] = { .type = NLA_BE32, },
|
|
[OVPN_A_PEER_VPN_IPV6] = NLA_POLICY_EXACT_LEN(16),
|
|
[OVPN_A_PEER_LOCAL_IPV4] = { .type = NLA_BE32, },
|
|
[OVPN_A_PEER_LOCAL_IPV6] = NLA_POLICY_EXACT_LEN(16),
|
|
[OVPN_A_PEER_LOCAL_PORT] = NLA_POLICY_MIN(NLA_BE16, 1),
|
|
[OVPN_A_PEER_KEEPALIVE_INTERVAL] = { .type = NLA_U32, },
|
|
[OVPN_A_PEER_KEEPALIVE_TIMEOUT] = { .type = NLA_U32, },
|
|
[OVPN_A_PEER_DEL_REASON] = NLA_POLICY_MAX(NLA_U32, 4),
|
|
[OVPN_A_PEER_VPN_RX_BYTES] = { .type = NLA_UINT, },
|
|
[OVPN_A_PEER_VPN_TX_BYTES] = { .type = NLA_UINT, },
|
|
[OVPN_A_PEER_VPN_RX_PACKETS] = { .type = NLA_UINT, },
|
|
[OVPN_A_PEER_VPN_TX_PACKETS] = { .type = NLA_UINT, },
|
|
[OVPN_A_PEER_LINK_RX_BYTES] = { .type = NLA_UINT, },
|
|
[OVPN_A_PEER_LINK_TX_BYTES] = { .type = NLA_UINT, },
|
|
[OVPN_A_PEER_LINK_RX_PACKETS] = { .type = NLA_UINT, },
|
|
[OVPN_A_PEER_LINK_TX_PACKETS] = { .type = NLA_UINT, },
|
|
};
|
|
|
|
const struct nla_policy ovpn_peer_del_input_nl_policy[OVPN_A_PEER_ID + 1] = {
|
|
[OVPN_A_PEER_ID] = NLA_POLICY_FULL_RANGE(NLA_U32, &ovpn_a_peer_id_range),
|
|
};
|
|
|
|
const struct nla_policy ovpn_peer_new_input_nl_policy[OVPN_A_PEER_KEEPALIVE_TIMEOUT + 1] = {
|
|
[OVPN_A_PEER_ID] = NLA_POLICY_FULL_RANGE(NLA_U32, &ovpn_a_peer_id_range),
|
|
[OVPN_A_PEER_REMOTE_IPV4] = { .type = NLA_BE32, },
|
|
[OVPN_A_PEER_REMOTE_IPV6] = NLA_POLICY_EXACT_LEN(16),
|
|
[OVPN_A_PEER_REMOTE_IPV6_SCOPE_ID] = { .type = NLA_U32, },
|
|
[OVPN_A_PEER_REMOTE_PORT] = NLA_POLICY_MIN(NLA_BE16, 1),
|
|
[OVPN_A_PEER_SOCKET] = { .type = NLA_U32, },
|
|
[OVPN_A_PEER_VPN_IPV4] = { .type = NLA_BE32, },
|
|
[OVPN_A_PEER_VPN_IPV6] = NLA_POLICY_EXACT_LEN(16),
|
|
[OVPN_A_PEER_LOCAL_IPV4] = { .type = NLA_BE32, },
|
|
[OVPN_A_PEER_LOCAL_IPV6] = NLA_POLICY_EXACT_LEN(16),
|
|
[OVPN_A_PEER_KEEPALIVE_INTERVAL] = { .type = NLA_U32, },
|
|
[OVPN_A_PEER_KEEPALIVE_TIMEOUT] = { .type = NLA_U32, },
|
|
};
|
|
|
|
const struct nla_policy ovpn_peer_set_input_nl_policy[OVPN_A_PEER_KEEPALIVE_TIMEOUT + 1] = {
|
|
[OVPN_A_PEER_ID] = NLA_POLICY_FULL_RANGE(NLA_U32, &ovpn_a_peer_id_range),
|
|
[OVPN_A_PEER_REMOTE_IPV4] = { .type = NLA_BE32, },
|
|
[OVPN_A_PEER_REMOTE_IPV6] = NLA_POLICY_EXACT_LEN(16),
|
|
[OVPN_A_PEER_REMOTE_IPV6_SCOPE_ID] = { .type = NLA_U32, },
|
|
[OVPN_A_PEER_REMOTE_PORT] = NLA_POLICY_MIN(NLA_BE16, 1),
|
|
[OVPN_A_PEER_VPN_IPV4] = { .type = NLA_BE32, },
|
|
[OVPN_A_PEER_VPN_IPV6] = NLA_POLICY_EXACT_LEN(16),
|
|
[OVPN_A_PEER_LOCAL_IPV4] = { .type = NLA_BE32, },
|
|
[OVPN_A_PEER_LOCAL_IPV6] = NLA_POLICY_EXACT_LEN(16),
|
|
[OVPN_A_PEER_KEEPALIVE_INTERVAL] = { .type = NLA_U32, },
|
|
[OVPN_A_PEER_KEEPALIVE_TIMEOUT] = { .type = NLA_U32, },
|
|
};
|
|
|
|
/* OVPN_CMD_PEER_NEW - do */
|
|
static const struct nla_policy ovpn_peer_new_nl_policy[OVPN_A_PEER + 1] = {
|
|
[OVPN_A_IFINDEX] = { .type = NLA_U32, },
|
|
[OVPN_A_PEER] = NLA_POLICY_NESTED(ovpn_peer_new_input_nl_policy),
|
|
};
|
|
|
|
/* OVPN_CMD_PEER_SET - do */
|
|
static const struct nla_policy ovpn_peer_set_nl_policy[OVPN_A_PEER + 1] = {
|
|
[OVPN_A_IFINDEX] = { .type = NLA_U32, },
|
|
[OVPN_A_PEER] = NLA_POLICY_NESTED(ovpn_peer_set_input_nl_policy),
|
|
};
|
|
|
|
/* OVPN_CMD_PEER_GET - do */
|
|
static const struct nla_policy ovpn_peer_get_do_nl_policy[OVPN_A_PEER + 1] = {
|
|
[OVPN_A_IFINDEX] = { .type = NLA_U32, },
|
|
[OVPN_A_PEER] = NLA_POLICY_NESTED(ovpn_peer_nl_policy),
|
|
};
|
|
|
|
/* OVPN_CMD_PEER_GET - dump */
|
|
static const struct nla_policy ovpn_peer_get_dump_nl_policy[OVPN_A_IFINDEX + 1] = {
|
|
[OVPN_A_IFINDEX] = { .type = NLA_U32, },
|
|
};
|
|
|
|
/* OVPN_CMD_PEER_DEL - do */
|
|
static const struct nla_policy ovpn_peer_del_nl_policy[OVPN_A_PEER + 1] = {
|
|
[OVPN_A_IFINDEX] = { .type = NLA_U32, },
|
|
[OVPN_A_PEER] = NLA_POLICY_NESTED(ovpn_peer_del_input_nl_policy),
|
|
};
|
|
|
|
/* OVPN_CMD_KEY_NEW - do */
|
|
static const struct nla_policy ovpn_key_new_nl_policy[OVPN_A_KEYCONF + 1] = {
|
|
[OVPN_A_IFINDEX] = { .type = NLA_U32, },
|
|
[OVPN_A_KEYCONF] = NLA_POLICY_NESTED(ovpn_keyconf_nl_policy),
|
|
};
|
|
|
|
/* OVPN_CMD_KEY_GET - do */
|
|
static const struct nla_policy ovpn_key_get_nl_policy[OVPN_A_KEYCONF + 1] = {
|
|
[OVPN_A_IFINDEX] = { .type = NLA_U32, },
|
|
[OVPN_A_KEYCONF] = NLA_POLICY_NESTED(ovpn_keyconf_get_nl_policy),
|
|
};
|
|
|
|
/* OVPN_CMD_KEY_SWAP - do */
|
|
static const struct nla_policy ovpn_key_swap_nl_policy[OVPN_A_KEYCONF + 1] = {
|
|
[OVPN_A_IFINDEX] = { .type = NLA_U32, },
|
|
[OVPN_A_KEYCONF] = NLA_POLICY_NESTED(ovpn_keyconf_swap_input_nl_policy),
|
|
};
|
|
|
|
/* OVPN_CMD_KEY_DEL - do */
|
|
static const struct nla_policy ovpn_key_del_nl_policy[OVPN_A_KEYCONF + 1] = {
|
|
[OVPN_A_IFINDEX] = { .type = NLA_U32, },
|
|
[OVPN_A_KEYCONF] = NLA_POLICY_NESTED(ovpn_keyconf_del_input_nl_policy),
|
|
};
|
|
|
|
/* Ops table for ovpn */
|
|
static const struct genl_split_ops ovpn_nl_ops[] = {
|
|
{
|
|
.cmd = OVPN_CMD_PEER_NEW,
|
|
.pre_doit = ovpn_nl_pre_doit,
|
|
.doit = ovpn_nl_peer_new_doit,
|
|
.post_doit = ovpn_nl_post_doit,
|
|
.policy = ovpn_peer_new_nl_policy,
|
|
.maxattr = OVPN_A_PEER,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = OVPN_CMD_PEER_SET,
|
|
.pre_doit = ovpn_nl_pre_doit,
|
|
.doit = ovpn_nl_peer_set_doit,
|
|
.post_doit = ovpn_nl_post_doit,
|
|
.policy = ovpn_peer_set_nl_policy,
|
|
.maxattr = OVPN_A_PEER,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = OVPN_CMD_PEER_GET,
|
|
.pre_doit = ovpn_nl_pre_doit,
|
|
.doit = ovpn_nl_peer_get_doit,
|
|
.post_doit = ovpn_nl_post_doit,
|
|
.policy = ovpn_peer_get_do_nl_policy,
|
|
.maxattr = OVPN_A_PEER,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = OVPN_CMD_PEER_GET,
|
|
.dumpit = ovpn_nl_peer_get_dumpit,
|
|
.policy = ovpn_peer_get_dump_nl_policy,
|
|
.maxattr = OVPN_A_IFINDEX,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DUMP,
|
|
},
|
|
{
|
|
.cmd = OVPN_CMD_PEER_DEL,
|
|
.pre_doit = ovpn_nl_pre_doit,
|
|
.doit = ovpn_nl_peer_del_doit,
|
|
.post_doit = ovpn_nl_post_doit,
|
|
.policy = ovpn_peer_del_nl_policy,
|
|
.maxattr = OVPN_A_PEER,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = OVPN_CMD_KEY_NEW,
|
|
.pre_doit = ovpn_nl_pre_doit,
|
|
.doit = ovpn_nl_key_new_doit,
|
|
.post_doit = ovpn_nl_post_doit,
|
|
.policy = ovpn_key_new_nl_policy,
|
|
.maxattr = OVPN_A_KEYCONF,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = OVPN_CMD_KEY_GET,
|
|
.pre_doit = ovpn_nl_pre_doit,
|
|
.doit = ovpn_nl_key_get_doit,
|
|
.post_doit = ovpn_nl_post_doit,
|
|
.policy = ovpn_key_get_nl_policy,
|
|
.maxattr = OVPN_A_KEYCONF,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = OVPN_CMD_KEY_SWAP,
|
|
.pre_doit = ovpn_nl_pre_doit,
|
|
.doit = ovpn_nl_key_swap_doit,
|
|
.post_doit = ovpn_nl_post_doit,
|
|
.policy = ovpn_key_swap_nl_policy,
|
|
.maxattr = OVPN_A_KEYCONF,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = OVPN_CMD_KEY_DEL,
|
|
.pre_doit = ovpn_nl_pre_doit,
|
|
.doit = ovpn_nl_key_del_doit,
|
|
.post_doit = ovpn_nl_post_doit,
|
|
.policy = ovpn_key_del_nl_policy,
|
|
.maxattr = OVPN_A_KEYCONF,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
};
|
|
|
|
static const struct genl_multicast_group ovpn_nl_mcgrps[] = {
|
|
[OVPN_NLGRP_PEERS] = { "peers", },
|
|
};
|
|
|
|
struct genl_family ovpn_nl_family __ro_after_init = {
|
|
.name = OVPN_FAMILY_NAME,
|
|
.version = OVPN_FAMILY_VERSION,
|
|
.netnsok = true,
|
|
.parallel_ops = true,
|
|
.module = THIS_MODULE,
|
|
.split_ops = ovpn_nl_ops,
|
|
.n_split_ops = ARRAY_SIZE(ovpn_nl_ops),
|
|
.mcgrps = ovpn_nl_mcgrps,
|
|
.n_mcgrps = ARRAY_SIZE(ovpn_nl_mcgrps),
|
|
};
|