mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
9f22c3ddb8
lpc18xx uses plat_dat->mac_interface, despite wanting to validate the PHY interface. Checking the DT files (arch/arm/boot/dts/nxp/lpc/), none of them specify mac-mode which means mac_interface and phy_interface will be identical. mac_interface is only used when there is some kind of MII converter between the DesignWare MAC and PHY, and describes the interface mode that the DW MAC needs to use, whereas phy_interface describes the interface mode that the PHY uses. Noting that lpc18xx only supports MII and RMII interface modes, switch this glue driver to use plat_dat->phy_interface, and to mark that the mac_interface is not used, explicitly set it to PHY_INTERFACE_MODE_NA. The latter is safe as the only user of mac_interface for this platform would be in stmmac_check_pcs_mode(), which only checks for RGMII or SGMII. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Yanteng Si <siyanteng@cqsoftware.com.cn> Link: https://patch.msgid.link/E1uSBri-004fL5-FI@rmk-PC.armlinux.org.uk Signed-off-by: Jakub Kicinski <kuba@kernel.org>
87 lines
2.4 KiB
C
87 lines
2.4 KiB
C
/*
|
|
* DWMAC glue for NXP LPC18xx/LPC43xx Ethernet
|
|
*
|
|
* Copyright (C) 2015 Joachim Eastwood <manabian@gmail.com>
|
|
*
|
|
* This file is licensed under the terms of the GNU General Public
|
|
* License version 2. This program is licensed "as is" without any
|
|
* warranty of any kind, whether express or implied.
|
|
*/
|
|
|
|
#include <linux/mfd/syscon.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_net.h>
|
|
#include <linux/phy.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/stmmac.h>
|
|
|
|
#include "stmmac_platform.h"
|
|
|
|
/* Register defines for CREG syscon */
|
|
#define LPC18XX_CREG_CREG6 0x12c
|
|
# define LPC18XX_CREG_CREG6_ETHMODE_MASK 0x7
|
|
# define LPC18XX_CREG_CREG6_ETHMODE_MII 0x0
|
|
# define LPC18XX_CREG_CREG6_ETHMODE_RMII 0x4
|
|
|
|
static int lpc18xx_dwmac_probe(struct platform_device *pdev)
|
|
{
|
|
struct plat_stmmacenet_data *plat_dat;
|
|
struct stmmac_resources stmmac_res;
|
|
struct regmap *reg;
|
|
u8 ethmode;
|
|
int ret;
|
|
|
|
ret = stmmac_get_platform_resources(pdev, &stmmac_res);
|
|
if (ret)
|
|
return ret;
|
|
|
|
plat_dat = devm_stmmac_probe_config_dt(pdev, stmmac_res.mac);
|
|
if (IS_ERR(plat_dat))
|
|
return PTR_ERR(plat_dat);
|
|
|
|
plat_dat->mac_interface = PHY_INTERFACE_MODE_NA;
|
|
plat_dat->has_gmac = true;
|
|
|
|
reg = syscon_regmap_lookup_by_compatible("nxp,lpc1850-creg");
|
|
if (IS_ERR(reg)) {
|
|
dev_err(&pdev->dev, "syscon lookup failed\n");
|
|
return PTR_ERR(reg);
|
|
}
|
|
|
|
if (plat_dat->phy_interface == PHY_INTERFACE_MODE_MII) {
|
|
ethmode = LPC18XX_CREG_CREG6_ETHMODE_MII;
|
|
} else if (plat_dat->phy_interface == PHY_INTERFACE_MODE_RMII) {
|
|
ethmode = LPC18XX_CREG_CREG6_ETHMODE_RMII;
|
|
} else {
|
|
dev_err(&pdev->dev, "Only MII and RMII mode supported\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
regmap_update_bits(reg, LPC18XX_CREG_CREG6,
|
|
LPC18XX_CREG_CREG6_ETHMODE_MASK, ethmode);
|
|
|
|
return stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res);
|
|
}
|
|
|
|
static const struct of_device_id lpc18xx_dwmac_match[] = {
|
|
{ .compatible = "nxp,lpc1850-dwmac" },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, lpc18xx_dwmac_match);
|
|
|
|
static struct platform_driver lpc18xx_dwmac_driver = {
|
|
.probe = lpc18xx_dwmac_probe,
|
|
.remove = stmmac_pltfr_remove,
|
|
.driver = {
|
|
.name = "lpc18xx-dwmac",
|
|
.pm = &stmmac_pltfr_pm_ops,
|
|
.of_match_table = lpc18xx_dwmac_match,
|
|
},
|
|
};
|
|
module_platform_driver(lpc18xx_dwmac_driver);
|
|
|
|
MODULE_AUTHOR("Joachim Eastwood <manabian@gmail.com>");
|
|
MODULE_DESCRIPTION("DWMAC glue for LPC18xx/43xx Ethernet");
|
|
MODULE_LICENSE("GPL v2");
|