mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00

Remove the write to GMAC_1US_TIC_COUNTER for two reasons:
1. during initialisation or reinitialisation of the DWMAC core, the
core is reset, which sets this register back to its default value.
Writing it prior to stmmac_dvr_probe() has no effect.
2. Since commit 8efbdbfa99
("net: stmmac: Initialize
MAC_ONEUS_TIC_COUNTER register"), GMAC4/5 core code will set
this register based on the rate of plat->stmmac_clk. This clock
is fetched by devm_stmmac_probe_config_dt(), and plat->clk_ptp_rate
will be set to its rate profided a "ptp_ref" clock is not provided.
In any case, Marek's commit will set the effectual value of this
register.
Therefore, dwmac-intel-plat.c writing GMAC_1US_TIC_COUNTER serves no
useful purpose and can be removed.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1u3Vuq-000E7s-5Y@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
151 lines
3.6 KiB
C
151 lines
3.6 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
||
/* Intel DWMAC platform driver
|
||
*
|
||
* Copyright(C) 2020 Intel Corporation
|
||
*/
|
||
|
||
#include <linux/ethtool.h>
|
||
#include <linux/module.h>
|
||
#include <linux/of.h>
|
||
#include <linux/platform_device.h>
|
||
#include <linux/property.h>
|
||
#include <linux/stmmac.h>
|
||
|
||
#include "dwmac4.h"
|
||
#include "stmmac.h"
|
||
#include "stmmac_platform.h"
|
||
|
||
struct intel_dwmac {
|
||
struct device *dev;
|
||
struct clk *tx_clk;
|
||
const struct intel_dwmac_data *data;
|
||
};
|
||
|
||
struct intel_dwmac_data {
|
||
unsigned long ptp_ref_clk_rate;
|
||
unsigned long tx_clk_rate;
|
||
bool tx_clk_en;
|
||
};
|
||
|
||
static const struct intel_dwmac_data kmb_data = {
|
||
.ptp_ref_clk_rate = 200000000,
|
||
.tx_clk_rate = 125000000,
|
||
.tx_clk_en = true,
|
||
};
|
||
|
||
static const struct of_device_id intel_eth_plat_match[] = {
|
||
{ .compatible = "intel,keembay-dwmac", .data = &kmb_data },
|
||
{ }
|
||
};
|
||
MODULE_DEVICE_TABLE(of, intel_eth_plat_match);
|
||
|
||
static int intel_eth_plat_probe(struct platform_device *pdev)
|
||
{
|
||
struct plat_stmmacenet_data *plat_dat;
|
||
struct stmmac_resources stmmac_res;
|
||
struct intel_dwmac *dwmac;
|
||
unsigned long rate;
|
||
int ret;
|
||
|
||
ret = stmmac_get_platform_resources(pdev, &stmmac_res);
|
||
if (ret)
|
||
return ret;
|
||
|
||
plat_dat = devm_stmmac_probe_config_dt(pdev, stmmac_res.mac);
|
||
if (IS_ERR(plat_dat)) {
|
||
dev_err(&pdev->dev, "dt configuration failed\n");
|
||
return PTR_ERR(plat_dat);
|
||
}
|
||
|
||
dwmac = devm_kzalloc(&pdev->dev, sizeof(*dwmac), GFP_KERNEL);
|
||
if (!dwmac)
|
||
return -ENOMEM;
|
||
|
||
dwmac->dev = &pdev->dev;
|
||
dwmac->tx_clk = NULL;
|
||
|
||
/*
|
||
* This cannot return NULL at this point because the driver’s
|
||
* compatibility with the device has already been validated in
|
||
* platform_match().
|
||
*/
|
||
dwmac->data = device_get_match_data(&pdev->dev);
|
||
|
||
/* Enable TX clock */
|
||
if (dwmac->data->tx_clk_en) {
|
||
dwmac->tx_clk = devm_clk_get(&pdev->dev, "tx_clk");
|
||
if (IS_ERR(dwmac->tx_clk))
|
||
return PTR_ERR(dwmac->tx_clk);
|
||
|
||
ret = clk_prepare_enable(dwmac->tx_clk);
|
||
if (ret) {
|
||
dev_err(&pdev->dev,
|
||
"Failed to enable tx_clk\n");
|
||
return ret;
|
||
}
|
||
|
||
/* Check and configure TX clock rate */
|
||
rate = clk_get_rate(dwmac->tx_clk);
|
||
if (dwmac->data->tx_clk_rate &&
|
||
rate != dwmac->data->tx_clk_rate) {
|
||
rate = dwmac->data->tx_clk_rate;
|
||
ret = clk_set_rate(dwmac->tx_clk, rate);
|
||
if (ret) {
|
||
dev_err(&pdev->dev,
|
||
"Failed to set tx_clk\n");
|
||
goto err_tx_clk_disable;
|
||
}
|
||
}
|
||
|
||
/* Check and configure PTP ref clock rate */
|
||
rate = clk_get_rate(plat_dat->clk_ptp_ref);
|
||
if (dwmac->data->ptp_ref_clk_rate &&
|
||
rate != dwmac->data->ptp_ref_clk_rate) {
|
||
rate = dwmac->data->ptp_ref_clk_rate;
|
||
ret = clk_set_rate(plat_dat->clk_ptp_ref, rate);
|
||
if (ret) {
|
||
dev_err(&pdev->dev,
|
||
"Failed to set clk_ptp_ref\n");
|
||
goto err_tx_clk_disable;
|
||
}
|
||
}
|
||
}
|
||
|
||
plat_dat->clk_tx_i = dwmac->tx_clk;
|
||
plat_dat->set_clk_tx_rate = stmmac_set_clk_tx_rate;
|
||
plat_dat->bsp_priv = dwmac;
|
||
|
||
ret = stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res);
|
||
if (ret)
|
||
goto err_tx_clk_disable;
|
||
|
||
return 0;
|
||
|
||
err_tx_clk_disable:
|
||
if (dwmac->data->tx_clk_en)
|
||
clk_disable_unprepare(dwmac->tx_clk);
|
||
return ret;
|
||
}
|
||
|
||
static void intel_eth_plat_remove(struct platform_device *pdev)
|
||
{
|
||
struct intel_dwmac *dwmac = get_stmmac_bsp_priv(&pdev->dev);
|
||
|
||
stmmac_pltfr_remove(pdev);
|
||
if (dwmac->data->tx_clk_en)
|
||
clk_disable_unprepare(dwmac->tx_clk);
|
||
}
|
||
|
||
static struct platform_driver intel_eth_plat_driver = {
|
||
.probe = intel_eth_plat_probe,
|
||
.remove = intel_eth_plat_remove,
|
||
.driver = {
|
||
.name = "intel-eth-plat",
|
||
.pm = &stmmac_pltfr_pm_ops,
|
||
.of_match_table = intel_eth_plat_match,
|
||
},
|
||
};
|
||
module_platform_driver(intel_eth_plat_driver);
|
||
|
||
MODULE_LICENSE("GPL v2");
|
||
MODULE_DESCRIPTION("Intel DWMAC platform driver");
|