mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
6c14058edf
New timestamping API was introduced in commit 66f7223039 ("net: add
NDOs for configuring hardware timestamping") from kernel v6.6. It is
time to convert DSA to the new API, so that the ndo_eth_ioctl() path can
be removed completely.
Move the ds->ops->port_hwtstamp_get() and ds->ops->port_hwtstamp_set()
calls from dsa_user_ioctl() to dsa_user_hwtstamp_get() and
dsa_user_hwtstamp_set().
Due to the fact that the underlying ifreq type changes to
kernel_hwtstamp_config, the drivers and the Ocelot switchdev front-end,
all hooked up directly or indirectly, must also be converted all at once.
The conversion also updates the comment from dsa_port_supports_hwtstamp(),
which is no longer true because kernel_hwtstamp_config is kernel memory
and does not need copy_to_user(). I've deliberated whether it is
necessary to also update "err != -EOPNOTSUPP" to a more general "!err",
but all drivers now either return 0 or -EOPNOTSUPP.
The existing logic from the ocelot_ioctl() function, to avoid
configuring timestamping if the PHY supports the operation, is obsoleted
by more advanced core logic in dev_set_hwtstamp_phylib().
This is only a partial preparation for proper PHY timestamping support.
None of these switch driver currently sets up PTP traps for PHY
timestamping, so setting dev->see_all_hwtstamp_requests is not yet
necessary and the conversion is relatively trivial.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com> # felix, sja1105, mv88e6xxx
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20250508095236.887789-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
59 lines
1.9 KiB
C
59 lines
1.9 KiB
C
/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
|
|
/*
|
|
* DSA driver for:
|
|
* Hirschmann Hellcreek TSN switch.
|
|
*
|
|
* Copyright (C) 2019,2020 Hochschule Offenburg
|
|
* Copyright (C) 2019,2020 Linutronix GmbH
|
|
* Authors: Kurt Kanzenbach <kurt@linutronix.de>
|
|
* Kamil Alkhouri <kamil.alkhouri@hs-offenburg.de>
|
|
*/
|
|
|
|
#ifndef _HELLCREEK_HWTSTAMP_H_
|
|
#define _HELLCREEK_HWTSTAMP_H_
|
|
|
|
#include <net/dsa.h>
|
|
#include "hellcreek.h"
|
|
|
|
/* Timestamp Register */
|
|
#define PR_TS_RX_P1_STATUS_C (0x1d * 2)
|
|
#define PR_TS_RX_P1_DATA_C (0x1e * 2)
|
|
#define PR_TS_TX_P1_STATUS_C (0x1f * 2)
|
|
#define PR_TS_TX_P1_DATA_C (0x20 * 2)
|
|
#define PR_TS_RX_P2_STATUS_C (0x25 * 2)
|
|
#define PR_TS_RX_P2_DATA_C (0x26 * 2)
|
|
#define PR_TS_TX_P2_STATUS_C (0x27 * 2)
|
|
#define PR_TS_TX_P2_DATA_C (0x28 * 2)
|
|
|
|
#define PR_TS_STATUS_TS_AVAIL BIT(2)
|
|
#define PR_TS_STATUS_TS_LOST BIT(3)
|
|
|
|
#define SKB_PTP_TYPE(__skb) (*(unsigned int *)((__skb)->cb))
|
|
|
|
/* TX_TSTAMP_TIMEOUT: This limits the time spent polling for a TX
|
|
* timestamp. When working properly, hardware will produce a timestamp
|
|
* within 1ms. Software may enounter delays, so the timeout is set
|
|
* accordingly.
|
|
*/
|
|
#define TX_TSTAMP_TIMEOUT msecs_to_jiffies(40)
|
|
|
|
int hellcreek_port_hwtstamp_set(struct dsa_switch *ds, int port,
|
|
struct kernel_hwtstamp_config *config,
|
|
struct netlink_ext_ack *extack);
|
|
int hellcreek_port_hwtstamp_get(struct dsa_switch *ds, int port,
|
|
struct kernel_hwtstamp_config *config);
|
|
|
|
bool hellcreek_port_rxtstamp(struct dsa_switch *ds, int port,
|
|
struct sk_buff *clone, unsigned int type);
|
|
void hellcreek_port_txtstamp(struct dsa_switch *ds, int port,
|
|
struct sk_buff *skb);
|
|
|
|
int hellcreek_get_ts_info(struct dsa_switch *ds, int port,
|
|
struct kernel_ethtool_ts_info *info);
|
|
|
|
long hellcreek_hwtstamp_work(struct ptp_clock_info *ptp);
|
|
|
|
int hellcreek_hwtstamp_setup(struct hellcreek *chip);
|
|
void hellcreek_hwtstamp_free(struct hellcreek *chip);
|
|
|
|
#endif /* _HELLCREEK_HWTSTAMP_H_ */
|