mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
e9bb2eacc7
During the probe() routine, the PiSP BE driver needs to power up the
interface in order to identify and initialize the hardware.
The driver resumes the interface by calling the
pispbe_runtime_resume() function directly, without going
through the pm_runtime helpers, but later suspends it by calling
pm_runtime_put_autosuspend().
This causes a PM usage count imbalance at probe time, notified by the
runtime_pm framework with the below message in the system log:
pispbe 1000880000.pisp_be: Runtime PM usage count underflow!
Fix this by resuming the interface using the pm runtime helpers instead
of calling the resume function directly and use the pm_runtime framework
in the probe() error path. While at it, remove manual suspend of the
interface in the remove() function. The driver cannot be unloaded if in
use, so simply disable runtime pm.
To simplify the implementation, make the driver depend on PM as the
RPI5 platform where the ISP is integrated in uses the PM framework by
default.
Fixes: 12187bd5d4 ("media: raspberrypi: Add support for PiSP BE")
Cc: stable@vger.kernel.org
Tested-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
14 lines
451 B
Text
14 lines
451 B
Text
config VIDEO_RASPBERRYPI_PISP_BE
|
|
tristate "Raspberry Pi PiSP Backend (BE) ISP driver"
|
|
depends on V4L_PLATFORM_DRIVERS
|
|
depends on VIDEO_DEV
|
|
depends on ARCH_BCM2835 || COMPILE_TEST
|
|
depends on PM
|
|
select VIDEO_V4L2_SUBDEV_API
|
|
select MEDIA_CONTROLLER
|
|
select VIDEOBUF2_DMA_CONTIG
|
|
help
|
|
Say Y here to enable support for the PiSP Backend (BE) ISP driver.
|
|
|
|
To compile this driver as a module, choose M here. The module will be
|
|
called pisp-be.
|