mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00

The 'icc_bw_lock' mutex is introduced in commitaf42269c35
("interconnect: Fix locking for runpm vs reclaim") in order to decouple serialization of bw aggregation from codepaths that require memory allocation. However commitd30f83d278
("interconnect: core: Add dynamic id allocation support") added a devm_kasprintf() call into a path protected by the 'icc_bw_lock' which causes the following lockdep warning on machines like the Lenovo ThinkPad X13s: ====================================================== WARNING: possible circular locking dependency detected 6.16.0-rc3 #15 Not tainted ------------------------------------------------------ (udev-worker)/342 is trying to acquire lock: ffffb973f7ec4638 (fs_reclaim){+.+.}-{0:0}, at: __kmalloc_node_track_caller_noprof+0xa0/0x3e0 but task is already holding lock: ffffb973f7f7f0e8 (icc_bw_lock){+.+.}-{4:4}, at: icc_node_add+0x44/0x154 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (icc_bw_lock){+.+.}-{4:4}: icc_init+0x48/0x108 do_one_initcall+0x64/0x30c kernel_init_freeable+0x27c/0x500 kernel_init+0x20/0x1d8 ret_from_fork+0x10/0x20 -> #0 (fs_reclaim){+.+.}-{0:0}: __lock_acquire+0x136c/0x2114 lock_acquire+0x1c8/0x354 fs_reclaim_acquire+0x74/0xa8 __kmalloc_node_track_caller_noprof+0xa0/0x3e0 devm_kmalloc+0x54/0x124 devm_kvasprintf+0x74/0xd4 devm_kasprintf+0x58/0x80 icc_node_add+0xb4/0x154 qcom_osm_l3_probe+0x20c/0x314 [icc_osm_l3] platform_probe+0x68/0xd8 really_probe+0xc0/0x38c __driver_probe_device+0x7c/0x160 driver_probe_device+0x40/0x110 __driver_attach+0xfc/0x208 bus_for_each_dev+0x74/0xd0 driver_attach+0x24/0x30 bus_add_driver+0x110/0x234 driver_register+0x60/0x128 __platform_driver_register+0x24/0x30 osm_l3_driver_init+0x20/0x1000 [icc_osm_l3] do_one_initcall+0x64/0x30c do_init_module+0x58/0x23c load_module+0x1df8/0x1f70 init_module_from_file+0x88/0xc4 idempotent_init_module+0x188/0x280 __arm64_sys_finit_module+0x6c/0xd8 invoke_syscall+0x48/0x110 el0_svc_common.constprop.0+0xc0/0xe0 do_el0_svc+0x1c/0x28 el0_svc+0x4c/0x158 el0t_64_sync_handler+0xc8/0xcc el0t_64_sync+0x198/0x19c other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(icc_bw_lock); lock(fs_reclaim); lock(icc_bw_lock); lock(fs_reclaim); *** DEADLOCK *** The icc_node_add() functions is not designed to fail, and as such it should not do any memory allocation. In order to avoid this, add a new helper function for the name generation to be called by drivers which are using the new dynamic id feature. Fixes:d30f83d278
("interconnect: core: Add dynamic id allocation support") Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> Link: https://lore.kernel.org/r/20250625-icc-bw-lockdep-v3-1-2b8f8b8987c4@gmail.com Co-developed-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Link: https://lore.kernel.org/r/20250627075854.26943-1-johan+linaro@kernel.org Signed-off-by: Georgi Djakov <djakov@kernel.org>
294 lines
7.3 KiB
C
294 lines
7.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
|
|
* Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved.
|
|
*/
|
|
|
|
#include <linux/args.h>
|
|
#include <linux/bitfield.h>
|
|
#include <linux/clk.h>
|
|
#include <linux/interconnect-provider.h>
|
|
#include <linux/io.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <dt-bindings/interconnect/qcom,osm-l3.h>
|
|
|
|
#define LUT_MAX_ENTRIES 40U
|
|
#define LUT_SRC GENMASK(31, 30)
|
|
#define LUT_L_VAL GENMASK(7, 0)
|
|
#define CLK_HW_DIV 2
|
|
|
|
/* OSM Register offsets */
|
|
#define REG_ENABLE 0x0
|
|
#define OSM_LUT_ROW_SIZE 32
|
|
#define OSM_REG_FREQ_LUT 0x110
|
|
#define OSM_REG_PERF_STATE 0x920
|
|
|
|
/* EPSS Register offsets */
|
|
#define EPSS_LUT_ROW_SIZE 4
|
|
#define EPSS_REG_L3_VOTE 0x90
|
|
#define EPSS_REG_FREQ_LUT 0x100
|
|
#define EPSS_REG_PERF_STATE 0x320
|
|
|
|
#define to_osm_l3_provider(_provider) \
|
|
container_of(_provider, struct qcom_osm_l3_icc_provider, provider)
|
|
|
|
struct qcom_osm_l3_icc_provider {
|
|
void __iomem *base;
|
|
unsigned int max_state;
|
|
unsigned int reg_perf_state;
|
|
unsigned long lut_tables[LUT_MAX_ENTRIES];
|
|
struct icc_provider provider;
|
|
};
|
|
|
|
/**
|
|
* struct qcom_osm_l3_node - Qualcomm specific interconnect nodes
|
|
* @name: the node name used in debugfs
|
|
* @buswidth: width of the interconnect between a node and the bus
|
|
*/
|
|
struct qcom_osm_l3_node {
|
|
const char *name;
|
|
u16 buswidth;
|
|
};
|
|
|
|
struct qcom_osm_l3_desc {
|
|
const struct qcom_osm_l3_node * const *nodes;
|
|
size_t num_nodes;
|
|
unsigned int lut_row_size;
|
|
unsigned int reg_freq_lut;
|
|
unsigned int reg_perf_state;
|
|
};
|
|
|
|
#define DEFINE_QNODE(_name, _buswidth) \
|
|
static const struct qcom_osm_l3_node _name = { \
|
|
.name = #_name, \
|
|
.buswidth = _buswidth, \
|
|
}
|
|
|
|
DEFINE_QNODE(osm_l3_slave, 16);
|
|
DEFINE_QNODE(osm_l3_master, 16);
|
|
|
|
static const struct qcom_osm_l3_node * const osm_l3_nodes[] = {
|
|
[MASTER_OSM_L3_APPS] = &osm_l3_master,
|
|
[SLAVE_OSM_L3] = &osm_l3_slave,
|
|
};
|
|
|
|
DEFINE_QNODE(epss_l3_slave, 32);
|
|
DEFINE_QNODE(epss_l3_master, 32);
|
|
|
|
static const struct qcom_osm_l3_node * const epss_l3_nodes[] = {
|
|
[MASTER_EPSS_L3_APPS] = &epss_l3_master,
|
|
[SLAVE_EPSS_L3_SHARED] = &epss_l3_slave,
|
|
};
|
|
|
|
static const struct qcom_osm_l3_desc osm_l3 = {
|
|
.nodes = osm_l3_nodes,
|
|
.num_nodes = ARRAY_SIZE(osm_l3_nodes),
|
|
.lut_row_size = OSM_LUT_ROW_SIZE,
|
|
.reg_freq_lut = OSM_REG_FREQ_LUT,
|
|
.reg_perf_state = OSM_REG_PERF_STATE,
|
|
};
|
|
|
|
static const struct qcom_osm_l3_desc epss_l3_perf_state = {
|
|
.nodes = epss_l3_nodes,
|
|
.num_nodes = ARRAY_SIZE(epss_l3_nodes),
|
|
.lut_row_size = EPSS_LUT_ROW_SIZE,
|
|
.reg_freq_lut = EPSS_REG_FREQ_LUT,
|
|
.reg_perf_state = EPSS_REG_PERF_STATE,
|
|
};
|
|
|
|
static const struct qcom_osm_l3_desc epss_l3_l3_vote = {
|
|
.nodes = epss_l3_nodes,
|
|
.num_nodes = ARRAY_SIZE(epss_l3_nodes),
|
|
.lut_row_size = EPSS_LUT_ROW_SIZE,
|
|
.reg_freq_lut = EPSS_REG_FREQ_LUT,
|
|
.reg_perf_state = EPSS_REG_L3_VOTE,
|
|
};
|
|
|
|
static int qcom_osm_l3_set(struct icc_node *src, struct icc_node *dst)
|
|
{
|
|
struct qcom_osm_l3_icc_provider *qp;
|
|
struct icc_provider *provider;
|
|
const struct qcom_osm_l3_node *qn;
|
|
unsigned int index;
|
|
u64 rate;
|
|
|
|
qn = src->data;
|
|
provider = src->provider;
|
|
qp = to_osm_l3_provider(provider);
|
|
|
|
rate = icc_units_to_bps(dst->peak_bw);
|
|
do_div(rate, qn->buswidth);
|
|
|
|
for (index = 0; index < qp->max_state - 1; index++) {
|
|
if (qp->lut_tables[index] >= rate)
|
|
break;
|
|
}
|
|
|
|
writel_relaxed(index, qp->base + qp->reg_perf_state);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void qcom_osm_l3_remove(struct platform_device *pdev)
|
|
{
|
|
struct qcom_osm_l3_icc_provider *qp = platform_get_drvdata(pdev);
|
|
|
|
icc_provider_deregister(&qp->provider);
|
|
icc_nodes_remove(&qp->provider);
|
|
}
|
|
|
|
static int qcom_osm_l3_probe(struct platform_device *pdev)
|
|
{
|
|
u32 info, src, lval, i, prev_freq = 0, freq;
|
|
static unsigned long hw_rate, xo_rate;
|
|
struct qcom_osm_l3_icc_provider *qp;
|
|
const struct qcom_osm_l3_desc *desc;
|
|
struct icc_onecell_data *data;
|
|
struct icc_provider *provider;
|
|
const struct qcom_osm_l3_node * const *qnodes;
|
|
struct icc_node *node;
|
|
size_t num_nodes;
|
|
struct clk *clk;
|
|
int ret;
|
|
|
|
clk = clk_get(&pdev->dev, "xo");
|
|
if (IS_ERR(clk))
|
|
return PTR_ERR(clk);
|
|
|
|
xo_rate = clk_get_rate(clk);
|
|
clk_put(clk);
|
|
|
|
clk = clk_get(&pdev->dev, "alternate");
|
|
if (IS_ERR(clk))
|
|
return PTR_ERR(clk);
|
|
|
|
hw_rate = clk_get_rate(clk) / CLK_HW_DIV;
|
|
clk_put(clk);
|
|
|
|
qp = devm_kzalloc(&pdev->dev, sizeof(*qp), GFP_KERNEL);
|
|
if (!qp)
|
|
return -ENOMEM;
|
|
|
|
qp->base = devm_platform_ioremap_resource(pdev, 0);
|
|
if (IS_ERR(qp->base))
|
|
return PTR_ERR(qp->base);
|
|
|
|
/* HW should be in enabled state to proceed */
|
|
if (!(readl_relaxed(qp->base + REG_ENABLE) & 0x1)) {
|
|
dev_err(&pdev->dev, "error hardware not enabled\n");
|
|
return -ENODEV;
|
|
}
|
|
|
|
desc = device_get_match_data(&pdev->dev);
|
|
if (!desc)
|
|
return -EINVAL;
|
|
|
|
qp->reg_perf_state = desc->reg_perf_state;
|
|
|
|
for (i = 0; i < LUT_MAX_ENTRIES; i++) {
|
|
info = readl_relaxed(qp->base + desc->reg_freq_lut +
|
|
i * desc->lut_row_size);
|
|
src = FIELD_GET(LUT_SRC, info);
|
|
lval = FIELD_GET(LUT_L_VAL, info);
|
|
if (src)
|
|
freq = xo_rate * lval;
|
|
else
|
|
freq = hw_rate;
|
|
|
|
/* Two of the same frequencies signify end of table */
|
|
if (i > 0 && prev_freq == freq)
|
|
break;
|
|
|
|
dev_dbg(&pdev->dev, "index=%d freq=%d\n", i, freq);
|
|
|
|
qp->lut_tables[i] = freq;
|
|
prev_freq = freq;
|
|
}
|
|
qp->max_state = i;
|
|
|
|
qnodes = desc->nodes;
|
|
num_nodes = desc->num_nodes;
|
|
|
|
data = devm_kzalloc(&pdev->dev, struct_size(data, nodes, num_nodes), GFP_KERNEL);
|
|
if (!data)
|
|
return -ENOMEM;
|
|
data->num_nodes = num_nodes;
|
|
|
|
provider = &qp->provider;
|
|
provider->dev = &pdev->dev;
|
|
provider->set = qcom_osm_l3_set;
|
|
provider->aggregate = icc_std_aggregate;
|
|
provider->xlate = of_icc_xlate_onecell;
|
|
provider->data = data;
|
|
|
|
icc_provider_init(provider);
|
|
|
|
/* Create nodes */
|
|
for (i = 0; i < num_nodes; i++) {
|
|
node = icc_node_create_dyn();
|
|
|
|
if (IS_ERR(node)) {
|
|
ret = PTR_ERR(node);
|
|
goto err;
|
|
}
|
|
|
|
ret = icc_node_set_name(node, provider, qnodes[i]->name);
|
|
if (ret) {
|
|
icc_node_destroy(node->id);
|
|
goto err;
|
|
}
|
|
|
|
/* Cast away const and add it back in qcom_osm_l3_set() */
|
|
node->data = (void *)qnodes[i];
|
|
icc_node_add(node, provider);
|
|
|
|
data->nodes[i] = node;
|
|
}
|
|
|
|
/* Create link */
|
|
icc_link_nodes(data->nodes[MASTER_OSM_L3_APPS], &data->nodes[SLAVE_OSM_L3]);
|
|
|
|
ret = icc_provider_register(provider);
|
|
if (ret)
|
|
goto err;
|
|
|
|
platform_set_drvdata(pdev, qp);
|
|
|
|
return 0;
|
|
err:
|
|
icc_nodes_remove(provider);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static const struct of_device_id osm_l3_of_match[] = {
|
|
{ .compatible = "qcom,epss-l3", .data = &epss_l3_l3_vote },
|
|
{ .compatible = "qcom,osm-l3", .data = &osm_l3 },
|
|
{ .compatible = "qcom,sa8775p-epss-l3", .data = &epss_l3_perf_state },
|
|
{ .compatible = "qcom,sc7180-osm-l3", .data = &osm_l3 },
|
|
{ .compatible = "qcom,sc7280-epss-l3", .data = &epss_l3_perf_state },
|
|
{ .compatible = "qcom,sdm845-osm-l3", .data = &osm_l3 },
|
|
{ .compatible = "qcom,sm8150-osm-l3", .data = &osm_l3 },
|
|
{ .compatible = "qcom,sc8180x-osm-l3", .data = &osm_l3 },
|
|
{ .compatible = "qcom,sm8250-epss-l3", .data = &epss_l3_perf_state },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, osm_l3_of_match);
|
|
|
|
static struct platform_driver osm_l3_driver = {
|
|
.probe = qcom_osm_l3_probe,
|
|
.remove = qcom_osm_l3_remove,
|
|
.driver = {
|
|
.name = "osm-l3",
|
|
.of_match_table = osm_l3_of_match,
|
|
.sync_state = icc_sync_state,
|
|
},
|
|
};
|
|
module_platform_driver(osm_l3_driver);
|
|
|
|
MODULE_DESCRIPTION("Qualcomm OSM L3 interconnect driver");
|
|
MODULE_LICENSE("GPL v2");
|