mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
b4b42f28a0
write_event_config callback use an int for state, but it is actually a
boolean. iio_ev_state_store is actually using kstrtobool to check user
input, then gives the converted boolean value to write_event_config.
Fix signature and update all iio drivers to use the new signature.
This patch has been partially written using coccinelle with the
following script:
$ cat iio-bool.cocci
// Options: --all-includes
virtual patch
@c1@
identifier iioinfo;
identifier wecfunc;
@@
static const struct iio_info iioinfo = {
...,
.write_event_config =
(
wecfunc
|
&wecfunc
),
...,
};
@@
identifier c1.wecfunc;
identifier indio_dev, chan, type, dir, state;
@@
int wecfunc(struct iio_dev *indio_dev, const struct iio_chan_spec *chan, enum iio_event_type type, enum iio_event_direction dir,
-int
+bool
state) {
...
}
make coccicheck MODE=patch COCCI=iio-bool.cocci M=drivers/iio
Unfortunately, this script didn't match all files:
* all write_event_config callbacks using iio_device_claim_direct_scoped
were not detected and not patched.
* all files that do not assign and declare the write_event_config
callback in the same file.
iio.h was also manually updated.
The patch was build tested using allmodconfig config.
cc: Julia Lawall <julia.lawall@inria.fr>
Signed-off-by: Julien Stephan <jstephan@baylibre.com>
Link: https://patch.msgid.link/20241031-iio-fix-write-event-config-signature-v2-7-2bcacbb517a2@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
126 lines
3.6 KiB
C
126 lines
3.6 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/**
|
|
* Copyright (c) 2011 Jonathan Cameron
|
|
*
|
|
* Join together the various functionality of iio_simple_dummy driver
|
|
*/
|
|
|
|
#ifndef _IIO_SIMPLE_DUMMY_H_
|
|
#define _IIO_SIMPLE_DUMMY_H_
|
|
#include <linux/kernel.h>
|
|
|
|
struct iio_dummy_accel_calibscale;
|
|
struct iio_dummy_regs;
|
|
|
|
/**
|
|
* struct iio_dummy_state - device instance specific state.
|
|
* @dac_val: cache for dac value
|
|
* @single_ended_adc_val: cache for single ended adc value
|
|
* @differential_adc_val: cache for differential adc value
|
|
* @accel_val: cache for acceleration value
|
|
* @accel_calibbias: cache for acceleration calibbias
|
|
* @accel_calibscale: cache for acceleration calibscale
|
|
* @lock: lock to ensure state is consistent
|
|
* @event_irq: irq number for event line (faked)
|
|
* @event_val: cache for event threshold value
|
|
* @event_en: cache of whether event is enabled
|
|
*/
|
|
struct iio_dummy_state {
|
|
int dac_val;
|
|
int single_ended_adc_val;
|
|
int differential_adc_val[2];
|
|
int accel_val;
|
|
int accel_calibbias;
|
|
int activity_running;
|
|
int activity_walking;
|
|
const struct iio_dummy_accel_calibscale *accel_calibscale;
|
|
struct mutex lock;
|
|
struct iio_dummy_regs *regs;
|
|
int steps_enabled;
|
|
int steps;
|
|
int height;
|
|
#ifdef CONFIG_IIO_SIMPLE_DUMMY_EVENTS
|
|
int event_irq;
|
|
int event_val;
|
|
bool event_en;
|
|
s64 event_timestamp;
|
|
#endif /* CONFIG_IIO_SIMPLE_DUMMY_EVENTS */
|
|
};
|
|
|
|
#ifdef CONFIG_IIO_SIMPLE_DUMMY_EVENTS
|
|
|
|
struct iio_dev;
|
|
|
|
int iio_simple_dummy_read_event_config(struct iio_dev *indio_dev,
|
|
const struct iio_chan_spec *chan,
|
|
enum iio_event_type type,
|
|
enum iio_event_direction dir);
|
|
|
|
int iio_simple_dummy_write_event_config(struct iio_dev *indio_dev,
|
|
const struct iio_chan_spec *chan,
|
|
enum iio_event_type type,
|
|
enum iio_event_direction dir,
|
|
bool state);
|
|
|
|
int iio_simple_dummy_read_event_value(struct iio_dev *indio_dev,
|
|
const struct iio_chan_spec *chan,
|
|
enum iio_event_type type,
|
|
enum iio_event_direction dir,
|
|
enum iio_event_info info, int *val,
|
|
int *val2);
|
|
|
|
int iio_simple_dummy_write_event_value(struct iio_dev *indio_dev,
|
|
const struct iio_chan_spec *chan,
|
|
enum iio_event_type type,
|
|
enum iio_event_direction dir,
|
|
enum iio_event_info info, int val,
|
|
int val2);
|
|
|
|
int iio_simple_dummy_events_register(struct iio_dev *indio_dev);
|
|
void iio_simple_dummy_events_unregister(struct iio_dev *indio_dev);
|
|
|
|
#else /* Stubs for when events are disabled at compile time */
|
|
|
|
static inline int
|
|
iio_simple_dummy_events_register(struct iio_dev *indio_dev)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline void
|
|
iio_simple_dummy_events_unregister(struct iio_dev *indio_dev)
|
|
{}
|
|
|
|
#endif /* CONFIG_IIO_SIMPLE_DUMMY_EVENTS*/
|
|
|
|
/**
|
|
* enum iio_simple_dummy_scan_elements - scan index enum
|
|
* @DUMMY_INDEX_VOLTAGE_0: the single ended voltage channel
|
|
* @DUMMY_INDEX_DIFFVOLTAGE_1M2: first differential channel
|
|
* @DUMMY_INDEX_DIFFVOLTAGE_3M4: second differential channel
|
|
* @DUMMY_INDEX_ACCELX: acceleration channel
|
|
*
|
|
* Enum provides convenient numbering for the scan index.
|
|
*/
|
|
enum iio_simple_dummy_scan_elements {
|
|
DUMMY_INDEX_VOLTAGE_0,
|
|
DUMMY_INDEX_DIFFVOLTAGE_1M2,
|
|
DUMMY_INDEX_DIFFVOLTAGE_3M4,
|
|
DUMMY_INDEX_ACCELX,
|
|
};
|
|
|
|
#ifdef CONFIG_IIO_SIMPLE_DUMMY_BUFFER
|
|
int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev);
|
|
void iio_simple_dummy_unconfigure_buffer(struct iio_dev *indio_dev);
|
|
#else
|
|
static inline int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline
|
|
void iio_simple_dummy_unconfigure_buffer(struct iio_dev *indio_dev)
|
|
{}
|
|
|
|
#endif /* CONFIG_IIO_SIMPLE_DUMMY_BUFFER */
|
|
#endif /* _IIO_SIMPLE_DUMMY_H_ */
|