mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
ac4531424d
devm_drm_bridge_alloc() is the new API to be used for allocating (and partially initializing) a private driver struct embedding a struct drm_bridge. This driver was missed during the automated conversion in commit9c399719cf("drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API") and following commits. The lack of conversion for this driver is a bug since commita7748dd127("drm/bridge: get/put the bridge reference in drm_bridge_add/remove()") which is the first commmit having added a drm_bridge_get/put() pair and thus exposing the incorrect initial refcount issue. Fix this by switching the driver to the new API. Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> Closes: https://lore.kernel.org/all/ce9c6aa3-5372-468f-a4bf-5a261259e459@samsung.com/ Fixes:a7748dd127("drm/bridge: get/put the bridge reference in drm_bridge_add/remove()") Reviewed-by: Maxime Ripard <mripard@kernel.org> Link: https://lore.kernel.org/r/20250708-drm-bridge-convert-to-alloc-api-leftovers-v1-1-6285de8c3759@bootlin.com Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
114 lines
3 KiB
C
114 lines
3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Copyright (C) STMicroelectronics SA 2014
|
|
* Author: Vincent Abriou <vincent.abriou@st.com> for STMicroelectronics.
|
|
*/
|
|
|
|
#ifndef _STI_HDMI_H_
|
|
#define _STI_HDMI_H_
|
|
|
|
#include <linux/hdmi.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <media/cec-notifier.h>
|
|
|
|
#include <drm/drm_bridge.h>
|
|
#include <drm/drm_modes.h>
|
|
#include <drm/drm_property.h>
|
|
|
|
#define HDMI_STA 0x0010
|
|
#define HDMI_STA_DLL_LCK BIT(5)
|
|
#define HDMI_STA_HOT_PLUG BIT(4)
|
|
|
|
struct sti_hdmi;
|
|
|
|
struct hdmi_phy_ops {
|
|
bool (*start)(struct sti_hdmi *hdmi);
|
|
void (*stop)(struct sti_hdmi *hdmi);
|
|
};
|
|
|
|
struct hdmi_audio_params {
|
|
bool enabled;
|
|
unsigned int sample_width;
|
|
unsigned int sample_rate;
|
|
struct hdmi_audio_infoframe cea;
|
|
};
|
|
|
|
#define DEFAULT_COLORSPACE_MODE HDMI_COLORSPACE_RGB
|
|
|
|
/**
|
|
* STI hdmi structure
|
|
*
|
|
* @dev: driver device
|
|
* @drm_dev: pointer to drm device
|
|
* @mode: current display mode selected
|
|
* @regs: hdmi register
|
|
* @syscfg: syscfg register for pll rejection configuration
|
|
* @clk_pix: hdmi pixel clock
|
|
* @clk_tmds: hdmi tmds clock
|
|
* @clk_phy: hdmi phy clock
|
|
* @clk_audio: hdmi audio clock
|
|
* @irq: hdmi interrupt number
|
|
* @irq_status: interrupt status register
|
|
* @phy_ops: phy start/stop operations
|
|
* @enabled: true if hdmi is enabled else false
|
|
* @hpd: hot plug detect status
|
|
* @wait_event: wait event
|
|
* @event_received: wait event status
|
|
* @reset: reset control of the hdmi phy
|
|
* @ddc_adapt: i2c ddc adapter
|
|
* @colorspace: current colorspace selected
|
|
* @audio_pdev: ASoC hdmi-codec platform device
|
|
* @audio: hdmi audio parameters.
|
|
* @drm_connector: hdmi connector
|
|
* @notifier: hotplug detect notifier
|
|
*/
|
|
struct sti_hdmi {
|
|
struct device dev;
|
|
struct drm_device *drm_dev;
|
|
struct drm_display_mode mode;
|
|
void __iomem *regs;
|
|
void __iomem *syscfg;
|
|
struct clk *clk_pix;
|
|
struct clk *clk_tmds;
|
|
struct clk *clk_phy;
|
|
struct clk *clk_audio;
|
|
int irq;
|
|
u32 irq_status;
|
|
struct hdmi_phy_ops *phy_ops;
|
|
bool enabled;
|
|
bool hpd;
|
|
wait_queue_head_t wait_event;
|
|
bool event_received;
|
|
struct reset_control *reset;
|
|
struct i2c_adapter *ddc_adapt;
|
|
enum hdmi_colorspace colorspace;
|
|
struct platform_device *audio_pdev;
|
|
struct hdmi_audio_params audio;
|
|
struct drm_connector *drm_connector;
|
|
struct cec_notifier *notifier;
|
|
struct drm_bridge bridge;
|
|
};
|
|
|
|
u32 hdmi_read(struct sti_hdmi *hdmi, int offset);
|
|
void hdmi_write(struct sti_hdmi *hdmi, u32 val, int offset);
|
|
|
|
/**
|
|
* hdmi phy config structure
|
|
*
|
|
* A pointer to an array of these structures is passed to a TMDS (HDMI) output
|
|
* via the control interface to provide board and SoC specific
|
|
* configurations of the HDMI PHY. Each entry in the array specifies a hardware
|
|
* specific configuration for a given TMDS clock frequency range.
|
|
*
|
|
* @min_tmds_freq: Lower bound of TMDS clock frequency this entry applies to
|
|
* @max_tmds_freq: Upper bound of TMDS clock frequency this entry applies to
|
|
* @config: SoC specific register configuration
|
|
*/
|
|
struct hdmi_phy_config {
|
|
u32 min_tmds_freq;
|
|
u32 max_tmds_freq;
|
|
u32 config[4];
|
|
};
|
|
|
|
#endif
|