mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
b047cbe5e5
The msm_dp_utils_pack_sdp_header() accepts an unlimited-size u32 pointer
for the header output, while it expects a two-element array. It performs
a sizeof check which is always true on 64-bit platforms (since
sizeof(u32*) is 8) and is always false on 32-bit platforms. It returns
an error code which nobody actually checks.
Fix the function interface to accept u32[2] and return void, skipping
all the checks.
Fixes: 55fb8ffc18 ("drm/msm/dp: add VSC SDP support for YUV420 over DP")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/626806/
Link: https://lore.kernel.org/r/20241202-fd-dp-audio-fixup-v2-2-d9187ea96dad@linaro.org
[quic_abhinavk@quicinc.com: minor fix in the commit message]
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
36 lines
1 KiB
C
36 lines
1 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* Copyright (c) 2024, The Linux Foundation. All rights reserved.
|
|
*/
|
|
|
|
#ifndef _DP_UTILS_H_
|
|
#define _DP_UTILS_H_
|
|
|
|
#include <linux/bitfield.h>
|
|
#include <linux/bits.h>
|
|
#include <drm/display/drm_dp_helper.h>
|
|
|
|
#define HEADER_BYTE_0_BIT 0
|
|
#define PARITY_BYTE_0_BIT 8
|
|
#define HEADER_BYTE_1_BIT 16
|
|
#define PARITY_BYTE_1_BIT 24
|
|
#define HEADER_BYTE_2_BIT 0
|
|
#define PARITY_BYTE_2_BIT 8
|
|
#define HEADER_BYTE_3_BIT 16
|
|
#define PARITY_BYTE_3_BIT 24
|
|
|
|
#define HEADER_0_MASK GENMASK(7, 0)
|
|
#define PARITY_0_MASK GENMASK(15, 8)
|
|
#define HEADER_1_MASK GENMASK(23, 16)
|
|
#define PARITY_1_MASK GENMASK(31, 24)
|
|
#define HEADER_2_MASK GENMASK(7, 0)
|
|
#define PARITY_2_MASK GENMASK(15, 8)
|
|
#define HEADER_3_MASK GENMASK(23, 16)
|
|
#define PARITY_3_MASK GENMASK(31, 24)
|
|
|
|
u8 msm_dp_utils_get_g0_value(u8 data);
|
|
u8 msm_dp_utils_get_g1_value(u8 data);
|
|
u8 msm_dp_utils_calculate_parity(u32 data);
|
|
void msm_dp_utils_pack_sdp_header(struct dp_sdp_header *sdp_header, u32 header_buff[2]);
|
|
|
|
#endif /* _DP_UTILS_H_ */
|