mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
e3ea2eae70
HuC delayed loading fence, introduced with commit27536e0327("drm/i915/huc: track delayed HuC load with a fence"), is registered with object tracker early on driver probe but unregistered only from driver remove, which is not called on early probe errors. Since its memory is allocated under devres, then released anyway, it may happen to be allocated again to the fence and reused on future driver probes, resulting in kernel warnings that taint the kernel: <4> [309.731371] ------------[ cut here ]------------ <3> [309.731373] ODEBUG: init destroyed (active state 0) object: ffff88813d7dd2e0 object type: i915_sw_fence hint: sw_fence_dummy_notify+0x0/0x20 [i915] <4> [309.731575] WARNING: CPU: 2 PID: 3161 at lib/debugobjects.c:612 debug_print_object+0x93/0xf0 ... <4> [309.731693] CPU: 2 UID: 0 PID: 3161 Comm: i915_module_loa Tainted: G U 6.14.0-CI_DRM_16362-gf0fd77956987+ #1 ... <4> [309.731700] RIP: 0010:debug_print_object+0x93/0xf0 ... <4> [309.731728] Call Trace: <4> [309.731730] <TASK> ... <4> [309.731949] __debug_object_init+0x17b/0x1c0 <4> [309.731957] debug_object_init+0x34/0x50 <4> [309.732126] __i915_sw_fence_init+0x34/0x60 [i915] <4> [309.732256] intel_huc_init_early+0x4b/0x1d0 [i915] <4> [309.732468] intel_uc_init_early+0x61/0x680 [i915] <4> [309.732667] intel_gt_common_init_early+0x105/0x130 [i915] <4> [309.732804] intel_root_gt_init_early+0x63/0x80 [i915] <4> [309.732938] i915_driver_probe+0x1fa/0xeb0 [i915] <4> [309.733075] i915_pci_probe+0xe6/0x220 [i915] <4> [309.733198] local_pci_probe+0x44/0xb0 <4> [309.733203] pci_device_probe+0xf4/0x270 <4> [309.733209] really_probe+0xee/0x3c0 <4> [309.733215] __driver_probe_device+0x8c/0x180 <4> [309.733219] driver_probe_device+0x24/0xd0 <4> [309.733223] __driver_attach+0x10f/0x220 <4> [309.733230] bus_for_each_dev+0x7d/0xe0 <4> [309.733236] driver_attach+0x1e/0x30 <4> [309.733239] bus_add_driver+0x151/0x290 <4> [309.733244] driver_register+0x5e/0x130 <4> [309.733247] __pci_register_driver+0x7d/0x90 <4> [309.733251] i915_pci_register_driver+0x23/0x30 [i915] <4> [309.733413] i915_init+0x34/0x120 [i915] <4> [309.733655] do_one_initcall+0x62/0x3f0 <4> [309.733667] do_init_module+0x97/0x2a0 <4> [309.733671] load_module+0x25ff/0x2890 <4> [309.733688] init_module_from_file+0x97/0xe0 <4> [309.733701] idempotent_init_module+0x118/0x330 <4> [309.733711] __x64_sys_finit_module+0x77/0x100 <4> [309.733715] x64_sys_call+0x1f37/0x2650 <4> [309.733719] do_syscall_64+0x91/0x180 <4> [309.733763] entry_SYSCALL_64_after_hwframe+0x76/0x7e <4> [309.733792] </TASK> ... <4> [309.733806] ---[ end trace 0000000000000000 ]--- That scenario is most easily reproducible with igt@i915_module_load@reload-with-fault-injection. Fix the issue by moving the cleanup step to driver release path. Fixes:27536e0327("drm/i915/huc: track delayed HuC load with a fence") Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13592 Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Cc: Alan Previn <alan.previn.teres.alexis@intel.com> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Link: https://lore.kernel.org/r/20250402172057.209924-2-janusz.krzysztofik@linux.intel.com (cherry picked from commit795dbde92f) Signed-off-by: Jani Nikula <jani.nikula@intel.com>
101 lines
2.6 KiB
C
101 lines
2.6 KiB
C
/* SPDX-License-Identifier: MIT */
|
|
/*
|
|
* Copyright © 2014-2019 Intel Corporation
|
|
*/
|
|
|
|
#ifndef _INTEL_HUC_H_
|
|
#define _INTEL_HUC_H_
|
|
|
|
#include "i915_reg_defs.h"
|
|
#include "i915_sw_fence.h"
|
|
#include "intel_uc_fw.h"
|
|
#include "intel_huc_fw.h"
|
|
|
|
#include <linux/notifier.h>
|
|
#include <linux/hrtimer.h>
|
|
|
|
struct bus_type;
|
|
struct i915_vma;
|
|
|
|
enum intel_huc_delayed_load_status {
|
|
INTEL_HUC_WAITING_ON_GSC = 0,
|
|
INTEL_HUC_WAITING_ON_PXP,
|
|
INTEL_HUC_DELAYED_LOAD_ERROR,
|
|
};
|
|
|
|
enum intel_huc_authentication_type {
|
|
INTEL_HUC_AUTH_BY_GUC = 0,
|
|
INTEL_HUC_AUTH_BY_GSC,
|
|
INTEL_HUC_AUTH_MAX_MODES
|
|
};
|
|
|
|
struct intel_huc {
|
|
/* Generic uC firmware management */
|
|
struct intel_uc_fw fw;
|
|
|
|
/* HuC-specific additions */
|
|
struct {
|
|
i915_reg_t reg;
|
|
u32 mask;
|
|
u32 value;
|
|
} status[INTEL_HUC_AUTH_MAX_MODES];
|
|
|
|
struct {
|
|
struct i915_sw_fence fence;
|
|
struct hrtimer timer;
|
|
struct notifier_block nb;
|
|
enum intel_huc_delayed_load_status status;
|
|
} delayed_load;
|
|
|
|
/* for load via GSCCS */
|
|
struct i915_vma *heci_pkt;
|
|
|
|
bool loaded_via_gsc;
|
|
};
|
|
|
|
int intel_huc_sanitize(struct intel_huc *huc);
|
|
void intel_huc_init_early(struct intel_huc *huc);
|
|
void intel_huc_fini_late(struct intel_huc *huc);
|
|
int intel_huc_init(struct intel_huc *huc);
|
|
void intel_huc_fini(struct intel_huc *huc);
|
|
int intel_huc_auth(struct intel_huc *huc, enum intel_huc_authentication_type type);
|
|
int intel_huc_wait_for_auth_complete(struct intel_huc *huc,
|
|
enum intel_huc_authentication_type type);
|
|
bool intel_huc_is_authenticated(struct intel_huc *huc,
|
|
enum intel_huc_authentication_type type);
|
|
int intel_huc_check_status(struct intel_huc *huc);
|
|
void intel_huc_update_auth_status(struct intel_huc *huc);
|
|
|
|
void intel_huc_register_gsc_notifier(struct intel_huc *huc, const struct bus_type *bus);
|
|
void intel_huc_unregister_gsc_notifier(struct intel_huc *huc, const struct bus_type *bus);
|
|
|
|
static inline bool intel_huc_is_supported(struct intel_huc *huc)
|
|
{
|
|
return intel_uc_fw_is_supported(&huc->fw);
|
|
}
|
|
|
|
static inline bool intel_huc_is_wanted(struct intel_huc *huc)
|
|
{
|
|
return intel_uc_fw_is_enabled(&huc->fw);
|
|
}
|
|
|
|
static inline bool intel_huc_is_used(struct intel_huc *huc)
|
|
{
|
|
GEM_BUG_ON(__intel_uc_fw_status(&huc->fw) == INTEL_UC_FIRMWARE_SELECTED);
|
|
return intel_uc_fw_is_available(&huc->fw);
|
|
}
|
|
|
|
static inline bool intel_huc_is_loaded_by_gsc(const struct intel_huc *huc)
|
|
{
|
|
return huc->loaded_via_gsc;
|
|
}
|
|
|
|
static inline bool intel_huc_wait_required(struct intel_huc *huc)
|
|
{
|
|
return intel_huc_is_used(huc) && intel_huc_is_loaded_by_gsc(huc) &&
|
|
!intel_huc_is_authenticated(huc, INTEL_HUC_AUTH_BY_GSC);
|
|
}
|
|
|
|
void intel_huc_load_status(struct intel_huc *huc, struct drm_printer *p);
|
|
|
|
#endif
|