mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
23717055a7
The debugfs functions are guaranteed to return a valid error code
instead of NULL upon failure. Consequently, the driver can directly
propagate any error returned without additional checks.
Remove the unnecessary `if` statement after debugfs_create_dir(). If
this function fails, the error code is stored in accel_dev->debugfs_dir
and utilized in subsequent debugfs calls.
Additionally, since accel_dev->debugfs_dir is assured to be non-NULL,
remove the superfluous NULL pointer checks within the adf_dbgfs_add()
and adf_dbgfs_rm().
Fixes: 9260db6640 ("crypto: qat - move dbgfs init to separate file")
Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
79 lines
2.1 KiB
C
79 lines
2.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/* Copyright(c) 2023 Intel Corporation */
|
|
|
|
#include <linux/debugfs.h>
|
|
#include "adf_accel_devices.h"
|
|
#include "adf_cfg.h"
|
|
#include "adf_common_drv.h"
|
|
#include "adf_cnv_dbgfs.h"
|
|
#include "adf_dbgfs.h"
|
|
#include "adf_fw_counters.h"
|
|
#include "adf_heartbeat_dbgfs.h"
|
|
#include "adf_pm_dbgfs.h"
|
|
#include "adf_tl_debugfs.h"
|
|
|
|
/**
|
|
* adf_dbgfs_init() - add persistent debugfs entries
|
|
* @accel_dev: Pointer to acceleration device.
|
|
*
|
|
* This function creates debugfs entries that are persistent through a device
|
|
* state change (from up to down or vice versa).
|
|
*/
|
|
void adf_dbgfs_init(struct adf_accel_dev *accel_dev)
|
|
{
|
|
char name[ADF_DEVICE_NAME_LENGTH];
|
|
|
|
/* Create dev top level debugfs entry */
|
|
snprintf(name, sizeof(name), "%s%s_%s", ADF_DEVICE_NAME_PREFIX,
|
|
accel_dev->hw_device->dev_class->name,
|
|
pci_name(accel_dev->accel_pci_dev.pci_dev));
|
|
|
|
accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
|
|
|
|
adf_cfg_dev_dbgfs_add(accel_dev);
|
|
}
|
|
EXPORT_SYMBOL_GPL(adf_dbgfs_init);
|
|
|
|
/**
|
|
* adf_dbgfs_exit() - remove persistent debugfs entries
|
|
* @accel_dev: Pointer to acceleration device.
|
|
*/
|
|
void adf_dbgfs_exit(struct adf_accel_dev *accel_dev)
|
|
{
|
|
adf_cfg_dev_dbgfs_rm(accel_dev);
|
|
debugfs_remove(accel_dev->debugfs_dir);
|
|
}
|
|
EXPORT_SYMBOL_GPL(adf_dbgfs_exit);
|
|
|
|
/**
|
|
* adf_dbgfs_add() - add non-persistent debugfs entries
|
|
* @accel_dev: Pointer to acceleration device.
|
|
*
|
|
* This function creates debugfs entries that are not persistent through
|
|
* a device state change (from up to down or vice versa).
|
|
*/
|
|
void adf_dbgfs_add(struct adf_accel_dev *accel_dev)
|
|
{
|
|
if (!accel_dev->is_vf) {
|
|
adf_fw_counters_dbgfs_add(accel_dev);
|
|
adf_heartbeat_dbgfs_add(accel_dev);
|
|
adf_pm_dbgfs_add(accel_dev);
|
|
adf_cnv_dbgfs_add(accel_dev);
|
|
adf_tl_dbgfs_add(accel_dev);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* adf_dbgfs_rm() - remove non-persistent debugfs entries
|
|
* @accel_dev: Pointer to acceleration device.
|
|
*/
|
|
void adf_dbgfs_rm(struct adf_accel_dev *accel_dev)
|
|
{
|
|
if (!accel_dev->is_vf) {
|
|
adf_tl_dbgfs_rm(accel_dev);
|
|
adf_cnv_dbgfs_rm(accel_dev);
|
|
adf_pm_dbgfs_rm(accel_dev);
|
|
adf_heartbeat_dbgfs_rm(accel_dev);
|
|
adf_fw_counters_dbgfs_rm(accel_dev);
|
|
}
|
|
}
|