mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
b79276dcac
arch_init_invariance_cppc() is called at the end of acpi_cppc_processor_probe() in order to configure frequency invariance based upon the values from _CPC. This however doesn't work on AMD CPPC shared memory designs that have AMD preferred cores enabled because _CPC needs to be analyzed from all cores to judge if preferred cores are enabled. This issue manifests to users as a warning since commit21fb59ab4b("ACPI: CPPC: Adjust debug messages in amd_set_max_freq_ratio() to warn"): ``` Could not retrieve highest performance (-19) ``` However the warning isn't the cause of this, it was actually commit279f838a61("x86/amd: Detect preferred cores in amd_get_boost_ratio_numerator()") which exposed the issue. To fix this problem, change arch_init_invariance_cppc() into a new weak symbol that is called at the end of acpi_processor_driver_init(). Each architecture that supports it can declare the symbol to override the weak one. Define it for x86, in arch/x86/kernel/acpi/cppc.c, and for all of the architectures using the generic arch_topology.c code. Fixes:279f838a61("x86/amd: Detect preferred cores in amd_get_boost_ratio_numerator()") Reported-by: Ivan Shapovalov <intelfx@intelfx.name> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219431 Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://patch.msgid.link/20241104222855.3959267-1-superm1@kernel.org [ rjw: Changelog edit ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
41 lines
1.2 KiB
C
41 lines
1.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __ASM_TOPOLOGY_H
|
|
#define __ASM_TOPOLOGY_H
|
|
|
|
#include <linux/cpumask.h>
|
|
|
|
#ifdef CONFIG_NUMA
|
|
#include <asm/numa.h>
|
|
|
|
struct pci_bus;
|
|
int pcibus_to_node(struct pci_bus *bus);
|
|
#define cpumask_of_pcibus(bus) (pcibus_to_node(bus) == -1 ? \
|
|
cpu_all_mask : \
|
|
cpumask_of_node(pcibus_to_node(bus)))
|
|
|
|
#endif /* CONFIG_NUMA */
|
|
|
|
#include <linux/arch_topology.h>
|
|
|
|
void update_freq_counters_refs(void);
|
|
|
|
/* Replace task scheduler's default frequency-invariant accounting */
|
|
#define arch_scale_freq_tick topology_scale_freq_tick
|
|
#define arch_set_freq_scale topology_set_freq_scale
|
|
#define arch_scale_freq_capacity topology_get_freq_scale
|
|
#define arch_scale_freq_invariant topology_scale_freq_invariant
|
|
#define arch_scale_freq_ref topology_get_freq_ref
|
|
|
|
/* Replace task scheduler's default cpu-invariant accounting */
|
|
#define arch_scale_cpu_capacity topology_get_cpu_scale
|
|
|
|
/* Enable topology flag updates */
|
|
#define arch_update_cpu_topology topology_update_cpu_topology
|
|
|
|
/* Replace task scheduler's default HW pressure API */
|
|
#define arch_scale_hw_pressure topology_get_hw_pressure
|
|
#define arch_update_hw_pressure topology_update_hw_pressure
|
|
|
|
#include <asm-generic/topology.h>
|
|
|
|
#endif /* _ASM_ARM_TOPOLOGY_H */
|