Huang Rui
4dbcdc9cad
drm/amd/display: fix the NULL pointer that missed set_disp_pattern_generator callback
...
This patch is to fix the NULL pointer that missed set_disp_pattern_generator callback on DCN301
[ 505.054167] BUG: kernel NULL pointer dereference, address: 0000000000000000
[ 505.054176] #PF: supervisor instruction fetch in kernel mode
[ 505.054181] #PF: error_code(0x0010) - not-present page
[ 505.054185] PGD 0 P4D 0
[ 505.054199] Oops: 0010 [#1 ] SMP NOPTI
[ 505.054211] CPU: 6 PID: 1306 Comm: modprobe Tainted: G W OE 5.9.0-rc5-custom #1
[ 505.054216] Hardware name: AMD Chachani-VN/Chachani-VN, BIOS WCH0A29N_RAPV16.FD 10/29/2020
[ 505.054225] RIP: 0010:0x0
[ 505.054234] Code: Bad RIP value.
[ 505.054239] RSP: 0018:ffffb88541c66f60 EFLAGS: 00010206
[ 505.054245] RAX: 0000000000000000 RBX: ffff912836070000 RCX: 0000000000000003
[ 505.054248] RDX: 000000000000000c RSI: ffff9128365001e8 RDI: ffff912836070000
[ 505.054252] RBP: ffffb88541c66fd8 R08: 0000000000000002 R09: ffffb88541c66fa2
[ 505.054265] R10: 0000000000009580 R11: 0000000000000008 R12: ffff9128365001e8
[ 505.054272] R13: 000000000000000c R14: 0000000000000438 R15: ffff9128a48bd000
[ 505.054279] FS: 00007f09f999f540(0000) GS:ffff9128b3f80000(0000) knlGS:0000000000000000
[ 505.054284] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 505.054288] CR2: ffffffffffffffd6 CR3: 00000002db98c000 CR4: 0000000000350ee0
[ 505.054291] Call Trace:
[ 505.055024] dcn20_blank_pixel_data+0x148/0x260 [amdgpu]
[ 505.055730] dcn20_enable_stream_timing+0x381/0x47c [amdgpu]
[ 505.056641] dce110_apply_ctx_to_hw+0x337/0x577 [amdgpu]
[ 505.056667] ? put_object+0x2f/0x40
[ 505.057329] dc_commit_state+0x4b3/0x9d0 [amdgpu]
[ 505.058030] amdgpu_dm_atomic_commit_tail+0x405/0x1ec6 [amdgpu]
[ 505.058053] ? update_stack_state+0x103/0x170
[ 505.058071] ? __module_text_address+0x12/0x60
Signed-off-by: Huang Rui <ray.huang@amd.com>
Tested-by: Changfeng <Changfeng.Zhu@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2020-11-02 15:33:26 -05:00
Alvin Lee
86c5a9e3aa
drm/amd/display: Update GSL state if leaving immediate flip
...
[Why]
We should leave GSL if we're not doing immediate flip no matter if
we're doing pipe split or not
[How]
Check for updating GSL state whenever we're not doing
immediate flip
v2: Squash in build fix (Alex)
Signed-off-by: Aric Cyr <aric.cyr@amd.com>
Signed-off-by: Alvin Lee <alvin.lee2@amd.com>
Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2020-10-26 13:33:24 -04:00
Roman Li
df043738b7
drm/amd/display: Refactor ABM_MASK_SH_LIST_DCN301 naming
...
[Why]
All DCN3x resources share ABM_MASK_SH_LIST_DCN301 definition.
The naming is misleading since it looks like DCN30 code
depends on next version DCN301, which in fact is vice-versa.
[How]
Refactor the naming to ABM_MASK_SH_LIST_DCN30.
v2: squash in build fixes (Alex)
Signed-off-by: Roman Li <roman.li@amd.com>
Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2020-10-26 13:30:38 -04:00
Huang Rui
f9dbefa884
drm/amdgpu/display: fix the NULL pointer reference on dmucb on dcn301
...
DCN301 needs to use dmub create abm instance instead of dce.
[ 1138.854204] BUG: kernel NULL pointer dereference, address: 0000000000000000
[ 1138.854206] #PF: supervisor instruction fetch in kernel mode
[ 1138.854207] #PF: error_code(0x0010) - not-present page
[ 1138.854208] PGD 0 P4D 0
[ 1138.854212] Oops: 0010 [#1 ] SMP NOPTI
[ 1138.854216] CPU: 6 PID: 1240 Comm: modprobe Tainted: G W OE 5.9.0-rc2-custom #1
[ 1138.854217] Hardware name: AMD Chachani-VN/Chachani-VN, BIOS BAerithA104 10/01/2020
[ 1138.854221] RIP: 0010:0x0
[ 1138.854224] Code: Bad RIP value.
[ 1138.854226] RSP: 0018:ffffc90001c4f638 EFLAGS: 00010286
[ 1138.854228] RAX: 0000000000000000 RBX: ffff88804f2b2800 RCX: ffffc90001c4f740
[ 1138.854229] RDX: 00000000000000e8 RSI: ffffc90001c4f640 RDI: ffff88805816f300
[ 1138.854230] RBP: ffffc90001c4f850 R08: ffffc90001c4f644 R09: ffffc90001c4f654
[ 1138.854231] R10: ffffc90001c4f72c R11: ffffc90001c4f740 R12: ffffc90001c4f640
[ 1138.854232] R13: ffffc90001c4f728 R14: 0000000000000000 R15: ffff888007296381
[ 1138.854235] FS: 00007f5f44d84540(0000) GS:ffff88805e380000(0000) knlGS:0000000000000000
[ 1138.854236] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1138.854237] CR2: ffffffffffffffd6 CR3: 00000000194f4000 CR4: 0000000000050ee0
[ 1138.854239] Call Trace:
[ 1138.854447] dmub_init_abm_config+0x220/0x267 [amdgpu]
[ 1138.854654] dm_late_init+0x197/0x1ad [amdgpu]
[ 1138.854846] ? dm_late_init+0x197/0x1ad [amdgpu]
[ 1138.854999] amdgpu_device_ip_late_init+0x6f/0x21b [amdgpu]
[ 1138.855148] amdgpu_device_init+0x1b7f/0x1cfb [amdgpu]
[ 1138.855293] amdgpu_driver_load_kms+0x2c/0x26e [amdgpu]
[ 1138.855437] amdgpu_pci_probe+0x1c7/0x249 [amdgpu]
[ 1138.920489] local_pci_probe+0x48/0x80
[ 1138.920492] pci_device_probe+0x10f/0x1c0
Signed-off-by: Huang Rui <ray.huang@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2020-10-16 14:44:11 -04:00
Roman Li
3a83e4e64b
drm/amd/display: Add dcn3.01 support to DC (v2)
...
Update dc for vangogh support.
v2: fix compilation without DCN 301 set.
Signed-off-by: Roman Li <Roman.Li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2020-10-05 15:15:56 -04:00
